From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver
Date: Mon, 03 Nov 2014 10:45:03 +0200 [thread overview]
Message-ID: <1415004303.407.11.camel@mm-sol.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1410312128100.18476@pmeerw.net>
On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote:
> > Ivan T. Ivanov schrieb am 22.10.2014 16:13:
> > > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has
> > > 16 bits resolution and register space inside PMIC accessible across
> > > SPMI bus.
> > >
> > > The driver registers itself through IIO interface.
> > Pretty much there, just one question I would like to double-check: The CPU of these chips is
> Little Endian, right?
> > Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a
> new revision. A separate patch fixing it would probably be best. See inline.
>
> some minor comments below
Thanks, will fix them. IIO maintainers, what do you
prefer, new version or fallow-up patch?
Regards,
Ivan
next prev parent reply other threads:[~2014-11-03 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 14:13 [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver Ivan T. Ivanov
2014-10-25 20:04 ` Jonathan Cameron
2014-10-31 20:13 ` Hartmut Knaack
2014-10-31 20:48 ` Peter Meerwald
2014-11-03 8:45 ` Ivan T. Ivanov [this message]
2014-11-05 16:06 ` Jonathan Cameron
2014-11-01 16:39 ` Ivan T. Ivanov
2014-11-01 19:46 ` Hartmut Knaack
2014-11-03 8:41 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415004303.407.11.camel@mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox