From: Bastien Nocera <hadess@hadess.net>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: Re: [PATCH v3] iio:kxcjk-1013: Add support for SMO8500 device
Date: Wed, 05 Nov 2014 16:47:19 +0100 [thread overview]
Message-ID: <1415202439.7630.13.camel@hadess.net> (raw)
In-Reply-To: <CAEnQRZDD40S7ScRsKmAHR_XsA-moAzyvYUqEyiT9ME6dDM9zfA@mail.gmail.com>
On Wed, 2014-11-05 at 17:22 +0200, Daniel Baluta wrote:
> >> @@ -1397,6 +1404,7 @@ static const struct acpi_device_id
> kx_acpi_match[] = {
> >> {"KXCJ1013", KXCJK1013},
> >> {"KXCJ1008", KXCJ91008},
> >> {"KXTJ1009", KXTJ21009},
> >> + {"SMO8500", KXCJK1013},
>
> Commit message says that your accel is KXCJ9, but here you use the
> index
> for KXCJK1013. Which one is true?
>
> >> { },
> >> };
> >> MODULE_DEVICE_TABLE(acpi, kx_acpi_match);
> >> @@ -1405,6 +1413,7 @@ static const struct i2c_device_id
> kxcjk1013_id[] = {
> >> {"kxcjk1013", KXCJK1013},
> >> {"kxcj91008", KXCJ91008},
> >> {"kxtj21009", KXTJ21009},
> >> + {"SMO8500", KXCJK1013},
>
> Ditto.
Missed this. Will respin a patch after testing, though the differences
in code between the 2 devices are very minimal it seems (only some PM
functionality).
prev parent reply other threads:[~2014-11-05 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 23:20 [PATCH v3] iio:kxcjk-1013: Add support for SMO8500 device Bastien Nocera
2014-11-05 14:38 ` Jonathan Cameron
2014-11-05 15:22 ` Daniel Baluta
2014-11-05 15:28 ` Bastien Nocera
2014-11-05 15:46 ` Daniel Baluta
2014-11-05 15:47 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415202439.7630.13.camel@hadess.net \
--to=hadess@hadess.net \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox