linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Dogaru <vlad.dogaru@intel.com>
To: linux-iio@vger.kernel.org
Cc: Vlad Dogaru <vlad.dogaru@intel.com>
Subject: [PATCH 1/4] iio: dummy: set scan_index for unbuffered channels
Date: Tue, 25 Nov 2014 14:48:04 +0200	[thread overview]
Message-ID: <1416919687-14271-2-git-send-email-vlad.dogaru@intel.com> (raw)
In-Reply-To: <1416919687-14271-1-git-send-email-vlad.dogaru@intel.com>

If we do not set scan_index explicitly it will default to 0, causing
more than one channel to have the same scan_index.  This does not make
sense, as scan_index is used to order values in a buffer sample.

Set the activity and voltage output channels to unbuffered
(scan_index = -1) to fix this.

Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
---
 drivers/staging/iio/iio_simple_dummy.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
index 10a9e08..2948900 100644
--- a/drivers/staging/iio/iio_simple_dummy.c
+++ b/drivers/staging/iio/iio_simple_dummy.c
@@ -242,6 +242,7 @@ static const struct iio_chan_spec iio_dummy_channels[] = {
 		.output = 1,
 		.indexed = 1,
 		.channel = 0,
+		.scan_index = -1,
 	},
 	{
 		.type = IIO_STEPS,
@@ -259,6 +260,7 @@ static const struct iio_chan_spec iio_dummy_channels[] = {
 		.modified = 1,
 		.channel2 = IIO_MOD_RUNNING,
 		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
+		.scan_index = -1,
 #ifdef CONFIG_IIO_SIMPLE_DUMMY_EVENTS
 		.event_spec = &iio_running_event,
 		.num_event_specs = 1,
@@ -269,6 +271,7 @@ static const struct iio_chan_spec iio_dummy_channels[] = {
 		.modified = 1,
 		.channel2 = IIO_MOD_WALKING,
 		.info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED),
+		.scan_index = -1,
 #ifdef CONFIG_IIO_SIMPLE_DUMMY_EVENTS
 		.event_spec = &iio_walking_event,
 		.num_event_specs = 1,
-- 
1.9.1


  reply	other threads:[~2014-11-25 12:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 12:48 [PATCH 0/4] Add valid sample channel Vlad Dogaru
2014-11-25 12:48 ` Vlad Dogaru [this message]
2014-11-25 16:11   ` [PATCH 1/4] iio: dummy: set scan_index for unbuffered channels Daniel Baluta
2014-12-12 11:48     ` Jonathan Cameron
2014-11-25 12:48 ` [PATCH 2/4] iio: ensure scan index is unique at buffer register Vlad Dogaru
2014-12-06 20:19   ` Hartmut Knaack
2014-12-12 11:50     ` Jonathan Cameron
2014-11-25 12:48 ` [RFC PATCH 3/4] iio: add valid sample channel Vlad Dogaru
2014-11-25 12:48 ` [RFC PATCH 4/4] iio: illustrate the use of a " Vlad Dogaru
2014-11-25 16:36 ` [PATCH 0/4] Add " Lars-Peter Clausen
2014-11-25 16:55   ` Daniel Baluta
2014-11-25 17:00     ` Lars-Peter Clausen
2014-11-25 17:29       ` Jonathan Cameron
2014-11-25 18:27         ` Octavian Purdila
2014-11-25 18:53           ` Lars-Peter Clausen
2014-11-26 12:58         ` Daniel Baluta
2014-12-01 20:06           ` Lars-Peter Clausen
2014-12-01 20:46             ` Daniel Baluta
2014-12-01 20:51               ` Lars-Peter Clausen
2014-12-01 21:03                 ` Daniel Baluta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416919687-14271-2-git-send-email-vlad.dogaru@intel.com \
    --to=vlad.dogaru@intel.com \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).