* [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom
@ 2014-12-30 18:44 Roberta Dobrescu
2015-01-01 12:19 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:44 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patch increases sleep time in ad9523_store_eeprom to 20ms since
it isn't timing critical. It fixes the following checkpatch.pl warning:
WARNING: msleep < 20ms can sleep for up to 20ms
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
Changes since v1:
* Increase sleep time in msleep instead of using usleep_range
* Change subject and commit message accordingly
drivers/iio/frequency/ad9523.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 7c5245d..50ed8d1 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -445,7 +445,7 @@ static int ad9523_store_eeprom(struct iio_dev *indio_dev)
tmp = 4;
do {
- msleep(16);
+ msleep(20);
ret = ad9523_read(indio_dev,
AD9523_EEPROM_DATA_XFER_STATUS);
if (ret < 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom
2014-12-30 18:44 [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom Roberta Dobrescu
@ 2015-01-01 12:19 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-01-01 12:19 UTC (permalink / raw)
To: Roberta Dobrescu, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw
On 30/12/14 18:44, Roberta Dobrescu wrote:
> This patch increases sleep time in ad9523_store_eeprom to 20ms since
> it isn't timing critical. It fixes the following checkpatch.pl warning:
> WARNING: msleep < 20ms can sleep for up to 20ms
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play.
> ---
> Changes since v1:
> * Increase sleep time in msleep instead of using usleep_range
> * Change subject and commit message accordingly
>
> drivers/iio/frequency/ad9523.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
> index 7c5245d..50ed8d1 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -445,7 +445,7 @@ static int ad9523_store_eeprom(struct iio_dev *indio_dev)
>
> tmp = 4;
> do {
> - msleep(16);
> + msleep(20);
> ret = ad9523_read(indio_dev,
> AD9523_EEPROM_DATA_XFER_STATUS);
> if (ret < 0)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-01 12:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-30 18:44 [PATCH v2] iio: frequency: ad9523: Increase sleep time in ad9523_store_eeprom Roberta Dobrescu
2015-01-01 12:19 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).