* [PATCH 0/2] iio: amplifiers: Fix checkpatch.pl warnings
@ 2014-12-30 18:45 Roberta Dobrescu
2014-12-30 18:45 ` [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ',' Roberta Dobrescu
2014-12-30 18:45 ` [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification Roberta Dobrescu
0 siblings, 2 replies; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:45 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patchset fixes warnings detected using checkpatch.pl,
such as: prohibited space before ',' and wrong order for type specification.
Roberta Dobrescu (2):
iio: amplifiers: ad8366: Remove space before ','
iio: amplifiers: ad8366: Use right order for type specification
drivers/iio/amplifiers/ad8366.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ','
2014-12-30 18:45 [PATCH 0/2] iio: amplifiers: Fix checkpatch.pl warnings Roberta Dobrescu
@ 2014-12-30 18:45 ` Roberta Dobrescu
2015-01-01 12:16 ` Jonathan Cameron
2014-12-30 18:45 ` [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification Roberta Dobrescu
1 sibling, 1 reply; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:45 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patch fixes the following checkpatch.pl error:
ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
drivers/iio/amplifiers/ad8366.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
index ba6f6a9..fce25a0 100644
--- a/drivers/iio/amplifiers/ad8366.c
+++ b/drivers/iio/amplifiers/ad8366.c
@@ -166,7 +166,7 @@ static int ad8366_probe(struct spi_device *spi)
if (ret)
goto error_disable_reg;
- ad8366_write(indio_dev, 0 , 0);
+ ad8366_write(indio_dev, 0, 0);
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ','
2014-12-30 18:45 ` [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ',' Roberta Dobrescu
@ 2015-01-01 12:16 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2015-01-01 12:16 UTC (permalink / raw)
To: Roberta Dobrescu, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw
On 30/12/14 18:45, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl error:
> ERROR: space prohibited before that ',' (ctx:WxW)
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied
> ---
> drivers/iio/amplifiers/ad8366.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
> index ba6f6a9..fce25a0 100644
> --- a/drivers/iio/amplifiers/ad8366.c
> +++ b/drivers/iio/amplifiers/ad8366.c
> @@ -166,7 +166,7 @@ static int ad8366_probe(struct spi_device *spi)
> if (ret)
> goto error_disable_reg;
>
> - ad8366_write(indio_dev, 0 , 0);
> + ad8366_write(indio_dev, 0, 0);
>
> return 0;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification
2014-12-30 18:45 [PATCH 0/2] iio: amplifiers: Fix checkpatch.pl warnings Roberta Dobrescu
2014-12-30 18:45 ` [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ',' Roberta Dobrescu
@ 2014-12-30 18:45 ` Roberta Dobrescu
2015-01-01 12:17 ` Jonathan Cameron
1 sibling, 1 reply; 5+ messages in thread
From: Roberta Dobrescu @ 2014-12-30 18:45 UTC (permalink / raw)
To: jic23, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw, Roberta Dobrescu
This patch fixes the following checkpatch.pl warning:
WARNING: type 'char unsigned' should be specified in [[un]signed]
[short|int|long|long long] order
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
drivers/iio/amplifiers/ad8366.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
index fce25a0..c0d364e 100644
--- a/drivers/iio/amplifiers/ad8366.c
+++ b/drivers/iio/amplifiers/ad8366.c
@@ -31,7 +31,7 @@ struct ad8366_state {
};
static int ad8366_write(struct iio_dev *indio_dev,
- unsigned char ch_a, char unsigned ch_b)
+ unsigned char ch_a, unsigned char ch_b)
{
struct ad8366_state *st = iio_priv(indio_dev);
int ret;
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification
2014-12-30 18:45 ` [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification Roberta Dobrescu
@ 2015-01-01 12:17 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2015-01-01 12:17 UTC (permalink / raw)
To: Roberta Dobrescu, linux-iio
Cc: octavian.purdila, daniel.baluta, lars, Michael.Hennerich,
knaack.h, pmeerw
On 30/12/14 18:45, Roberta Dobrescu wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: type 'char unsigned' should be specified in [[un]signed]
> [short|int|long|long long] order
>
> Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
Applied.
> ---
> drivers/iio/amplifiers/ad8366.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
> index fce25a0..c0d364e 100644
> --- a/drivers/iio/amplifiers/ad8366.c
> +++ b/drivers/iio/amplifiers/ad8366.c
> @@ -31,7 +31,7 @@ struct ad8366_state {
> };
>
> static int ad8366_write(struct iio_dev *indio_dev,
> - unsigned char ch_a, char unsigned ch_b)
> + unsigned char ch_a, unsigned char ch_b)
> {
> struct ad8366_state *st = iio_priv(indio_dev);
> int ret;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-01 12:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-30 18:45 [PATCH 0/2] iio: amplifiers: Fix checkpatch.pl warnings Roberta Dobrescu
2014-12-30 18:45 ` [PATCH 1/2] iio: amplifiers: ad8366: Remove space before ',' Roberta Dobrescu
2015-01-01 12:16 ` Jonathan Cameron
2014-12-30 18:45 ` [PATCH 2/2] iio: amplifiers: ad8366: Use right order for type specification Roberta Dobrescu
2015-01-01 12:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).