From: "Kristina Martšenko" <kristina.martsenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
"Marek Vasut" <marex@denx.de>,
"Juergen Beisert" <jbe@pengutronix.de>,
"Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
"Kristina Martšenko" <kristina.martsenko@gmail.com>
Subject: [PATCH 4/4] iio: mxs-lradc: only update the buffer when its conversions have finished
Date: Sat, 17 Jan 2015 02:22:11 +0200 [thread overview]
Message-ID: <1421454131-3501-5-git-send-email-kristina.martsenko@gmail.com> (raw)
In-Reply-To: <1421454131-3501-1-git-send-email-kristina.martsenko@gmail.com>
Using the touchscreen while running buffered capture results in the
buffer reporting lots of wrong values, often just zeros. This is because
we push readings to the buffer every time a touchscreen interrupt
arrives, including when the buffer's own conversions have not yet
finished. So let's only push to the buffer when its conversions are
ready.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
---
drivers/staging/iio/adc/mxs-lradc.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
index 5b5cb205b9ed..d60ca849175e 100644
--- a/drivers/staging/iio/adc/mxs-lradc.c
+++ b/drivers/staging/iio/adc/mxs-lradc.c
@@ -1153,10 +1153,12 @@ static irqreturn_t mxs_lradc_handle_irq(int irq, void *data)
LRADC_CTRL1_LRADC_IRQ(TS_VCH2));
}
- if (iio_buffer_enabled(iio))
- iio_trigger_poll(iio->trig);
- else if (reg & LRADC_CTRL1_LRADC_IRQ(0))
+ if (iio_buffer_enabled(iio)) {
+ if (reg & lradc->buffer_vchans)
+ iio_trigger_poll(iio->trig);
+ } else if (reg & LRADC_CTRL1_LRADC_IRQ(0)) {
complete(&lradc->completion);
+ }
mxs_lradc_reg_clear(lradc, reg & clr_irq, LRADC_CTRL1);
--
2.2.0
next prev parent reply other threads:[~2015-01-17 0:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 0:22 [PATCH 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC Kristina Martšenko
2015-01-17 0:22 ` [PATCH 1/4] iio: mxs-lradc: separate touchscreen and buffer virtual channels Kristina Martšenko
2015-01-18 0:19 ` Marek Vasut
2015-01-19 19:02 ` Kristina Martšenko
2015-01-20 1:29 ` Marek Vasut
2015-01-17 0:22 ` [PATCH 2/4] iio: mxs-lradc: make ADC reads not disable touchscreen interrupts Kristina Martšenko
2015-01-18 0:21 ` Marek Vasut
2015-01-19 19:03 ` Kristina Martšenko
2015-01-17 0:22 ` [PATCH 3/4] iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions Kristina Martšenko
2015-01-18 0:22 ` Marek Vasut
2015-01-19 7:20 ` Juergen Borleis
2015-01-19 7:57 ` Marek Vasut
2015-01-19 20:03 ` Kristina Martšenko
2015-01-17 0:22 ` Kristina Martšenko [this message]
2015-01-18 0:23 ` [PATCH 4/4] iio: mxs-lradc: only update the buffer when its conversions have finished Marek Vasut
2015-01-18 11:21 ` [PATCH 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC Stefan Wahren
2015-01-19 20:30 ` Kristina Martšenko
2015-01-20 1:32 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421454131-3501-5-git-send-email-kristina.martsenko@gmail.com \
--to=kristina.martsenko@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbe@pengutronix.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).