From: "Kristina Martšenko" <kristina.martsenko@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Hartmut Knaack" <knaack.h@gmx.de>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Peter Meerwald" <pmeerw@pmeerw.net>,
"Marek Vasut" <marex@denx.de>,
"Juergen Beisert" <jbe@pengutronix.de>,
"Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
"Fabio Estevam" <fabio.estevam@freescale.com>,
"Stefan Wahren" <stefan.wahren@i2se.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
"Kristina Martšenko" <kristina.martsenko@gmail.com>
Subject: [PATCH v2 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC
Date: Sun, 25 Jan 2015 18:28:18 +0200 [thread overview]
Message-ID: <1422203302-17090-1-git-send-email-kristina.martsenko@gmail.com> (raw)
These patches fix some issues with using the touchscreen and reading
other ADC channels at the same time.
The main issue is that the "virtual" channels the touchscreen uses can
overlap with the channels that the iio buffer is configured to read,
causing the touchscreen to read those channels instead, and report wrong
values. Patch #1 fixes that by separating the channels they use.
Patches #2 and #3 stop buffered mode and sysfs reads from disabling the
touchscreen. Patch #4 keeps the buffer from reporting wrong values when
the touchscreen is in use.
Note that I've only tested these patches on i.MX28. I checked the i.MX23
reference manual, and there don't seem to be any differences in the
parts I changed, but it would still be nice if someone could test on
i.MX23 as well.
Changes in v2:
- renamed TS_VCHn macros to TOUCHSCREEN_VCHANNELn
- removed indentation changes from patch #2
Kristina Martšenko (4):
iio: mxs-lradc: separate touchscreen and buffer virtual channels
iio: mxs-lradc: make ADC reads not disable touchscreen interrupts
iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions
iio: mxs-lradc: only update the buffer when its conversions have
finished
drivers/staging/iio/adc/mxs-lradc.c | 200 ++++++++++++++++++------------------
1 file changed, 98 insertions(+), 102 deletions(-)
--
2.2.0
next reply other threads:[~2015-01-25 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 16:28 Kristina Martšenko [this message]
2015-01-25 16:28 ` [PATCH v2 1/4] iio: mxs-lradc: separate touchscreen and buffer virtual channels Kristina Martšenko
2015-01-25 16:28 ` [PATCH v2 2/4] iio: mxs-lradc: make ADC reads not disable touchscreen interrupts Kristina Martšenko
2015-01-25 16:28 ` [PATCH v2 3/4] iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions Kristina Martšenko
2015-01-25 16:28 ` [PATCH v2 4/4] iio: mxs-lradc: only update the buffer when its conversions have finished Kristina Martšenko
2015-01-25 18:47 ` [PATCH v2 0/4] iio: mxs-lradc: fix interactions between the touchscreen and the ADC Marek Vasut
2015-01-26 21:01 ` Jonathan Cameron
2015-01-27 14:19 ` Kristina Martšenko
2015-01-27 17:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422203302-17090-1-git-send-email-kristina.martsenko@gmail.com \
--to=kristina.martsenko@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=jbe@pengutronix.de \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).