* [PATCH] iio: ti-adc128s052: Add DT binding documentation
@ 2014-12-17 17:59 Angelo Compagnucci
2014-12-18 16:18 ` Lars-Peter Clausen
2014-12-19 21:53 ` Hartmut Knaack
0 siblings, 2 replies; 10+ messages in thread
From: Angelo Compagnucci @ 2014-12-17 17:59 UTC (permalink / raw)
To: linux-iio; +Cc: Angelo Compagnucci
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
.../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
new file mode 100644
index 0000000..12132ef
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
@@ -0,0 +1,18 @@
+* Texas Instruments' ADC128S052 ADC chip
+
+Required properties:
+ - compatible: Should be "ti,adc128s052"
+ - reg: spi chip select number for the device
+ - vref-supply: The regulator supply ADC reference voltage.
+
+Recommended properties:
+- spi-max-frequency: Definition as per
+ Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+adc@0 {
+ compatible = "ti,adc128s052";
+ reg = <0>;
+ vref-supply = <&vdd_supply>;
+ spi-max-frequency = <1000000>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2014-12-17 17:59 Angelo Compagnucci
@ 2014-12-18 16:18 ` Lars-Peter Clausen
2014-12-18 16:42 ` Angelo Compagnucci
2014-12-19 21:53 ` Hartmut Knaack
1 sibling, 1 reply; 10+ messages in thread
From: Lars-Peter Clausen @ 2014-12-18 16:18 UTC (permalink / raw)
To: Angelo Compagnucci, linux-iio
On 12/17/2014 06:59 PM, Angelo Compagnucci wrote:
> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Looks good to me, but you might want to send this to the devicetree list and
the devicetree bindings maintainers.
[...]
> +Example:
> +adc@0 {
> + compatible = "ti,adc128s052";
> + reg = <0>;
> + vref-supply = <&vdd_supply>;
strange indention here
> + spi-max-frequency = <1000000>;
> +};
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2014-12-18 16:18 ` Lars-Peter Clausen
@ 2014-12-18 16:42 ` Angelo Compagnucci
2014-12-26 11:55 ` Jonathan Cameron
0 siblings, 1 reply; 10+ messages in thread
From: Angelo Compagnucci @ 2014-12-18 16:42 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
Hi Lars-Peter,
2014-12-18 17:18 GMT+01:00 Lars-Peter Clausen <lars@metafoo.de>:
> On 12/17/2014 06:59 PM, Angelo Compagnucci wrote:
>>
>> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
>>
>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
>
> Looks good to me, but you might want to send this to the devicetree list and
> the devicetree bindings maintainers.
Ouch! Resending to the right ml, thank you for your support!
>
> [...]
>>
>> +Example:
>> +adc@0 {
>> + compatible = "ti,adc128s052";
>> + reg = <0>;
>> + vref-supply = <&vdd_supply>;
>
>
> strange indention here
>
>
>> + spi-max-frequency = <1000000>;
>> +};
>>
>
--
Profile: http://it.linkedin.com/in/compagnucciangelo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2014-12-17 17:59 Angelo Compagnucci
2014-12-18 16:18 ` Lars-Peter Clausen
@ 2014-12-19 21:53 ` Hartmut Knaack
1 sibling, 0 replies; 10+ messages in thread
From: Hartmut Knaack @ 2014-12-19 21:53 UTC (permalink / raw)
To: Angelo Compagnucci, linux-iio
Angelo Compagnucci schrieb am 17.12.2014 um 18:59:
> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Hi,
some thoughts inline.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
> .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> new file mode 100644
> index 0000000..12132ef
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -0,0 +1,18 @@
> +* Texas Instruments' ADC128S052 ADC chip
> +
> +Required properties:
> + - compatible: Should be "ti,adc128s052"
> + - reg: spi chip select number for the device
Use upper case for SPI?
> + - vref-supply: The regulator supply ADC reference voltage.
Maybe: The regulator supplying ADC reference voltage.
> +
> +Recommended properties:
> +- spi-max-frequency: Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +adc@0 {
> + compatible = "ti,adc128s052";
> + reg = <0>;
> + vref-supply = <&vdd_supply>;
> + spi-max-frequency = <1000000>;
> +};
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2014-12-18 16:42 ` Angelo Compagnucci
@ 2014-12-26 11:55 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2014-12-26 11:55 UTC (permalink / raw)
To: Angelo Compagnucci, Lars-Peter Clausen; +Cc: linux-iio
On 18/12/14 16:42, Angelo Compagnucci wrote:
> Hi Lars-Peter,
>
> 2014-12-18 17:18 GMT+01:00 Lars-Peter Clausen <lars@metafoo.de>:
>> On 12/17/2014 06:59 PM, Angelo Compagnucci wrote:
>>>
>>> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
>>>
>>> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>>
>>
>> Looks good to me, but you might want to send this to the devicetree list and
>> the devicetree bindings maintainers.
>
> Ouch! Resending to the right ml, thank you for your support!
Do keep linux-iio in the loop as well as it'll probably go
through my tree ultimately and I don't read the device-tree list
directly :) Nature of these patches is that they want to go
to the maintainers, reviewers and lists for both iio and devicetree.
Jonathan
>
>>
>> [...]
>>>
>>> +Example:
>>> +adc@0 {
>>> + compatible = "ti,adc128s052";
>>> + reg = <0>;
>>> + vref-supply = <&vdd_supply>;
>>
>>
>> strange indention here
>>
>>
>>> + spi-max-frequency = <1000000>;
>>> +};
>>>
>>
>
>
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] iio: ti-adc128s052: Add DT binding documentation
@ 2015-02-16 11:21 Angelo Compagnucci
2015-03-08 12:36 ` Jonathan Cameron
0 siblings, 1 reply; 10+ messages in thread
From: Angelo Compagnucci @ 2015-02-16 11:21 UTC (permalink / raw)
To: devicetree; +Cc: linux-iio, Angelo Compagnucci
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
---
.../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
new file mode 100644
index 0000000..c8d682b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
@@ -0,0 +1,18 @@
+* Texas Instruments' ADC128S052 ADC chip
+
+Required properties:
+ - compatible: Should be "ti,adc128s052"
+ - reg: spi chip select number for the device
+ - vref-supply: The regulator supply for ADC reference voltage
+
+Recommended properties:
+ - spi-max-frequency: Definition as per
+ Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+adc@0 {
+ compatible = "ti,adc128s052";
+ reg = <0>;
+ vref-supply = <&vdd_supply>;
+ spi-max-frequency = <1000000>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2015-02-16 11:21 Angelo Compagnucci
@ 2015-03-08 12:36 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2015-03-08 12:36 UTC (permalink / raw)
To: Angelo Compagnucci, devicetree; +Cc: linux-iio
On 16/02/15 11:21, Angelo Compagnucci wrote:
> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Patch is fine, but missing a signed-off-by line.
> ---
> .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> new file mode 100644
> index 0000000..c8d682b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -0,0 +1,18 @@
> +* Texas Instruments' ADC128S052 ADC chip
> +
> +Required properties:
> + - compatible: Should be "ti,adc128s052"
> + - reg: spi chip select number for the device
> + - vref-supply: The regulator supply for ADC reference voltage
> +
> +Recommended properties:
> + - spi-max-frequency: Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +adc@0 {
> + compatible = "ti,adc128s052";
> + reg = <0>;
> + vref-supply = <&vdd_supply>;
> + spi-max-frequency = <1000000>;
> +};
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] iio: ti-adc128s052: Add DT binding documentation
@ 2015-03-08 13:36 Angelo Compagnucci
2015-03-09 11:03 ` Jonathan Cameron
0 siblings, 1 reply; 10+ messages in thread
From: Angelo Compagnucci @ 2015-03-08 13:36 UTC (permalink / raw)
To: linux-iio; +Cc: devicetree, Angelo Compagnucci
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
.../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
new file mode 100644
index 0000000..c8d682b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
@@ -0,0 +1,18 @@
+* Texas Instruments' ADC128S052 ADC chip
+
+Required properties:
+ - compatible: Should be "ti,adc128s052"
+ - reg: spi chip select number for the device
+ - vref-supply: The regulator supply for ADC reference voltage
+
+Recommended properties:
+ - spi-max-frequency: Definition as per
+ Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+adc@0 {
+ compatible = "ti,adc128s052";
+ reg = <0>;
+ vref-supply = <&vdd_supply>;
+ spi-max-frequency = <1000000>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] iio: ti-adc128s052: Add DT binding documentation
@ 2015-03-08 14:32 Angelo Compagnucci
0 siblings, 0 replies; 10+ messages in thread
From: Angelo Compagnucci @ 2015-03-08 14:32 UTC (permalink / raw)
To: linux-iio; +Cc: devicetree, Angelo Compagnucci
Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
---
Changelog:
* Added signed-off
.../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
new file mode 100644
index 0000000..c8d682b
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
@@ -0,0 +1,18 @@
+* Texas Instruments' ADC128S052 ADC chip
+
+Required properties:
+ - compatible: Should be "ti,adc128s052"
+ - reg: spi chip select number for the device
+ - vref-supply: The regulator supply for ADC reference voltage
+
+Recommended properties:
+ - spi-max-frequency: Definition as per
+ Documentation/devicetree/bindings/spi/spi-bus.txt
+
+Example:
+adc@0 {
+ compatible = "ti,adc128s052";
+ reg = <0>;
+ vref-supply = <&vdd_supply>;
+ spi-max-frequency = <1000000>;
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] iio: ti-adc128s052: Add DT binding documentation
2015-03-08 13:36 Angelo Compagnucci
@ 2015-03-09 11:03 ` Jonathan Cameron
0 siblings, 0 replies; 10+ messages in thread
From: Jonathan Cameron @ 2015-03-09 11:03 UTC (permalink / raw)
To: Angelo Compagnucci, linux-iio; +Cc: devicetree
On 08/03/15 13:36, Angelo Compagnucci wrote:
> Adding binding documentation for Texas Instruments' ADC128S052 ADC chip.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Applied to the togreg branch of iio.git.
Thanks
Jonathan
> ---
> .../devicetree/bindings/iio/adc/ti-adc128s052.txt | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> new file mode 100644
> index 0000000..c8d682b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti-adc128s052.txt
> @@ -0,0 +1,18 @@
> +* Texas Instruments' ADC128S052 ADC chip
> +
> +Required properties:
> + - compatible: Should be "ti,adc128s052"
> + - reg: spi chip select number for the device
> + - vref-supply: The regulator supply for ADC reference voltage
> +
> +Recommended properties:
> + - spi-max-frequency: Definition as per
> + Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +adc@0 {
> + compatible = "ti,adc128s052";
> + reg = <0>;
> + vref-supply = <&vdd_supply>;
> + spi-max-frequency = <1000000>;
> +};
>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-03-09 11:03 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-08 14:32 [PATCH] iio: ti-adc128s052: Add DT binding documentation Angelo Compagnucci
-- strict thread matches above, loose matches on Subject: below --
2015-03-08 13:36 Angelo Compagnucci
2015-03-09 11:03 ` Jonathan Cameron
2015-02-16 11:21 Angelo Compagnucci
2015-03-08 12:36 ` Jonathan Cameron
2014-12-17 17:59 Angelo Compagnucci
2014-12-18 16:18 ` Lars-Peter Clausen
2014-12-18 16:42 ` Angelo Compagnucci
2014-12-26 11:55 ` Jonathan Cameron
2014-12-19 21:53 ` Hartmut Knaack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).