Re: [PATCH v2 12/17] iio: accel: mma9553: fix gpio bitnum init value

Jonathan Cameron
2015-04-26T18:53:13Z

On 13/04/15 16:40, Irina Tirdea wrote:
> Initial value of gpio bitnum is set to -1, but
> the variable is declared as unsigned.
>
> Use a positive invalid value for initial gpio
> bitnum.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
Applied. I thought about adding this to the fixes-togreg
branch but got lazy and added it to the togreg one instead.

J
> ---
> drivers/iio/accel/mma9553.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index 9573147..5755977 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -78,6 +78,7 @@
>
> /* Bitnum used for GPIO configuration = bit number in high status byte */
> #define MMA9553_STATUS_TO_BITNUM(bit) (ffs(bit) - 9)
> +#define MMA9553_MAX_BITNUM MMA9553_STATUS_TO_BITNUM(BIT(16))
>
> #define MMA9553_DEFAULT_SAMPLE_RATE 30 /* Hz */
>
> @@ -404,8 +405,8 @@ static int mma9553_init(struct mma9553_data *data)
> }
>
>
> - data->gpio_bitnum = -1;
> /* Reset GPIO */
> + data->gpio_bitnum = MMA9553_MAX_BITNUM;
> ret = mma9553_conf_gpio(data);
> if (ret < 0)
> return ret;
>