Re: [PATCH v2 07/17] iio: accel: mma9553: check for error in reading initial activity and stepcnt

Jonathan Cameron
2015-04-26T18:47:20Z

On 13/04/15 16:40, Irina Tirdea wrote:
> When configuring gpio, we need to read initial values for activity and
> step count. This function may fail due to i2c read errors.
>
> Check the error code returned by mma9553_read_activity_stepcnt
> and return the appropriate error in gpio config function.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Reported-by: Hartmut Knaack <knaack.h@gmx.de>
applied, togreg....
> ---
> drivers/iio/accel/mma9553.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index 365a109..6f0a14b 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -363,9 +363,12 @@ static int mma9553_conf_gpio(struct mma9553_data *data)
> return 0;
>
> /* Save initial values for activity and stepcnt */
> - if (activity_enabled || ev_step_detect->enabled)
> - mma9553_read_activity_stepcnt(data, &data->activity,
> - &data->stepcnt);
> + if (activity_enabled || ev_step_detect->enabled) {
> + ret = mma9553_read_activity_stepcnt(data, &data->activity,
> + &data->stepcnt);
> + if (ret < 0)
> + return ret;
> + }
>
> ret = mma9551_gpio_config(data->client,
> MMA9553_DEFAULT_GPIO_PIN,
>