Re: [PATCH v2 10/17] iio: accel: mma9553: use GENMASK

Jonathan Cameron
2015-04-26T18:49:15Z

On 13/04/15 16:40, Irina Tirdea wrote:
> Use GENMASK instead of BIT or direct value to
> define a mask.
>
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> Suggested-by: Hartmut Knaack <knaack.h@gmx.de>
Applied.
> ---
> drivers/iio/accel/mma9553.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/accel/mma9553.c b/drivers/iio/accel/mma9553.c
> index a6b74de..47cb14b 100644
> --- a/drivers/iio/accel/mma9553.c
> +++ b/drivers/iio/accel/mma9553.c
> @@ -63,8 +63,8 @@
> #define MMA9553_MASK_STATUS_STEPCHG BIT(13)
> #define MMA9553_MASK_STATUS_ACTCHG BIT(12)
> #define MMA9553_MASK_STATUS_SUSP BIT(11)
> -#define MMA9553_MASK_STATUS_ACTIVITY (BIT(10) | BIT(9) | BIT(8))
> -#define MMA9553_MASK_STATUS_VERSION 0x00FF
> +#define MMA9553_MASK_STATUS_ACTIVITY GENMASK(10, 8)
> +#define MMA9553_MASK_STATUS_VERSION GENMASK(7, 0)
>
> #define MMA9553_REG_STEPCNT 0x02
> #define MMA9553_REG_DISTANCE 0x04
>