From: Roberta Dobrescu <roberta.dobrescu@gmail.com>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, daniel.baluta@intel.com,
Roberta Dobrescu <roberta.dobrescu@gmail.com>
Subject: [PATCH v2 2/3] staging: iio: light: isl29018: Rename lux_scale to calibscale
Date: Thu, 16 Apr 2015 22:20:58 +0300 [thread overview]
Message-ID: <1429212059-13010-3-git-send-email-roberta.dobrescu@gmail.com> (raw)
In-Reply-To: <1429212059-13010-1-git-send-email-roberta.dobrescu@gmail.com>
This patch renames lux_scale to calibscale and lux_uscale to
ucalibscale.
This is done in order to avoid confusion since these parameters are
used for hardware applied calibration.
Signed-off-by: Roberta Dobrescu <roberta.dobrescu@gmail.com>
---
drivers/staging/iio/light/isl29018.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
index d3d0611..ffc3d1b 100644
--- a/drivers/staging/iio/light/isl29018.c
+++ b/drivers/staging/iio/light/isl29018.c
@@ -71,8 +71,8 @@ struct isl29018_chip {
struct regmap *regmap;
struct mutex lock;
int type;
- unsigned int lux_scale;
- unsigned int lux_uscale;
+ unsigned int calibscale;
+ unsigned int ucalibscale;
unsigned int range;
unsigned int adc_bit;
int prox_scheme;
@@ -165,12 +165,12 @@ static int isl29018_read_lux(struct isl29018_chip *chip, int *lux)
/* To support fractional scaling, separate the unshifted lux
* into two calculations: int scaling and micro-scaling.
- * lux_uscale ranges from 0-999999, so about 20 bits. Split
+ * ucalibscale ranges from 0-999999, so about 20 bits. Split
* the /1,000,000 in two to reduce the risk of over/underflow.
*/
data_x_range = lux_data * chip->range;
- lux_unshifted = data_x_range * chip->lux_scale;
- lux_unshifted += data_x_range / 1000 * chip->lux_uscale / 1000;
+ lux_unshifted = data_x_range * chip->calibscale;
+ lux_unshifted += data_x_range / 1000 * chip->ucalibscale / 1000;
*lux = lux_unshifted >> chip->adc_bit;
return 0;
@@ -277,9 +277,9 @@ static int isl29018_write_raw(struct iio_dev *indio_dev,
mutex_lock(&chip->lock);
if (mask == IIO_CHAN_INFO_CALIBSCALE && chan->type == IIO_LIGHT) {
- chip->lux_scale = val;
+ chip->calibscale = val;
/* With no write_raw_get_fmt(), val2 is a MICRO fraction. */
- chip->lux_uscale = val2;
+ chip->ucalibscale = val2;
ret = 0;
}
mutex_unlock(&chip->lock);
@@ -323,8 +323,8 @@ static int isl29018_read_raw(struct iio_dev *indio_dev,
break;
case IIO_CHAN_INFO_CALIBSCALE:
if (chan->type == IIO_LIGHT) {
- *val = chip->lux_scale;
- *val2 = chip->lux_uscale;
+ *val = chip->calibscale;
+ *val2 = chip->ucalibscale;
ret = IIO_VAL_INT_PLUS_MICRO;
}
break;
@@ -607,8 +607,8 @@ static int isl29018_probe(struct i2c_client *client,
mutex_init(&chip->lock);
chip->type = dev_id;
- chip->lux_scale = 1;
- chip->lux_uscale = 0;
+ chip->calibscale = 1;
+ chip->ucalibscale = 0;
chip->range = 1000;
chip->adc_bit = 16;
chip->suspended = false;
--
1.9.1
next prev parent reply other threads:[~2015-04-16 19:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 19:20 [PATCH v2 0/3] staging: iio: light: isl29018: Remove non-standard sysfs attributes Roberta Dobrescu
2015-04-16 19:20 ` [PATCH v2 1/3] " Roberta Dobrescu
2015-04-26 19:46 ` Jonathan Cameron
2015-04-16 19:20 ` Roberta Dobrescu [this message]
2015-04-26 19:46 ` [PATCH v2 2/3] staging: iio: light: isl29018: Rename lux_scale to calibscale Jonathan Cameron
2015-04-16 19:20 ` [PATCH v2 3/3] staging: iio: light: isl29018: Use standard sysfs attributes for scale and integration time Roberta Dobrescu
2015-04-26 19:51 ` Jonathan Cameron
2015-04-27 16:03 ` Rhyland Klein
2015-05-02 11:02 ` Jonathan Cameron
2015-05-02 15:55 ` Roberta Dobrescu
2015-06-27 9:34 ` Hartmut Knaack
2015-06-29 7:24 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429212059-13010-3-git-send-email-roberta.dobrescu@gmail.com \
--to=roberta.dobrescu@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox