From: Irina Tirdea <irina.tirdea@intel.com>
To: Wolfram Sang <wsa@the-dreams.de>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@intel.com>,
Peter Meerwald <pmeerw@pmeerw.net>,
Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v3 5/8] iio: gyro: bmg160: use available_scan_masks
Date: Fri, 3 Jul 2015 12:33:34 +0300 [thread overview]
Message-ID: <1435916017-12859-6-git-send-email-irina.tirdea@intel.com> (raw)
In-Reply-To: <1435916017-12859-1-git-send-email-irina.tirdea@intel.com>
Use available_scan_masks to allow the iio core to select
the data to send to userspace depending on which axes are
enabled, instead of doing this in the driver's interrupt
handler.
Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
---
drivers/iio/gyro/bmg160.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/gyro/bmg160.c b/drivers/iio/gyro/bmg160.c
index 4415f55..4b423f2 100644
--- a/drivers/iio/gyro/bmg160.c
+++ b/drivers/iio/gyro/bmg160.c
@@ -115,6 +115,7 @@ enum bmg160_axis {
AXIS_X,
AXIS_Y,
AXIS_Z,
+ AXIS_MAX,
};
static const struct {
@@ -814,6 +815,8 @@ static const struct iio_info bmg160_info = {
.driver_module = THIS_MODULE,
};
+static const unsigned long bmg160_scan_masks[] = {0x7, 0};
+
static irqreturn_t bmg160_trigger_handler(int irq, void *p)
{
struct iio_poll_func *pf = p;
@@ -822,8 +825,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
int bit, ret, i = 0;
mutex_lock(&data->mutex);
- for_each_set_bit(bit, indio_dev->active_scan_mask,
- indio_dev->masklength) {
+ for (bit = 0; bit < AXIS_MAX; bit++) {
ret = i2c_smbus_read_word_data(data->client,
BMG160_AXIS_TO_REG(bit));
if (ret < 0) {
@@ -1056,6 +1058,7 @@ static int bmg160_probe(struct i2c_client *client,
indio_dev->dev.parent = &client->dev;
indio_dev->channels = bmg160_channels;
indio_dev->num_channels = ARRAY_SIZE(bmg160_channels);
+ indio_dev->available_scan_masks = bmg160_scan_masks;
indio_dev->name = name;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->info = &bmg160_info;
--
1.9.1
next prev parent reply other threads:[~2015-07-03 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 9:33 [PATCH v3 0/8] Add support for best effort block read emulation Irina Tirdea
2015-07-03 9:33 ` [PATCH v3 1/8] i2c: core: " Irina Tirdea
2015-07-05 11:58 ` Jonathan Cameron
2015-07-10 17:14 ` Tirdea, Irina
2015-07-11 17:40 ` Jonathan Cameron
2015-08-01 19:53 ` Wolfram Sang
2015-08-04 13:51 ` Tirdea, Irina
2015-07-03 9:33 ` [PATCH v3 2/8] eeprom: at24: use i2c_smbus_read_i2c_block_data_or_emulated Irina Tirdea
2015-08-01 19:57 ` Wolfram Sang
2015-08-04 13:52 ` Tirdea, Irina
2015-07-03 9:33 ` [PATCH v3 3/8] iio: accel: bmc150: use available_scan_masks Irina Tirdea
2015-07-05 12:10 ` Jonathan Cameron
2015-07-03 9:33 ` [PATCH v3 4/8] iio: accel: bmc150: optimize i2c transfers in trigger handler Irina Tirdea
2015-07-05 12:06 ` Jonathan Cameron
2015-07-03 9:33 ` Irina Tirdea [this message]
2015-07-03 9:33 ` [PATCH v3 6/8] iio: gyro: bmg160: " Irina Tirdea
2015-07-05 12:08 ` Jonathan Cameron
2015-07-10 17:31 ` Tirdea, Irina
2015-07-10 17:46 ` Pandruvada, Srinivas
2015-07-03 9:33 ` [PATCH v3 7/8] iio: accel: kxcjk-1013: use available_scan_masks Irina Tirdea
2015-07-05 12:10 ` Jonathan Cameron
2015-07-03 9:33 ` [PATCH v3 8/8] iio: accel: kxcjk-1013: optimize i2c transfers in trigger handler Irina Tirdea
2015-07-05 12:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435916017-12859-6-git-send-email-irina.tirdea@intel.com \
--to=irina.tirdea@intel.com \
--cc=jic23@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).