From: Daniel Baluta <daniel.baluta@intel.com>
To: jic23@kernel.org
Cc: daniel.baluta@intel.com, viorel.suman@intel.com, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] iio: magnetometer: mmc35240: fix SET/RESET sequence
Date: Tue, 14 Jul 2015 17:56:54 +0300 [thread overview]
Message-ID: <1436885814-29155-4-git-send-email-daniel.baluta@intel.com> (raw)
In-Reply-To: <1436885814-29155-1-git-send-email-daniel.baluta@intel.com>
From: Viorel Suman <viorel.suman@intel.com>
The RESET operation invoked in the last instance will align
in the natural way all 3 axis and the chip top view.
Signed-off-by: Viorel Suman <viorel.suman@intel.com>
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
drivers/iio/magnetometer/mmc35240.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
index f4d7495..a53efd2 100644
--- a/drivers/iio/magnetometer/mmc35240.c
+++ b/drivers/iio/magnetometer/mmc35240.c
@@ -215,14 +215,15 @@ static int mmc35240_init(struct mmc35240_data *data)
/*
* make sure we restore sensor characteristics, by doing
- * a RESET/SET sequence
+ * a SET/RESET sequence, the axis polarity being naturally
+ * aligned after RESET
*/
- ret = mmc35240_hw_set(data, false);
+ ret = mmc35240_hw_set(data, true);
if (ret < 0)
return ret;
usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
- ret = mmc35240_hw_set(data, true);
+ ret = mmc35240_hw_set(data, false);
if (ret < 0)
return ret;
--
1.9.1
next prev parent reply other threads:[~2015-07-14 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 14:56 [PATCH 0/3] MMC35240 magneto fixes Daniel Baluta
2015-07-14 14:56 ` [PATCH 1/3] iio: magnetometer: mmc35240: Fix crash in pm suspend Daniel Baluta
2015-07-19 10:49 ` Jonathan Cameron
2015-07-14 14:56 ` [PATCH 2/3] iio: magnetometer: mmc35240: Fix SET/RESET mask Daniel Baluta
2015-07-19 10:54 ` Jonathan Cameron
2015-07-14 14:56 ` Daniel Baluta [this message]
2015-07-14 20:04 ` [PATCH 3/3] iio: magnetometer: mmc35240: fix SET/RESET sequence Jonathan Cameron
2015-07-16 13:30 ` Daniel Baluta
2015-07-19 10:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436885814-29155-4-git-send-email-daniel.baluta@intel.com \
--to=daniel.baluta@intel.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=viorel.suman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).