[PATCH V3] iio: declare struct to fix warning

[PATCH V3] iio: declare struct to fix warning

[Pengyu Ma]

When compile iio related driver the following warning shown:

include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
declared inside parameter list
  int (*set_trigger_state)(struct iio_trigger *trig, bool state);

include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
declared inside parameter list
           struct iio_dev *indio_dev);

'struct iio_dev' and 'struct iio_trigger' was used before declaration,
forward declaration for these structs to fix warning.

Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
---
 include/linux/iio/trigger.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index fa76c79..1c9e028 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -18,6 +18,9 @@ struct iio_subirq {
 	bool enabled;
 };
 
+struct iio_dev;
+struct iio_trigger;
+
 /**
  * struct iio_trigger_ops - operations structure for an iio_trigger.
  * @owner:		used to monitor usage count of the trigger.
-- 
2.4.3

Re: [PATCH V3] iio: declare struct to fix warning

[Daniel Baluta]

On Tue, Aug 4, 2015 at 11:17 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
> When compile iio related driver the following warning shown:
>
> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
> declared inside parameter list
>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>
> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
> declared inside parameter list
>            struct iio_dev *indio_dev);
>
> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
> forward declaration for these structs to fix warning.
>
> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>

Acked-by: Daniel Baluta <daniel.baluta@intel.com>

> ---
>  include/linux/iio/trigger.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index fa76c79..1c9e028 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -18,6 +18,9 @@ struct iio_subirq {
>         bool enabled;
>  };
>
> +struct iio_dev;
> +struct iio_trigger;
> +
>  /**
>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>   * @owner:             used to monitor usage count of the trigger.
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH V3] iio: declare struct to fix warning

[Jonathan Cameron]

On 04/08/15 09:30, Daniel Baluta wrote:
> On Tue, Aug 4, 2015 at 11:17 AM, Pengyu Ma <pengyu.ma@windriver.com> wrote:
>> When compile iio related driver the following warning shown:
>>
>> include/linux/iio/trigger.h:35:34: warning: 'struct iio_trigger'
>> declared inside parameter list
>>   int (*set_trigger_state)(struct iio_trigger *trig, bool state);
>>
>> include/linux/iio/trigger.h:38:18: warning: 'struct iio_dev'
>> declared inside parameter list
>>            struct iio_dev *indio_dev);
>>
>> 'struct iio_dev' and 'struct iio_trigger' was used before declaration,
>> forward declaration for these structs to fix warning.
>>
>> Signed-off-by: Pengyu Ma <pengyu.ma@windriver.com>
> 
> Acked-by: Daniel Baluta <daniel.baluta@intel.com>
No need send a v4 just to add the acked-by inline. I'm happy to do that
as I apply.

Thanks,

Jonathan
> 
>> ---
>>  include/linux/iio/trigger.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
>> index fa76c79..1c9e028 100644
>> --- a/include/linux/iio/trigger.h
>> +++ b/include/linux/iio/trigger.h
>> @@ -18,6 +18,9 @@ struct iio_subirq {
>>         bool enabled;
>>  };
>>
>> +struct iio_dev;
>> +struct iio_trigger;
>> +
>>  /**
>>   * struct iio_trigger_ops - operations structure for an iio_trigger.
>>   * @owner:             used to monitor usage count of the trigger.
>> --
>> 2.4.3
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>