[PATCH] iio: event_monitor: report unsupported events

[PATCH] iio: event_monitor: report unsupported events

[Linus Walleij]

This makes the event monitor bail out with a helpful error
message if a device does not support events, as a related
fix to iio core now makes it return -ENODEV properly.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 tools/iio/iio_event_monitor.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
index cd3fd41b481d..d51eb04202e9 100644
--- a/tools/iio/iio_event_monitor.c
+++ b/tools/iio/iio_event_monitor.c
@@ -284,7 +284,11 @@ int main(int argc, char **argv)
 	ret = ioctl(fd, IIO_GET_EVENT_FD_IOCTL, &event_fd);
 	if (ret == -1 || event_fd == -1) {
 		ret = -errno;
-		fprintf(stderr, "Failed to retrieve event fd\n");
+		if (ret == -ENODEV)
+			fprintf(stderr,
+				"This device does not support events\n");
+		else
+			fprintf(stderr, "Failed to retrieve event fd\n");
 		if (close(fd) == -1)
 			perror("Failed to close character device file");
 
-- 
2.4.3

Re: [PATCH] iio: event_monitor: report unsupported events

[Hartmut Knaack]

Linus Walleij schrieb am 11.08.2015 um 14:34:
> This makes the event monitor bail out with a helpful error
> message if a device does not support events, as a related
> fix to iio core now makes it return -ENODEV properly.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Hartmut Knaack <knaack.h@gmx.de>
> ---
>  tools/iio/iio_event_monitor.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
> index cd3fd41b481d..d51eb04202e9 100644
> --- a/tools/iio/iio_event_monitor.c
> +++ b/tools/iio/iio_event_monitor.c
> @@ -284,7 +284,11 @@ int main(int argc, char **argv)
>  	ret = ioctl(fd, IIO_GET_EVENT_FD_IOCTL, &event_fd);
>  	if (ret == -1 || event_fd == -1) {
>  		ret = -errno;
> -		fprintf(stderr, "Failed to retrieve event fd\n");
> +		if (ret == -ENODEV)
> +			fprintf(stderr,
> +				"This device does not support events\n");
> +		else
> +			fprintf(stderr, "Failed to retrieve event fd\n");
>  		if (close(fd) == -1)
>  			perror("Failed to close character device file");
>  
> 

Re: [PATCH] iio: event_monitor: report unsupported events

[Jonathan Cameron]

On 11/08/15 19:46, Hartmut Knaack wrote:
> Linus Walleij schrieb am 11.08.2015 um 14:34:
>> This makes the event monitor bail out with a helpful error
>> message if a device does not support events, as a related
>> fix to iio core now makes it return -ENODEV properly.
>>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Hartmut Knaack <knaack.h@gmx.de>
Applied to the togreg branch of iio.git

Thanks,

Jonathan
>> ---
>>  tools/iio/iio_event_monitor.c | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tools/iio/iio_event_monitor.c b/tools/iio/iio_event_monitor.c
>> index cd3fd41b481d..d51eb04202e9 100644
>> --- a/tools/iio/iio_event_monitor.c
>> +++ b/tools/iio/iio_event_monitor.c
>> @@ -284,7 +284,11 @@ int main(int argc, char **argv)
>>  	ret = ioctl(fd, IIO_GET_EVENT_FD_IOCTL, &event_fd);
>>  	if (ret == -1 || event_fd == -1) {
>>  		ret = -errno;
>> -		fprintf(stderr, "Failed to retrieve event fd\n");
>> +		if (ret == -ENODEV)
>> +			fprintf(stderr,
>> +				"This device does not support events\n");
>> +		else
>> +			fprintf(stderr, "Failed to retrieve event fd\n");
>>  		if (close(fd) == -1)
>>  			perror("Failed to close character device file");
>>  
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>