From: Markus Pargmann <mpa@pengutronix.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Irina Tirdea <irina.tirdea@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de, Markus Pargmann <mpa@pengutronix.de>
Subject: [PATCH v3 0/4] iio: bmc150 regmap and SPI
Date: Mon, 21 Sep 2015 12:55:12 +0200 [thread overview]
Message-ID: <1442832916-30774-1-git-send-email-mpa@pengutronix.de> (raw)
Hi,
this series converts the bmc150 driver to use regmap and adds an SPI interface.
Thanks for testing and review so far. I rebased the series onto v4.3-rc2 now
(the togreg branch seems to be on v4.2).
It still works for me but there were some differences regarding the chip id.
Changes in v3:
- Fixed type of variable 'step' which lead to compile warnings. Type is now
size_t.
- Fixed patch that moved irq variable without reason
- Readded MODULE_* to the core driver
- Reintroduced check id NULL check
Changes in v2:
- Removed default values for regmap_config fields.
- Redesigned the fifo_transfer function to avoid running in errors first.
- Dropped irq checks patch as it is already mainline
- Core can now be built as module with autoselection of i2c and spi parts
As my hardware is missing an interrupt line from the SPI connected bmc150 I am
not able to test the iio buffer code path and the i2c code path. Tests would be
appreciated.
@Srinivas:
As there were some rebase conflicts on the first patch, I removed your
reviewed-by tag again for the moment.
Best regards,
Markus
Markus Pargmann (4):
iio: bmc150: Use i2c regmap
iio: bcm150: Remove i2c_client from private data
iio: bmc150: Split the driver into core and i2c
iio: bmc150: Add SPI driver
drivers/iio/accel/Kconfig | 14 +-
drivers/iio/accel/Makefile | 4 +-
.../accel/{bmc150-accel.c => bmc150-accel-core.c} | 388 ++++++++-------------
drivers/iio/accel/bmc150-accel-i2c.c | 102 ++++++
drivers/iio/accel/bmc150-accel-spi.c | 80 +++++
drivers/iio/accel/bmc150-accel.h | 20 ++
6 files changed, 366 insertions(+), 242 deletions(-)
rename drivers/iio/accel/{bmc150-accel.c => bmc150-accel-core.c} (82%)
create mode 100644 drivers/iio/accel/bmc150-accel-i2c.c
create mode 100644 drivers/iio/accel/bmc150-accel-spi.c
create mode 100644 drivers/iio/accel/bmc150-accel.h
--
2.5.1
next reply other threads:[~2015-09-21 10:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 10:55 Markus Pargmann [this message]
2015-09-21 10:55 ` [PATCH v3 1/4] iio: bmc150: Use i2c regmap Markus Pargmann
2015-09-23 12:47 ` Tirdea, Irina
2015-10-03 11:08 ` Jonathan Cameron
2015-09-21 10:55 ` [PATCH v3 2/4] iio: bcm150: Remove i2c_client from private data Markus Pargmann
2015-09-23 12:47 ` Tirdea, Irina
2015-10-03 11:09 ` Jonathan Cameron
2015-09-21 10:55 ` [PATCH v3 3/4] iio: bmc150: Split the driver into core and i2c Markus Pargmann
2015-09-23 12:51 ` Tirdea, Irina
2015-10-03 11:10 ` Jonathan Cameron
2015-10-03 11:07 ` Jonathan Cameron
2015-09-21 10:55 ` [PATCH v3 4/4] iio: bmc150: Add SPI driver Markus Pargmann
2015-10-03 11:04 ` Jonathan Cameron
2015-10-03 11:11 ` Jonathan Cameron
2015-09-23 12:46 ` [PATCH v3 0/4] iio: bmc150 regmap and SPI Tirdea, Irina
2015-09-24 7:11 ` Markus Pargmann
2015-09-24 11:30 ` Jonathan Cameron
2015-10-03 11:12 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442832916-30774-1-git-send-email-mpa@pengutronix.de \
--to=mpa@pengutronix.de \
--cc=irina.tirdea@intel.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).