From: Peter Rosin <peda@lysator.liu.se>
To: linux-iio@vger.kernel.org
Cc: Peter Rosin <peda@axentia.se>, Crt Mori <cmo@melexis.com>,
Daniel Baluta <daniel.baluta@gmail.com>,
Andreas Dannenberg <dannenberg@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Peter Rosin <peda@lysator.liu.se>,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 0/2] Driver for Microchip digital potentiometers
Date: Tue, 22 Sep 2015 17:36:47 +0200 [thread overview]
Message-ID: <1442936209-27057-1-git-send-email-peda@lysator.liu.se> (raw)
From: Peter Rosin <peda@axentia.se>
This is the fourth attempt for a driver for these chips.
Thanks for review comments from Greg Kroah-Hartman, Crt Mori,
Daniel Baluta, Lars-Peter Clauson, Andreas Dannenberg and Peter
Meerwald. I think and hope I got it all sorted.
Changes since v3:
- Use i2c_smbus_read_word_swapped (Peter)
- Use devm_iio_device_register and drop the mcp4531_remove op (Peter)
- Add defines for a few magic numbers (Peter)
- Deduplicate channel params with a macro (Peter)
- Mention the i2c client address options (Peter)
- Whitespace and other trivial nits (Peter)
Changes since v2:
- Change naming from mcp4xxx_dpot to mcp4531 (Daniel)
- Added links to datasheet in commit message and source (Daniel)
- Rename from pot to potentiometer (Daniel, Crt)
- Use IIO_RESISTANCE instead of IIO_STEPS (Crt, Lars-Peter)
- Don't use wildcards in MAINTAINERS and point to the iio list (Crt)
- Avoid races by not caching values (Crt)
- Spell Microchip correctly (Andreas)
Changes since v1:
- Make it an IIO driver instead (Greg)
- Don't convolute the code with big obscure macros (Greg)
- Inline the bits from mcp4xxx_dpot.h that are actually used
and drop that file (me)
- Better Changelog (Greg)
Cheers,
Peter
Peter Rosin (2):
iio: resistance: Document that resistance can be output
iio: mcp4531: Driver for Microchip digital potentiometers
Documentation/ABI/testing/sysfs-bus-iio | 2 +
MAINTAINERS | 6 +
drivers/iio/Kconfig | 1 +
drivers/iio/Makefile | 1 +
drivers/iio/potentiometer/Kconfig | 20 ++++
drivers/iio/potentiometer/Makefile | 6 +
drivers/iio/potentiometer/mcp4531.c | 196 +++++++++++++++++++++++++++++++
7 files changed, 232 insertions(+)
create mode 100644 drivers/iio/potentiometer/Kconfig
create mode 100644 drivers/iio/potentiometer/Makefile
create mode 100644 drivers/iio/potentiometer/mcp4531.c
--
1.7.10.4
next reply other threads:[~2015-09-22 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 15:36 Peter Rosin [this message]
2015-09-22 15:36 ` [PATCH v4 1/2] iio: resistance: Document that resistance can be output Peter Rosin
2015-09-22 15:36 ` [PATCH v4 2/2] iio: mcp4531: Driver for Microchip digital potentiometers Peter Rosin
2015-09-22 18:22 ` Jonathan Cameron
2015-09-23 7:39 ` Peter Rosin
2015-09-23 8:42 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442936209-27057-1-git-send-email-peda@lysator.liu.se \
--to=peda@lysator.liu.se \
--cc=cmo@melexis.com \
--cc=daniel.baluta@gmail.com \
--cc=dannenberg@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).