From: Octavian Purdila <octavian.purdila@intel.com>
To: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net
Cc: srinivas.pandruvada@linux.intel.com, hadess@hadess.net,
daniel.baluta@intel.com, irina.tirdea@intel.com, ao2@ao2.it,
u.kleine-koenig@pengutronix.de, vlad.dogaru@intel.com,
linus.walleij@linaro.org, tiberiu.a.breana@intel.com,
javier@osg.samsung.com, dan.carpenter@oracle.com,
geert@linux-m68k.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Octavian Purdila <octavian.purdila@intel.com>
Subject: [PATCH 1/2] iio: fix drivers that use 0 as a valid IRQ in client->irq (part 2)
Date: Wed, 23 Sep 2015 12:02:00 +0300 [thread overview]
Message-ID: <1442998921-17665-2-git-send-email-octavian.purdila@intel.com> (raw)
In-Reply-To: <1442998921-17665-1-git-send-email-octavian.purdila@intel.com>
Since commit dab472eb931bc291 ("i2c / ACPI: Use 0 to indicate that
device does not have interrupt assigned") 0 is not a valid i2c
client irq anymore, so change all driver's checks accordingly.
The same issue occurs when the device is instantiated via device tree
with no IRQ, or from the i2c sysfs interface, even before the patch
above.
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
---
drivers/iio/accel/stk8312.c | 2 +-
drivers/iio/accel/stk8ba50.c | 2 +-
drivers/iio/light/stk3310.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/accel/stk8312.c b/drivers/iio/accel/stk8312.c
index c764af2..a578694 100644
--- a/drivers/iio/accel/stk8312.c
+++ b/drivers/iio/accel/stk8312.c
@@ -572,7 +572,7 @@ static int stk8312_probe(struct i2c_client *client,
if (client->irq < 0)
client->irq = stk8312_gpio_probe(client);
- if (client->irq >= 0) {
+ if (client->irq > 0) {
ret = devm_request_threaded_irq(&client->dev, client->irq,
stk8312_data_rdy_trig_poll,
NULL,
diff --git a/drivers/iio/accel/stk8ba50.c b/drivers/iio/accel/stk8ba50.c
index 80f77d8..a59f5d8 100644
--- a/drivers/iio/accel/stk8ba50.c
+++ b/drivers/iio/accel/stk8ba50.c
@@ -468,7 +468,7 @@ static int stk8ba50_probe(struct i2c_client *client,
if (client->irq < 0)
client->irq = stk8ba50_gpio_probe(client);
- if (client->irq >= 0) {
+ if (client->irq > 0) {
ret = devm_request_threaded_irq(&client->dev, client->irq,
stk8ba50_data_rdy_trig_poll,
NULL,
diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index 25c6a71..4e56c90 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -636,7 +636,7 @@ static int stk3310_probe(struct i2c_client *client,
}
}
- if (client->irq >= 0) {
+ if (client->irq > 0) {
ret = devm_request_threaded_irq(&client->dev, client->irq,
stk3310_irq_handler,
stk3310_irq_event_handler,
--
1.9.1
next prev parent reply other threads:[~2015-09-23 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 9:01 [PATCH 0/2] remove unused ACPI GPIO interrupt probing code Octavian Purdila
2015-09-23 9:02 ` Octavian Purdila [this message]
2015-10-03 10:07 ` [PATCH 1/2] iio: fix drivers that use 0 as a valid IRQ in client->irq (part 2) Jonathan Cameron
2015-09-23 9:02 ` [PATCH 2/2] iio: remove gpio interrupt probing from drivers that use a single interrupt Octavian Purdila
2015-09-23 9:04 ` Bastien Nocera
2015-10-03 10:07 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442998921-17665-2-git-send-email-octavian.purdila@intel.com \
--to=octavian.purdila@intel.com \
--cc=ao2@ao2.it \
--cc=dan.carpenter@oracle.com \
--cc=daniel.baluta@intel.com \
--cc=geert@linux-m68k.org \
--cc=hadess@hadess.net \
--cc=irina.tirdea@intel.com \
--cc=javier@osg.samsung.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=tiberiu.a.breana@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).