* [PATCH] iio:light:apds9960 Fix sparse endian warnings.
@ 2015-09-23 19:36 Jonathan Cameron
2015-10-12 17:22 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2015-09-23 19:36 UTC (permalink / raw)
To: linux-iio; +Cc: Jonathan Cameron, mranostay
This patch is a tidy up of warnings from the autobuilder.
>> drivers/iio/light/apds9960.c:495:32: sparse: cast to restricted __le16
drivers/iio/light/apds9960.c:635:24: sparse: cast to restricted __le16
>> drivers/iio/light/apds9960.c:672:21: sparse: incorrect type in assignment (different base types)
drivers/iio/light/apds9960.c:672:21: expected unsigned short [unsigned] [usertype] buf
drivers/iio/light/apds9960.c:672:21: got restricted __le16 [usertype] <noident>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Cc: mranostay@gmail.com
---
drivers/iio/light/apds9960.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
index bf80ce47926b..7d269ef9e062 100644
--- a/drivers/iio/light/apds9960.c
+++ b/drivers/iio/light/apds9960.c
@@ -472,7 +472,7 @@ static int apds9960_read_raw(struct iio_dev *indio_dev,
int *val, int *val2, long mask)
{
struct apds9960_data *data = iio_priv(indio_dev);
- u16 buf;
+ __le16 buf;
int ret = -EINVAL;
if (data->gesture_mode_running)
@@ -613,7 +613,7 @@ static int apds9960_read_event(struct iio_dev *indio_dev,
int *val, int *val2)
{
u8 reg;
- u16 buf;
+ __le16 buf;
int ret = 0;
struct apds9960_data *data = iio_priv(indio_dev);
@@ -649,7 +649,7 @@ static int apds9960_write_event(struct iio_dev *indio_dev,
int val, int val2)
{
u8 reg;
- u16 buf;
+ __le16 buf;
int ret = 0;
struct apds9960_data *data = iio_priv(indio_dev);
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio:light:apds9960 Fix sparse endian warnings.
2015-09-23 19:36 [PATCH] iio:light:apds9960 Fix sparse endian warnings Jonathan Cameron
@ 2015-10-12 17:22 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-10-12 17:22 UTC (permalink / raw)
To: linux-iio; +Cc: mranostay
On 23/09/15 20:36, Jonathan Cameron wrote:
> This patch is a tidy up of warnings from the autobuilder.
>
>>> drivers/iio/light/apds9960.c:495:32: sparse: cast to restricted __le16
> drivers/iio/light/apds9960.c:635:24: sparse: cast to restricted __le16
>>> drivers/iio/light/apds9960.c:672:21: sparse: incorrect type in assignment (different base types)
> drivers/iio/light/apds9960.c:672:21: expected unsigned short [unsigned] [usertype] buf
> drivers/iio/light/apds9960.c:672:21: got restricted __le16 [usertype] <noident>
>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
> Cc: mranostay@gmail.com
Ah well, been on the list for a while and is kind of obvious.
Applied.
> ---
> drivers/iio/light/apds9960.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c
> index bf80ce47926b..7d269ef9e062 100644
> --- a/drivers/iio/light/apds9960.c
> +++ b/drivers/iio/light/apds9960.c
> @@ -472,7 +472,7 @@ static int apds9960_read_raw(struct iio_dev *indio_dev,
> int *val, int *val2, long mask)
> {
> struct apds9960_data *data = iio_priv(indio_dev);
> - u16 buf;
> + __le16 buf;
> int ret = -EINVAL;
>
> if (data->gesture_mode_running)
> @@ -613,7 +613,7 @@ static int apds9960_read_event(struct iio_dev *indio_dev,
> int *val, int *val2)
> {
> u8 reg;
> - u16 buf;
> + __le16 buf;
> int ret = 0;
> struct apds9960_data *data = iio_priv(indio_dev);
>
> @@ -649,7 +649,7 @@ static int apds9960_write_event(struct iio_dev *indio_dev,
> int val, int val2)
> {
> u8 reg;
> - u16 buf;
> + __le16 buf;
> int ret = 0;
> struct apds9960_data *data = iio_priv(indio_dev);
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-12 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-23 19:36 [PATCH] iio:light:apds9960 Fix sparse endian warnings Jonathan Cameron
2015-10-12 17:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).