From: Shraddha Barke <shraddha.6596@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Jonathan Cameron <jic23@kernel.org>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
Shraddha Barke <shraddha.6596@gmail.com>
Subject: [PATCH 1/2] Staging: iio: cdc: Prefer using the BIT macro
Date: Fri, 25 Sep 2015 22:53:01 +0530 [thread overview]
Message-ID: <1443201782-25863-2-git-send-email-shraddha.6596@gmail.com> (raw)
In-Reply-To: <1443201782-25863-1-git-send-email-shraddha.6596@gmail.com>
Replace bit shifting on 1 with the BIT(x) macro
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/iio/cdc/ad7746.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c
index 10fa372..55cc8bb 100644
--- a/drivers/staging/iio/cdc/ad7746.c
+++ b/drivers/staging/iio/cdc/ad7746.c
@@ -68,12 +68,12 @@
#define AD7746_VTSETUP_VTCHOP (1 << 0)
/* Excitation Setup Register Bit Designations (AD7746_REG_EXC_SETUP) */
-#define AD7746_EXCSETUP_CLKCTRL (1 << 7)
-#define AD7746_EXCSETUP_EXCON (1 << 6)
-#define AD7746_EXCSETUP_EXCB (1 << 5)
-#define AD7746_EXCSETUP_NEXCB (1 << 4)
-#define AD7746_EXCSETUP_EXCA (1 << 3)
-#define AD7746_EXCSETUP_NEXCA (1 << 2)
+#define AD7746_EXCSETUP_CLKCTRL BIT(7)
+#define AD7746_EXCSETUP_EXCON BIT(6)
+#define AD7746_EXCSETUP_EXCB BIT(5)
+#define AD7746_EXCSETUP_NEXCB BIT(4)
+#define AD7746_EXCSETUP_EXCA BIT(3)
+#define AD7746_EXCSETUP_NEXCA BIT(2)
#define AD7746_EXCSETUP_EXCLVL(x) (((x) & 0x3) << 0)
/* Config Register Bit Designations (AD7746_REG_CFG) */
--
2.1.4
next prev parent reply other threads:[~2015-09-25 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 17:23 [PATCH 0/2] Staging: iio: cdc: Use BIT macro and remove dev_info Shraddha Barke
2015-09-25 17:23 ` Shraddha Barke [this message]
2015-09-26 17:14 ` [PATCH 1/2] Staging: iio: cdc: Prefer using the BIT macro Lars-Peter Clausen
2015-09-27 13:46 ` Jonathan Cameron
2015-09-27 19:39 ` Shraddha Barke
2015-09-29 17:36 ` Jonathan Cameron
2015-09-25 17:23 ` [PATCH 2/2] Staging: iio: cdc: Remove unnecessary dev_info Shraddha Barke
2015-09-26 17:14 ` Lars-Peter Clausen
2015-09-27 13:47 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443201782-25863-2-git-send-email-shraddha.6596@gmail.com \
--to=shraddha.6596@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).