* [PATCH] iio: bmc150: Fix type of step transfer variable
[not found] <201510032331.iV9fviPZ%fengguang.wu@intel.com>
@ 2015-10-06 18:31 ` Markus Pargmann
2015-10-11 9:32 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Markus Pargmann @ 2015-10-06 18:31 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio @ vger . kernel . org, Markus Pargmann
regmap_get_raw_read_max() returns type size_t. Also the later dev_err()
already uses the correct printk format "%zu".
This patch changes the type of 'step' to size_t.
Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
---
Hi,
this problem was reported by the kbuild robot. This should fix the warning. I
am not sure if the patches are already in some public tree, otherwise this
could directly be squashed into the commit directly.
Thanks,
Markus
drivers/iio/accel/bmc150-accel-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
index 614cf61f0110..dc89cf8b7603 100644
--- a/drivers/iio/accel/bmc150-accel-core.c
+++ b/drivers/iio/accel/bmc150-accel-core.c
@@ -891,7 +891,7 @@ static int bmc150_accel_fifo_transfer(struct bmc150_accel_data *data,
int ret;
int total_length = samples * sample_length;
int i;
- int step = regmap_get_raw_read_max(data->regmap);
+ size_t step = regmap_get_raw_read_max(data->regmap);
if (!step || step > total_length)
step = total_length;
--
2.6.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: bmc150: Fix type of step transfer variable
2015-10-06 18:31 ` [PATCH] iio: bmc150: Fix type of step transfer variable Markus Pargmann
@ 2015-10-11 9:32 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-10-11 9:32 UTC (permalink / raw)
To: Markus Pargmann; +Cc: linux-iio @ vger . kernel . org
On 06/10/15 19:31, Markus Pargmann wrote:
> regmap_get_raw_read_max() returns type size_t. Also the later dev_err()
> already uses the correct printk format "%zu".
>
> This patch changes the type of 'step' to size_t.
>
> Signed-off-by: Markus Pargmann <mpa@pengutronix.de>
> ---
> Hi,
>
> this problem was reported by the kbuild robot. This should fix the warning. I
> am not sure if the patches are already in some public tree, otherwise this
> could directly be squashed into the commit directly.
>
> Thanks,
>
> Markus
I'm not sure what happened here. I haven't touched the tree since this report,
but the type is already size_t in my local tree.
Anyhow, the issues seems not to exist anymore for some reason.
J
>
>
> drivers/iio/accel/bmc150-accel-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index 614cf61f0110..dc89cf8b7603 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -891,7 +891,7 @@ static int bmc150_accel_fifo_transfer(struct bmc150_accel_data *data,
> int ret;
> int total_length = samples * sample_length;
> int i;
> - int step = regmap_get_raw_read_max(data->regmap);
> + size_t step = regmap_get_raw_read_max(data->regmap);
>
> if (!step || step > total_length)
> step = total_length;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-11 9:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201510032331.iV9fviPZ%fengguang.wu@intel.com>
2015-10-06 18:31 ` [PATCH] iio: bmc150: Fix type of step transfer variable Markus Pargmann
2015-10-11 9:32 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).