From: Gabriele Mazzotta <gabriele.mzt@gmail.com>
To: jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
marex@denx.de, marxin.liska@gmail.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: [PATCH v2] iio: light: acpi-als: Report data as processed
Date: Tue, 12 Jan 2016 16:21:39 +0100 [thread overview]
Message-ID: <1452612099-26630-1-git-send-email-gabriele.mzt@gmail.com> (raw)
In-Reply-To: <1452180105-9584-1-git-send-email-gabriele.mzt@gmail.com>
As per the ACPI specification (Revision 5.0) [1], the data coming
from the sensor represent the ambient light illuminance reading
expressed in lux. So use IIO_CHAN_INFO_PROCESSED to signify that
the data are pre-processed.
However, to keep backward ABI compatibility, the IIO_CHAN_INFO_RAW
bit is not removed.
[1] http://www.acpi.info/DOWNLOADS/ACPIspec50.pdf
Signed-off-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
---
drivers/iio/light/acpi-als.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/light/acpi-als.c b/drivers/iio/light/acpi-als.c
index 60537ec..53201d9 100644
--- a/drivers/iio/light/acpi-als.c
+++ b/drivers/iio/light/acpi-als.c
@@ -54,7 +54,9 @@ static const struct iio_chan_spec acpi_als_channels[] = {
.realbits = 32,
.storagebits = 32,
},
- .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+ /* _RAW is here for backward ABI compatibility */
+ .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
+ BIT(IIO_CHAN_INFO_PROCESSED),
},
};
@@ -152,7 +154,7 @@ static int acpi_als_read_raw(struct iio_dev *indio_dev,
s32 temp_val;
int ret;
- if (mask != IIO_CHAN_INFO_RAW)
+ if ((mask != IIO_CHAN_INFO_PROCESSED) && (mask != IIO_CHAN_INFO_RAW))
return -EINVAL;
/* we support only illumination (_ALI) so far. */
--
2.7.0.rc3
next prev parent reply other threads:[~2016-01-12 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 15:21 [PATCH] iio: light: acpi-als: Report data as processed rather than raw Gabriele Mazzotta
2016-01-09 16:31 ` Jonathan Cameron
2016-01-09 17:27 ` Marek Vasut
2016-01-11 19:18 ` Jonathan Cameron
2016-01-11 19:20 ` Marek Vasut
2016-01-12 0:15 ` Gabriele Mazzotta
2016-01-12 15:27 ` Gabriele Mazzotta
2016-01-16 12:57 ` Jonathan Cameron
2016-01-11 10:16 ` Crt Mori
2016-01-11 19:15 ` Jonathan Cameron
2016-01-12 15:21 ` Gabriele Mazzotta [this message]
2016-01-16 13:02 ` [PATCH v2] iio: light: acpi-als: Report data as processed Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452612099-26630-1-git-send-email-gabriele.mzt@gmail.com \
--to=gabriele.mzt@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=marxin.liska@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).