From: Daniel Baluta <daniel.baluta@intel.com>
To: jic23@kernel.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
wsa@the-dreams.de, linux-i2c@vger.kernel.org,
lucas.demarchi@intel.com, daniel.baluta@intel.com,
srinivas.pandruvada@linux.intel.com, ggao@invensense.com,
adi.reus@gmail.com, cmo@melexis.com, mwelling@ieee.org
Subject: [RFC PATCH 0/9] iio: Fix ABBA deadlock in inv-mpu6050
Date: Thu, 18 Feb 2016 17:53:05 +0200 [thread overview]
Message-ID: <1455810794-3188-1-git-send-email-daniel.baluta@intel.com> (raw)
Sending this as an RFC because I don't know if style fixes are appropriate
for this driver and also not sure if deadlock fix is the best solution.
I2C people should only look at patches 8/9 and 9/9.
The mpu6050 accel+gyro combo has an auxiliary I2C bus, allowing for
an auxiliary sensor to be connected (eg. a magnetometer).
The mpu can either act as an I2C master (functionality not currently
implemented in the driver) or it can use a bypass multiplexer which
directly connects the auxiliary I2C bus pins to the main I2C bus pins [1]
Currently the driver implements the bypass mode via an I2C mux.
This patchset fixes a deadlock in inv-mpu6050 IMU which happens when
magnetometer (on auxiliary I2C bus) runs in parallel with accel or gyro.
First 7 patches do some cleanup in order to make INV MPU6050 code easier
to read.
Patch number 8 allows passing NULL select callbacks to i2c_mux_master_xfer
and i2c_mux_smbus_xfer.
Patch number 9 actually fixes the deadlock.
[1] (page 28, https://www.cdiweb.com/datasheets/invensense/MPU-6050_DataSheet_V3%204.pdf)
Adriana Reus (2):
i2c: i2c-mux: Allow for NULL select callback
iio: imu: inv_mpu6050: Fix deadlock between i2c adapter lock and mpu
lock
Daniel Baluta (7):
iio: imu: inv_mpu6050: Fix multiline comments style
iio: imu: inv_mpu6050: Fix Yoda conditions
iio: imu: inv_mpu6050: Fix newlines to make code easier to read
iio: imu: inv_mpu6050: Remove unnecessary parentheses
iio: imu: inv_mpu6050: Delete space before comma
iio: imu: inv_mpu6050: Fix code indent for if statement
iio: imu: inv_mpu6050: Fix alignment with open parenthesis
drivers/i2c/i2c-mux.c | 10 ++-
drivers/iio/imu/inv_mpu6050/inv_mpu_acpi.c | 6 +-
drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 101 ++++++++++++++------------
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 90 ++++-------------------
drivers/iio/imu/inv_mpu6050/inv_mpu_ring.c | 23 +++---
drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 22 +++---
6 files changed, 102 insertions(+), 150 deletions(-)
--
2.5.0
next reply other threads:[~2016-02-18 15:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 15:53 Daniel Baluta [this message]
2016-02-18 15:53 ` [RFC PATCH 1/9] iio: imu: inv_mpu6050: Fix multiline comments style Daniel Baluta
2016-02-21 20:36 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 2/9] iio: imu: inv_mpu6050: Fix Yoda conditions Daniel Baluta
2016-02-19 9:09 ` Crt Mori
2016-02-21 20:38 ` Jonathan Cameron
2016-03-01 21:23 ` Wolfram Sang
2016-02-18 15:53 ` [RFC PATCH 3/9] iio: imu: inv_mpu6050: Fix newlines to make code easier to read Daniel Baluta
2016-02-21 20:38 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 4/9] iio: imu: inv_mpu6050: Remove unnecessary parentheses Daniel Baluta
2016-02-21 20:39 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 5/9] iio: imu: inv_mpu6050: Delete space before comma Daniel Baluta
2016-02-18 15:53 ` [RFC PATCH 6/9] iio: imu: inv_mpu6050: Fix code indent for if statement Daniel Baluta
2016-02-21 20:40 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Daniel Baluta
2016-02-21 20:41 ` Jonathan Cameron
2016-02-21 20:59 ` Joe Perches
2016-02-21 21:08 ` Jonathan Cameron
2016-02-18 15:53 ` [RFC PATCH 8/9] i2c: i2c-mux: Allow for NULL select callback Daniel Baluta
2016-03-01 20:30 ` Wolfram Sang
2016-03-01 20:38 ` Daniel Baluta
2016-02-18 15:53 ` [RFC PATCH 9/9] iio: imu: inv_mpu6050: Fix deadlock between i2c adapter lock and mpu lock Daniel Baluta
2016-02-18 18:17 ` Srinivas Pandruvada
2016-02-19 20:17 ` Ge Gao
2016-03-01 20:50 ` Wolfram Sang
2016-03-02 16:33 ` Daniel Baluta
2016-03-02 17:06 ` Wolfram Sang
2016-02-21 23:17 ` [RFC PATCH 0/9] iio: Fix ABBA deadlock in inv-mpu6050 Wolfram Sang
2016-02-22 9:43 ` Daniel Baluta
2016-02-26 15:52 ` Daniel Baluta
2016-03-03 23:09 ` Peter Rosin
2016-03-04 10:20 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455810794-3188-1-git-send-email-daniel.baluta@intel.com \
--to=daniel.baluta@intel.com \
--cc=adi.reus@gmail.com \
--cc=cmo@melexis.com \
--cc=ggao@invensense.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=mwelling@ieee.org \
--cc=pmeerw@pmeerw.net \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).