From: Atri Bhattacharya <badshah400@aim.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)
Date: Thu, 02 Jun 2016 09:48:49 +0200 [thread overview]
Message-ID: <1464853729.2640.8.camel@aim.com> (raw)
In-Reply-To: <loom.20160602T052411-711@post.gmane.org>
On Thu, 2016-06-02 at 03:27 +0000, Srinivas Pandruvada wrote:
> Atri Bhattacharya <badshah400@...> writes:
>
> >
> > Thanks a lot for adding support for this. I have a Lenovo Thinkpad
> > Yoga
> > 260, so I decided to give it a try. I used your patches on kernel
> > 4.6.0
> > and installed the patched kernel. Now, I see that the device is
> > recognised immediately. I use the iio-sensor-proxy application from
> > [1], and it now recognises the sensors. But changing orientation
> > doesn't seem to do anything, and moreover upon a wakeup from
> > suspend I
> > see the following messages on the journal:
> >
> > Jun 01 15:15:09 tp-yoga260 kernel: [drm] RC6 on
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0001:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0002:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0002:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0002:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: hid-sensor-hub
> > 0044:8086:22D8.0002:
> > timeout waiting for response from ISHTP device
> > Jun 01 15:15:09 tp-yoga260 kernel: PM: resume of devices complete
> > after
> > 37095.288 msecs
> >
> > Also suspend and wakeup seems to be really slow now. Please let me
> > know
> > if there is any other info I can provide.
> >
> > Thanks and best wishes.
> >
> > [1] https://github.com/hadess/iio-sensor-proxy
> >
>
> Can you reply to all, so that I get email in my inbox?
> You will need this as you have older FW?
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-
> hub.c
> index 3d5ba5b..658a607 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -16,6 +16,7 @@
> * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
> *
> */
> +
> #include <linux/device.h>
> #include <linux/hid.h>
> #include <linux/module.h>
> @@ -798,6 +799,9 @@ static const struct hid_device_id
> sensor_hub_devices[] =
> {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_ITE,
> USB_DEVICE_ID_ITE_LENOVO_YOGA900),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_INTEL_0,
> + 0x22D8),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> HID_ANY_ID) },
> { }
>
>
Thanks for your response, but this patch didn't help with the slow
suspend/wakeup problem or with making the device actually respond to
rotation or brightness changes. At this stage the sensor-hub seems to
be recognised just fine, but not to be working. Same messages as above
continue to show up in the journal.
Best wishes
--
Atri Bhattacharya
Thu 2 Jun 09:42:21 CEST 2016
Sent from openSUSE Tumbleweed (20160530) (x86_64) on my laptop.
next prev parent reply other threads:[~2016-06-02 7:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 4:27 [RFC 0/4] Intel Integrated Sensor Hub Support (ISH) Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 1/4] Documentation: hid: Intel ISH HID document Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 2/4] hid: intel_ish-hid: ISH Transport layer Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 3/4] hid: intel-ish-hid: ipc layer Srinivas Pandruvada
2016-05-31 4:27 ` [RFC 4/4] hid: intel-ish-hid: ISH HID client driver Srinivas Pandruvada
2016-06-01 13:36 ` [RFC 0/4] Intel Integrated Sensor Hub Support (ISH) Atri Bhattacharya
2016-06-02 3:27 ` Srinivas Pandruvada
2016-06-02 7:48 ` Atri Bhattacharya [this message]
2016-06-02 16:49 ` Srinivas Pandruvada
2016-06-02 19:42 ` Atri Bhattacharya
2016-06-02 20:00 ` Srinivas Pandruvada
2016-06-02 21:44 ` Pandruvada, Srinivas
2016-06-02 22:29 ` Atri Bhattacharya
2016-06-02 22:48 ` Srinivas Pandruvada
2016-06-02 22:57 ` Atri Bhattacharya
2016-06-02 23:13 ` Atri Bhattacharya
2016-06-03 2:50 ` Atri Bhattacharya
2016-06-03 4:01 ` Srinivas Pandruvada
2016-06-03 3:08 ` Atri Bhattacharya
2016-06-03 4:02 ` Srinivas Pandruvada
2016-06-06 6:47 ` Srinivas Pandruvada
2016-06-09 21:45 ` Grant Likely
2016-06-09 21:54 ` Srinivas Pandruvada
2016-06-10 9:44 ` Grant Likely
2016-06-10 13:55 ` Srinivas Pandruvada
2016-06-10 14:26 ` Bastien Nocera
2016-06-10 14:45 ` Srinivas Pandruvada
2016-06-10 15:04 ` Bastien Nocera
2016-06-10 15:23 ` Srinivas Pandruvada
2016-06-10 15:27 ` Bastien Nocera
2016-06-14 13:44 ` Grant Likely
2016-06-14 15:12 ` Bastien Nocera
2016-06-14 16:08 ` Grant Likely
2016-06-14 17:01 ` Bastien Nocera
2016-06-14 21:33 ` Grant Likely
2016-06-10 14:02 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464853729.2640.8.camel@aim.com \
--to=badshah400@aim.com \
--cc=linux-iio@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).