From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, Akinobu Mita <akinobu.mita@gmail.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Matt Ranostay <mranostay@gmail.com>
Cc: Christoph Mair <christoph.mair@gmail.com>,
Vlad Dogaru <vlad.dogaru@intel.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Marek Belisko <marek@goldelico.com>,
Eric Andersson <eric.andersson@unixphere.com>,
Neil Brown <neilb@suse.de>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 03/10 v3] iio: pressure: bmp280: add reset GPIO line handling
Date: Mon, 27 Jun 2016 18:30:13 +0200 [thread overview]
Message-ID: <1467045020-2665-4-git-send-email-linus.walleij@linaro.org> (raw)
In-Reply-To: <1467045020-2665-1-git-send-email-linus.walleij@linaro.org>
On the APQ8060 Dragonboard the reset line to the BMP058 pressure
sensor is not deasserted on boot, so the driver needs to handle
this. For a simple GPIO line supplied as a descriptor (from a board
file, device tree or ACPI) this does the trick.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v2->v3:
- None, just rebasing/resending
---
drivers/iio/pressure/bmp280.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/iio/pressure/bmp280.c b/drivers/iio/pressure/bmp280.c
index fa76f5851245..1618968f8889 100644
--- a/drivers/iio/pressure/bmp280.c
+++ b/drivers/iio/pressure/bmp280.c
@@ -23,6 +23,7 @@
#include <linux/delay.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
+#include <linux/gpio/consumer.h>
/* BMP280 specific registers */
#define BMP280_REG_HUMIDITY_LSB 0xFE
@@ -1024,6 +1025,7 @@ static int bmp280_probe(struct i2c_client *client,
struct iio_dev *indio_dev;
struct bmp280_data *data;
unsigned int chip_id;
+ struct gpio_desc *gpiod;
indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));
if (!indio_dev)
@@ -1063,6 +1065,14 @@ static int bmp280_probe(struct i2c_client *client,
return -EINVAL;
}
+ /* Bring chip out of reset if there is an assigned GPIO line */
+ gpiod = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
+ /* Deassert the signal */
+ if (!IS_ERR(gpiod)) {
+ dev_info(&client->dev, "release reset\n");
+ gpiod_set_value(gpiod, 0);
+ }
+
data->regmap = devm_regmap_init_i2c(client,
data->chip_info->regmap_config);
if (IS_ERR(data->regmap)) {
--
2.4.11
next prev parent reply other threads:[~2016-06-27 16:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 16:30 [PATCH 00/10] Improve the BMP280 driver v3 Linus Walleij
2016-06-27 16:30 ` [PATCH 01/10 v3] iio: pressure: bmp280: augment DT bindings Linus Walleij
2016-06-27 16:30 ` [PATCH 02/10 v3] iio: pressure: bmp280: support device tree initialization Linus Walleij
2016-06-27 16:30 ` Linus Walleij [this message]
2016-06-27 16:52 ` [PATCH 03/10 v3] iio: pressure: bmp280: add reset GPIO line handling Peter Meerwald-Stadler
2016-06-27 17:05 ` Linus Walleij
2016-06-29 17:45 ` Jonathan Cameron
2016-06-29 19:00 ` Linus Walleij
2016-06-27 16:30 ` [PATCH 04/10 v3] iio: pressure: bmp280: support supply regulators Linus Walleij
2016-06-27 16:56 ` Peter Meerwald-Stadler
2016-06-27 16:30 ` [PATCH 05/10 v3] iio: pressure: bmp280: split driver in logical parts Linus Walleij
2016-06-28 13:43 ` Akinobu Mita
2016-06-27 16:30 ` [PATCH 06/10 v3] iio: pressure: bmp280: split off an I2C Kconfig entry Linus Walleij
2016-06-27 16:30 ` [PATCH 07/10 v3] iio: pressure: bmp280: add SPI interface driver Linus Walleij
2016-06-27 17:06 ` Peter Meerwald-Stadler
2016-06-29 14:35 ` Linus Walleij
2016-06-27 16:30 ` [PATCH 08/10 v3] iio: pressure: bmp280: add support for BMP085 EOC interrupt Linus Walleij
2016-06-27 16:30 ` [PATCH 09/10 v3] iio: pressure: bmp280: read calibration data once Linus Walleij
2016-06-27 17:01 ` Peter Meerwald-Stadler
2016-06-27 16:30 ` [PATCH 10/10 v3] iio: pressure: bmp280: add power management Linus Walleij
2016-06-27 17:09 ` Peter Meerwald-Stadler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467045020-2665-4-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=akinobu.mita@gmail.com \
--cc=christoph.mair@gmail.com \
--cc=eric.andersson@unixphere.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mranostay@gmail.com \
--cc=neilb@suse.de \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).