From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Gregor Boirie <gregor.boirie@parrot.com>,
Richard Leitner <dev@g0hl1n.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Gwendal Grignou <gwendal@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH 2/6 v3] iio: magn: ak8975: add Vid regulator
Date: Wed, 29 Jun 2016 14:08:34 +0200 [thread overview]
Message-ID: <1467202118-10386-3-git-send-email-linus.walleij@linaro.org> (raw)
In-Reply-To: <1467202118-10386-1-git-send-email-linus.walleij@linaro.org>
The AK8975 has two power sources: Vdd (analog voltage supply)
and Vid (digital voltage supply). Optionally also obtain the Vid
supply regulator and enable it.
If an error occurs when enabling one of the regulators: bail out.
Cc: Gregor Boirie <gregor.boirie@parrot.com>
Cc: Richard Leitner <dev@g0hl1n.net>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v2->v3:
- No changes. Numbered v2 to be part of the patch set.
- Rebase.
ChangeLog v1->v2:
- Just obtain the other regulator exactly like the first without
trying to be fancy.
- Rebase and rewrite on top of the patch fixing up the regulator
usage.
---
drivers/iio/magnetometer/ak8975.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index 7f51adba7bad..af3395a0fb16 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -379,6 +379,7 @@ struct ak8975_data {
u8 cntl_cache;
struct iio_mount_matrix orientation;
struct regulator *vdd;
+ struct regulator *vid;
};
/* Enable attached power regulator if any. */
@@ -399,6 +400,19 @@ static int ak8975_power_on(struct i2c_client *client)
"Failed to enable specified Vdd supply\n");
return ret;
}
+
+ data->vid = devm_regulator_get(&client->dev, "vid");
+ if (IS_ERR(data->vid)) {
+ ret = PTR_ERR(data->vid);
+ } else {
+ ret = regulator_enable(data->vid);
+ }
+ if (ret) {
+ dev_warn(&client->dev,
+ "Failed to enable specified Vid supply\n");
+ return ret;
+ }
+ return 0;
}
/* Disable attached power regulator if any. */
@@ -407,6 +421,7 @@ static void ak8975_power_off(const struct i2c_client *client)
const struct iio_dev *indio_dev = i2c_get_clientdata(client);
const struct ak8975_data *data = iio_priv(indio_dev);
+ regulator_disable(data->vid);
regulator_disable(data->vdd);
}
--
2.4.11
next prev parent reply other threads:[~2016-06-29 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:08 [PATCH 0/7] Fix regulators and PM for AK8975 v3 Linus Walleij
2016-06-29 12:08 ` [PATCH 1/6 v3] iio: magn: ak8975: fix regulator usage Linus Walleij
2016-06-30 19:33 ` Jonathan Cameron
2016-06-29 12:08 ` Linus Walleij [this message]
2016-06-30 19:35 ` [PATCH 2/6 v3] iio: magn: ak8975: add Vid regulator Jonathan Cameron
2016-06-29 12:08 ` [PATCH 3/6 v3] iio: magn: ak8975: refactor regulator handlers Linus Walleij
2016-06-30 19:35 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 4/6 v3] iio: magn: ak8975: allow a delay after enabling regulators Linus Walleij
2016-06-30 19:36 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 5/6 v3] iio: magn: ak8975: make sure to power down at remove() Linus Walleij
2016-06-29 16:33 ` Ulf Hansson
2016-06-30 19:37 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 6/6 v3] iio: magn: ak8975: deploy runtime and system PM Linus Walleij
2016-06-29 16:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467202118-10386-3-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=dev@g0hl1n.net \
--cc=gregor.boirie@parrot.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).