From: Linus Walleij <linus.walleij@linaro.org>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Gregor Boirie <gregor.boirie@parrot.com>,
Richard Leitner <dev@g0hl1n.net>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Gwendal Grignou <gwendal@chromium.org>,
Linus Walleij <linus.walleij@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH 5/6 v3] iio: magn: ak8975: make sure to power down at remove()
Date: Wed, 29 Jun 2016 14:08:37 +0200 [thread overview]
Message-ID: <1467202118-10386-6-git-send-email-linus.walleij@linaro.org> (raw)
In-Reply-To: <1467202118-10386-1-git-send-email-linus.walleij@linaro.org>
The code was not powering the magnetometer down properly at
remove(): just cutting the regulators without first setting the
device in power off mode. Fix this.
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
ChangeLog v2->v3:
- Rebase
ChangeLog v1->v2:
- New patch in the series after Ulf's review comment that this
should be separate.
---
drivers/iio/magnetometer/ak8975.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
index c67cf3a6128d..43dc1c74be9e 100644
--- a/drivers/iio/magnetometer/ak8975.c
+++ b/drivers/iio/magnetometer/ak8975.c
@@ -990,6 +990,7 @@ static int ak8975_remove(struct i2c_client *client)
iio_device_unregister(indio_dev);
iio_triggered_buffer_cleanup(indio_dev);
+ ak8975_set_mode(data, POWER_DOWN);
ak8975_power_off(data);
return 0;
--
2.4.11
next prev parent reply other threads:[~2016-06-29 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 12:08 [PATCH 0/7] Fix regulators and PM for AK8975 v3 Linus Walleij
2016-06-29 12:08 ` [PATCH 1/6 v3] iio: magn: ak8975: fix regulator usage Linus Walleij
2016-06-30 19:33 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 2/6 v3] iio: magn: ak8975: add Vid regulator Linus Walleij
2016-06-30 19:35 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 3/6 v3] iio: magn: ak8975: refactor regulator handlers Linus Walleij
2016-06-30 19:35 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 4/6 v3] iio: magn: ak8975: allow a delay after enabling regulators Linus Walleij
2016-06-30 19:36 ` Jonathan Cameron
2016-06-29 12:08 ` Linus Walleij [this message]
2016-06-29 16:33 ` [PATCH 5/6 v3] iio: magn: ak8975: make sure to power down at remove() Ulf Hansson
2016-06-30 19:37 ` Jonathan Cameron
2016-06-29 12:08 ` [PATCH 6/6 v3] iio: magn: ak8975: deploy runtime and system PM Linus Walleij
2016-06-29 16:35 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467202118-10386-6-git-send-email-linus.walleij@linaro.org \
--to=linus.walleij@linaro.org \
--cc=dev@g0hl1n.net \
--cc=gregor.boirie@parrot.com \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).