From: Daniel Wagner <wagi@monom.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH 0/2] Use complete() instead of complete_all()
Date: Thu, 4 Aug 2016 15:07:08 +0200 [thread overview]
Message-ID: <1470316030-4153-1-git-send-email-wagi@monom.org> (raw)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Hi,
Using complete_all() is not wrong per se but it suggest that there
might be more than one reader. For -rt I am reviewing all
complete_all() users and would like to leave only the real ones in the
tree. The main problem for -rt about complete_all() is that it can be
uses inside IRQ context and that can lead to unbounded amount work
inside the interrupt handler. That is a no no for -rt.
The patches grouped per subsystem and in small batches to allow
reviewing. Unfortanatly I am not so good in coming up with unique
commit message, so please bear with me in that regard. I could also
squash them together, although each patch containts a very short
reasoning why there is only one waiter. Let me know what you rather
prefer. One patch which updates all complete_all() users or those 2
patches with some reasoning.
It is only test compiled because I don't have the all the hardware.
cheers,
daniel
Daniel Wagner (2):
iio: adc: Use complete() instead of complete_all()
iio: sx9500: Use complete() instead of complete_all()
drivers/iio/adc/nau7802.c | 2 +-
drivers/iio/proximity/sx9500.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
next reply other threads:[~2016-08-04 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 13:07 Daniel Wagner [this message]
2016-08-04 13:07 ` [PATCH 1/2] iio: adc: Use complete() instead of complete_all() Daniel Wagner
2016-08-15 17:02 ` Jonathan Cameron
2016-08-04 13:07 ` [PATCH 2/2] iio: sx9500: " Daniel Wagner
2016-08-15 17:02 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470316030-4153-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).