From: Christoph Fritz <chf.fritz@googlemail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Vlad Dogaru <ddvlad@gmail.com>, Hartmut Knaack <knaack.h@gmx.de>,
linux-iio@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] iio: sx9500: add final devicetree support
Date: Fri, 02 Sep 2016 17:23:39 +0200 [thread overview]
Message-ID: <1472829819.12668.3.camel@googlemail.com> (raw)
In-Reply-To: <CAOMZO5BVDS=AaSyRS0ELBiEKx3RxdstXgA_xJ6ANUzKDxdyBxg@mail.gmail.com>
On Fri, 2016-09-02 at 12:12 -0300, Fabio Estevam wrote:
> On Fri, Sep 2, 2016 at 12:04 PM, Christoph Fritz
> <chf.fritz@googlemail.com> wrote:
>
> > Here on my board I'm using the reset pin as an open-drain with external
> > pullup, so GPIO_ACTIVE_HIGH is valid.
> >
> > As this is an example, I don't care if it says _HIGH or _LOW.
>
> Then probably it is better to remove "reset-gpios" from the example.
>
> The driver does not parse this dt property and the reset is being done
> via software command as far as I can see.
What do you mean by "software command", to send a reset command by i2c?
The reset GPIO is fetched in sx9500 here:
See sx9500_gpio_probe():
...
data->gpiod_rst = devm_gpiod_get_index(dev, SX9500_GPIO_RESET,
0, GPIOD_OUT_HIGH);
...
next prev parent reply other threads:[~2016-09-02 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 14:49 [PATCH] iio: sx9500: add final devicetree support Christoph Fritz
2016-09-02 14:53 ` Fabio Estevam
2016-09-02 15:04 ` Christoph Fritz
2016-09-02 15:12 ` Fabio Estevam
2016-09-02 15:23 ` Christoph Fritz [this message]
2016-09-02 16:16 ` Fabio Estevam
2016-09-02 16:47 ` Christoph Fritz
2016-09-02 18:25 ` Fabio Estevam
2016-09-03 10:30 ` [PATCH v2] " Christoph Fritz
2016-09-03 11:15 ` Fabio Estevam
2016-09-03 11:19 ` Vlad Dogaru
2016-09-03 14:27 ` Jonathan Cameron
2016-09-12 15:44 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472829819.12668.3.camel@googlemail.com \
--to=chf.fritz@googlemail.com \
--cc=ddvlad@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).