From: Ico Doornekamp <ico@pruts.nl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH] iio: accel: sca3000_core: implemented IIO_CHAN_INFO_SAMP_FREQ
Date: Wed, 14 Sep 2016 07:59:23 +0200 [thread overview]
Message-ID: <1473832511-sup-5279@pruts.nl> (raw)
In-Reply-To: <99ce25ac-2330-ad53-151d-f580226906eb@kernel.org>
* On 2016-09-13 19:35:28 +0200, Jonathan Cameron wrote:
> Other than one big issue, the patch looks very good.
>
> You actually need to add this entry to one of the info_mask bitmaps to
> have the attributes instantiated.
I suspected as much, but I wasn't quite sure about the semantics of the
fields, and when to use info_mask_shared_by_type vs info_mask_shared_by_all.
--
:wq
^X^Cy^K^X^C^C^C^C
next prev parent reply other threads:[~2016-09-14 5:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 19:19 [PATCH] iio: accel: sca3000_core: implemented IIO_CHAN_INFO_SAMP_FREQ Ico Doornekamp
2016-09-13 17:35 ` Jonathan Cameron
2016-09-14 5:59 ` Ico Doornekamp [this message]
2016-09-14 6:26 ` Jonathan Cameron
[not found] ` <20160913191414.3381-1-ico@pruts.nl>
2016-09-18 10:40 ` Jonathan Cameron
2016-09-18 10:47 ` Jonathan Cameron
2016-09-18 11:01 ` Ico Doornekamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473832511-sup-5279@pruts.nl \
--to=ico@pruts.nl \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).