* [PATCH] hid: hid-sensor-hub: clear memory to avoid random data
@ 2016-11-07 1:04 Song Hongyan
2016-11-07 17:17 ` Pandruvada, Srinivas
0 siblings, 1 reply; 4+ messages in thread
From: Song Hongyan @ 2016-11-07 1:04 UTC (permalink / raw)
To: linux-iio; +Cc: srinivas.pandruvada, Song Hongyan
Initialize user buffer with 0s. This will avoid random data in the buffer,
when the user buffer size is bigger than the actual report size.
Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
drivers/hid/hid-sensor-hub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 658a607..980992c 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -212,6 +212,7 @@ int sensor_hub_set_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
__s32 value;
int ret = 0;
+ memset(buffer, 0, buffer_size);
mutex_lock(&data->mutex);
report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
if (!report || (field_index >= report->maxfield)) {
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hid: hid-sensor-hub: clear memory to avoid random data
2016-11-07 1:04 [PATCH] hid: hid-sensor-hub: clear memory to avoid random data Song Hongyan
@ 2016-11-07 17:17 ` Pandruvada, Srinivas
0 siblings, 0 replies; 4+ messages in thread
From: Pandruvada, Srinivas @ 2016-11-07 17:17 UTC (permalink / raw)
To: Song, Hongyan, linux-iio@vger.kernel.org
T24gTW9uLCAyMDE2LTExLTA3IGF0IDAxOjA0ICswMDAwLCBTb25nIEhvbmd5YW4gd3JvdGU6DQo+
IEluaXRpYWxpemUgdXNlciBidWZmZXIgd2l0aCAwcy4gVGhpcyB3aWxsIGF2b2lkIHJhbmRvbSBk
YXRhIGluIHRoZQ0KPiBidWZmZXIsDQo+IHdoZW4gdGhlIHVzZXIgYnVmZmVyIHNpemUgaXMgYmln
Z2VyIHRoYW4gdGhlIGFjdHVhbCByZXBvcnQgc2l6ZS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IFNv
bmcgSG9uZ3lhbiA8aG9uZ3lhbi5zb25nQGludGVsLmNvbT4NCj4gLS0tDQo+IMKgZHJpdmVycy9o
aWQvaGlkLXNlbnNvci1odWIuYyB8IDEgKw0KPiDCoDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlv
bigrKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaGlkL2hpZC1zZW5zb3ItaHViLmMgYi9k
cml2ZXJzL2hpZC9oaWQtc2Vuc29yLQ0KPiBodWIuYw0KPiBpbmRleCA2NThhNjA3Li45ODA5OTJj
IDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2hpZC9oaWQtc2Vuc29yLWh1Yi5jDQo+ICsrKyBiL2Ry
aXZlcnMvaGlkL2hpZC1zZW5zb3ItaHViLmMNCj4gQEAgLTIxMiw2ICsyMTIsNyBAQCBpbnQgc2Vu
c29yX2h1Yl9zZXRfZmVhdHVyZShzdHJ1Y3QNCj4gaGlkX3NlbnNvcl9odWJfZGV2aWNlICpoc2Rl
diwgdTMyIHJlcG9ydF9pZCwNCj4gwqAJX19zMzIgdmFsdWU7DQo+IMKgCWludCByZXQgPSAwOw0K
PiDCoA0KSSB0aGluayB5b3Ugd2FudGVkIHRoaXMgY2hhbmdlIGluwqBzZW5zb3JfaHViX2dldF9m
ZWF0dXJlDQpub3TCoHNlbnNvcl9odWJfc2V0X2ZlYXR1cmUoKS4NCg0KPiArCW1lbXNldChidWZm
ZXIsIDAsIGJ1ZmZlcl9zaXplKTsNCj4gwqAJbXV0ZXhfbG9jaygmZGF0YS0+bXV0ZXgpOw0KPiDC
oAlyZXBvcnQgPSBzZW5zb3JfaHViX3JlcG9ydChyZXBvcnRfaWQsIGhzZGV2LT5oZGV2LA0KPiBI
SURfRkVBVFVSRV9SRVBPUlQpOw0KPiDCoAlpZiAoIXJlcG9ydCB8fCAoZmllbGRfaW5kZXggPj0g
cmVwb3J0LT5tYXhmaWVsZCkpIHs=
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] hid: hid-sensor-hub: clear memory to avoid random data
@ 2016-11-08 0:55 Song Hongyan
2016-11-08 16:50 ` Pandruvada, Srinivas
0 siblings, 1 reply; 4+ messages in thread
From: Song Hongyan @ 2016-11-08 0:55 UTC (permalink / raw)
To: linux-iio; +Cc: srinivas.pandruvada, Song Hongyan
Initialize user buffer with 0s. This will avoid random data in the buffer,
when the user buffer size is bigger than the actual report size.
Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
drivers/hid/hid-sensor-hub.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 658a607..b74d954 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -252,6 +252,7 @@ int sensor_hub_get_feature(struct hid_sensor_hub_device *hsdev, u32 report_id,
int report_size;
int ret = 0;
+ memset(buffer, 0, buffer_size);
mutex_lock(&data->mutex);
report = sensor_hub_report(report_id, hsdev->hdev, HID_FEATURE_REPORT);
if (!report || (field_index >= report->maxfield) ||
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hid: hid-sensor-hub: clear memory to avoid random data
2016-11-08 0:55 Song Hongyan
@ 2016-11-08 16:50 ` Pandruvada, Srinivas
0 siblings, 0 replies; 4+ messages in thread
From: Pandruvada, Srinivas @ 2016-11-08 16:50 UTC (permalink / raw)
To: Song, Hongyan, linux-iio@vger.kernel.org
T24gVHVlLCAyMDE2LTExLTA4IGF0IDAwOjU1ICswMDAwLCBTb25nIEhvbmd5YW4gd3JvdGU6DQo+
IEluaXRpYWxpemUgdXNlciBidWZmZXIgd2l0aCAwcy4gVGhpcyB3aWxsIGF2b2lkIHJhbmRvbSBk
YXRhIGluIHRoZQ0KPiBidWZmZXIsDQo+IHdoZW4gdGhlIHVzZXIgYnVmZmVyIHNpemUgaXMgYmln
Z2VyIHRoYW4gdGhlIGFjdHVhbCByZXBvcnQgc2l6ZS4NCj4gDQpZb3Ugc2hvdWxkIGNoYW5nZSBQ
QVRDSCB2ZXJzaW9uIHdoZW4geW91IHVwZGF0ZSwgb3RoZXJ3aXNlIG1haW50YWluZXJzDQphbmQg
cmV2aWV3ZXJzIHdpbGwgbm90IGtub3cgd2hpY2ggb25lIHRvIHJldmlldyBhbmQgYXBwbHkuDQoN
ClNvIGVhY2ggdGltZSB5b3UgdXBkYXRlIGEgY2hhbmdlDQotIFVzZSAtLXN1YmplY3QtcHJlZml4
IHRvIGluY3JlbWVudCByZXZpc2lvbi4gRS5nLiAtLXN1YmplY3QtDQpwcmVmaXg9IlBBVENIIHYy
Ig0KDQotIFRoZSBjaGFuZ2UgbG9nOiBJZiB5b3UgaGF2ZSBtb3JlIHRoYW4gb25lIHBhdGNoIGlu
IGEgcGF0Y2hzZXQgdGhlbg0KdXNlIC0tY292ZXIgb3B0aW9uIGFuZCBhZGQgdG8gY292ZXIgbGV0
dGVyIGZvciBlYWNoIGluY3JlbWVudGFsDQp2ZXJzaW9uLiBJZiB5b3UgaGF2ZSBhIHNpbmdlIHBh
dGNoLCB0aGUgY2hhbmdlIGxvZyBjYW4gZ28gYmVsb3cgIi0tLSINCmJlbG93Lg0KDQpBbHNvIHVz
ZcKgLi9zY3JpcHRzL2dldF9tYWludGFpbmVyLnBsLCBzY3JpcHQgb24gdGhlIHBhdGNoIHRvIGdl
dCAidG8iDQphbmQgImNjIiBsaXN0Lg0KDQo+IFNpZ25lZC1vZmYtYnk6IFNvbmcgSG9uZ3lhbiA8
aG9uZ3lhbi5zb25nQGludGVsLmNvbT4NCj4gLS0tDQpDaGFuZ2UgbG9nDQp2MjoNCnh4eHh4eHh4
eHh4eHh4eA0KDQpUaGFua3MsDQpTcmluaXZhcw0KDQoNCj4gwqBkcml2ZXJzL2hpZC9oaWQtc2Vu
c29yLWh1Yi5jIHwgMSArDQo+IMKgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspDQo+IA0K
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9oaWQvaGlkLXNlbnNvci1odWIuYyBiL2RyaXZlcnMvaGlk
L2hpZC1zZW5zb3ItDQo+IGh1Yi5jDQo+IGluZGV4IDY1OGE2MDcuLmI3NGQ5NTQgMTAwNjQ0DQo+
IC0tLSBhL2RyaXZlcnMvaGlkL2hpZC1zZW5zb3ItaHViLmMNCj4gKysrIGIvZHJpdmVycy9oaWQv
aGlkLXNlbnNvci1odWIuYw0KPiBAQCAtMjUyLDYgKzI1Miw3IEBAIGludCBzZW5zb3JfaHViX2dl
dF9mZWF0dXJlKHN0cnVjdA0KPiBoaWRfc2Vuc29yX2h1Yl9kZXZpY2UgKmhzZGV2LCB1MzIgcmVw
b3J0X2lkLA0KPiDCoAlpbnQgcmVwb3J0X3NpemU7DQo+IMKgCWludCByZXQgPSAwOw0KPiDCoA0K
PiArCW1lbXNldChidWZmZXIsIDAsIGJ1ZmZlcl9zaXplKTsNCj4gwqAJbXV0ZXhfbG9jaygmZGF0
YS0+bXV0ZXgpOw0KPiDCoAlyZXBvcnQgPSBzZW5zb3JfaHViX3JlcG9ydChyZXBvcnRfaWQsIGhz
ZGV2LT5oZGV2LA0KPiBISURfRkVBVFVSRV9SRVBPUlQpOw0KPiDCoAlpZiAoIXJlcG9ydCB8fCAo
ZmllbGRfaW5kZXggPj0gcmVwb3J0LT5tYXhmaWVsZCkgfHw=
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-08 16:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 1:04 [PATCH] hid: hid-sensor-hub: clear memory to avoid random data Song Hongyan
2016-11-07 17:17 ` Pandruvada, Srinivas
-- strict thread matches above, loose matches on Subject: below --
2016-11-08 0:55 Song Hongyan
2016-11-08 16:50 ` Pandruvada, Srinivas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).