From: Bastien Nocera <hadess@hadess.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: linux-iio@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: acpi-als taking over from hwmon for light sensor support?
Date: Wed, 23 Nov 2016 22:07:11 +0100 [thread overview]
Message-ID: <1479935231.16940.11.camel@hadess.net> (raw)
In-Reply-To: <1479922686.5115.2.camel@chaos.suse>
On Wed, 2016-11-23 at 18:38 +0100, Jean Delvare wrote:
> On mer., 2016-11-23 at 18:21 +0100, Bastien Nocera wrote:
> > Hey,
> >
> > I did some work on iio-sensor-proxy[1] those past couple of days,
> > and
> > tested it on a MacBook Pro.
> >
> > Before that, I had written a (user-space) driver to access the
> > hwmon
> > driver's "light" value, so I was a bit surprised when I saw that
> > iio-
> > sensor-proxy was accessing the light sensor through acpi-als's IIO
> > driver instead of through the hwmon driver.
> >
> > I looked through the hwmon, iio and applesmc.c logs, and couldn't
> > find
> > any information about how the move from one to the other. Does
> > anyone
> > know?
> >
> > I'm asking because the applesmc.c hwmon driver is the only one with
> > support for the "light" property, and if that's not used anymore, I
> > might as well remove that code now (or schedule to remove it).
>
> Light sensors are out of scope of hwmon, they have nothing to do with
> hardware monitoring.
Why is there still code in applesmc.c to handle the "light" sysfs
property then?
Also, this doesn't answer my question as to when this switch happened.
I don't care one way or the other, but knowing when the switch was made
can allow me to prepare the hwmon driver in iio-sensor-proxy for
removal.
Cheers
next prev parent reply other threads:[~2016-11-23 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 17:21 acpi-als taking over from hwmon for light sensor support? Bastien Nocera
2016-11-23 17:38 ` Jean Delvare
2016-11-23 21:07 ` Bastien Nocera [this message]
2016-11-23 21:32 ` Guenter Roeck
2016-11-24 2:18 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479935231.16940.11.camel@hadess.net \
--to=hadess@hadess.net \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).