From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Jiri Kosina <jikos@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] more quirks for hid-sensor-hub
Date: Fri, 25 Nov 2016 11:03:42 +0100 [thread overview]
Message-ID: <1480068224-32224-1-git-send-email-benjamin.tissoires@redhat.com> (raw)
Hi Jiri,
here are 2 more quirks for the sensor-hub.
Srinivas, I am wondering if we can not detect those automatically.
Looking at the report_fixup, it looks like the buggy report descriptors have
a logical max of 5 (which would correspond to an enum of 0 to 5). But there
are 6 fields in the enum, so that means the report descriptor is just wrong.
Given that Microsoft's driver requires a min of 1, wouldn't it be too much
assumption to say that we need to fix the report descriptor anyway when we
see a range of 0..5 instead of 1..6?
Cheers,
Benjamin
Benjamin Tissoires (2):
HID: sensor-hub add quirk for Microsoft Surface 3
HID: sensor-hub: add quirk for Microchip MM7150
drivers/hid/hid-sensor-hub.c | 6 ++++++
1 file changed, 6 insertions(+)
--
2.7.4
next reply other threads:[~2016-11-25 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 10:03 Benjamin Tissoires [this message]
2016-11-25 10:03 ` [PATCH 1/2] HID: sensor-hub add quirk for Microsoft Surface 3 Benjamin Tissoires
2016-11-25 12:16 ` Bastien Nocera
2016-11-25 12:59 ` Benjamin Tissoires
2016-11-25 10:03 ` [PATCH 2/2] HID: sensor-hub: add quirk for Microchip MM7150 Benjamin Tissoires
2016-11-28 13:33 ` [PATCH 0/2] more quirks for hid-sensor-hub Jiri Kosina
2016-11-28 16:53 ` Srinivas Pandruvada
2016-11-29 8:19 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480068224-32224-1-git-send-email-benjamin.tissoires@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).