From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:53867 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755463AbdDRIfA (ORCPT ); Tue, 18 Apr 2017 04:35:00 -0400 Message-ID: <1492504480.2432.37.camel@pengutronix.de> Subject: Re: [PATCH v13 03/10] mux: minimal mux subsystem and gpio-based mux controller From: Philipp Zabel To: Peter Rosin Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Wolfram Sang , Rob Herring , Mark Rutland , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Jonathan Corbet , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-iio@vger.kernel.org, linux-doc@vger.kernel.org, Andrew Morton , Colin Ian King , Paul Gortmaker , kernel@pengutronix.de Date: Tue, 18 Apr 2017 10:34:40 +0200 In-Reply-To: <1492101794-13444-4-git-send-email-peda@axentia.se> References: <1492101794-13444-1-git-send-email-peda@axentia.se> <1492101794-13444-4-git-send-email-peda@axentia.se> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Hi Peter, On Thu, 2017-04-13 at 18:43 +0200, Peter Rosin wrote: [...] > diff --git a/include/linux/mux.h b/include/linux/mux.h > new file mode 100644 > index 000000000000..febdde4246df > --- /dev/null > +++ b/include/linux/mux.h [...] Consider separating mux.h into a consumer header and a driver header. Right now there is no separation between the consumer API and the framework internals. regards Philipp