* [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases
@ 2017-06-06 19:21 Jean-Francois Dagenais
2017-06-11 13:58 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Jean-Francois Dagenais @ 2017-06-06 19:21 UTC (permalink / raw)
To: michal.simek, rajnikant.bhojani, linux-iio; +Cc: jic23, Jean-Francois Dagenais
This would otherwise lead supply 7 and 8 to scale to 3V instead of
6V
Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
---
drivers/iio/adc/xilinx-ams.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
index fd4eb6d..6b3ab56 100644
--- a/drivers/iio/adc/xilinx-ams.c
+++ b/drivers/iio/adc/xilinx-ams.c
@@ -255,6 +255,7 @@ static int ams_read_raw(struct iio_dev *indio_dev,
case AMS_SUPPLY7:
case AMS_SUPPLY8:
*val = AMS_SUPPLY_SCALE_6VOLT;
+ break;
case AMS_SUPPLY9:
case AMS_SUPPLY10:
if (chan->scan_index < PS_SEQ_MAX)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases
2017-06-06 19:21 [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases Jean-Francois Dagenais
@ 2017-06-11 13:58 ` Jonathan Cameron
2017-06-21 10:53 ` Michal Simek
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2017-06-11 13:58 UTC (permalink / raw)
To: Jean-Francois Dagenais; +Cc: michal.simek, rajnikant.bhojani, linux-iio
On Tue, 6 Jun 2017 15:21:21 -0400
Jean-Francois Dagenais <jeff.dagenais@gmail.com> wrote:
> This would otherwise lead supply 7 and 8 to scale to 3V instead of
> 6V
>
> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Interesting... Driver isn't in mainline though and as far as I know
hasn't been submitted.
Jonathan
> ---
> drivers/iio/adc/xilinx-ams.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index fd4eb6d..6b3ab56 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -255,6 +255,7 @@ static int ams_read_raw(struct iio_dev *indio_dev,
> case AMS_SUPPLY7:
> case AMS_SUPPLY8:
> *val = AMS_SUPPLY_SCALE_6VOLT;
> + break;
> case AMS_SUPPLY9:
> case AMS_SUPPLY10:
> if (chan->scan_index < PS_SEQ_MAX)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases
2017-06-11 13:58 ` Jonathan Cameron
@ 2017-06-21 10:53 ` Michal Simek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Simek @ 2017-06-21 10:53 UTC (permalink / raw)
To: Jonathan Cameron, Jean-Francois Dagenais
Cc: michal.simek, rajnikant.bhojani, linux-iio
On 11.6.2017 15:58, Jonathan Cameron wrote:
> On Tue, 6 Jun 2017 15:21:21 -0400
> Jean-Francois Dagenais <jeff.dagenais@gmail.com> wrote:
>
>> This would otherwise lead supply 7 and 8 to scale to 3V instead of
>> 6V
>>
>> Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> Interesting... Driver isn't in mainline though and as far as I know
> hasn't been submitted.
It is in Xilinx tree. I hope that this will be send out soon for review.
Thanks,
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-21 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-06 19:21 [PATCH] iio: adc: xilinx-ams: add missing break in AMS_SUPPLY[78] cases Jean-Francois Dagenais
2017-06-11 13:58 ` Jonathan Cameron
2017-06-21 10:53 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).