[PATCH 0/2 RESEND] fix kernel-docs for struct iio_trigger

[PATCH 0/2 RESEND] fix kernel-docs for struct iio_trigger

[Tobin C. Harding]

This set is a re-spin of

	[PATCH] iio: add kernel-doc '@owner'

Patch 1 is the original patch. Adds a kernel-doc description for field
@owner clearing a sphinx build warning when building kernel documentation.

Patch 2 adds field identifier for @use_count. Currently this field has a
description but lacks a field identifier.

Tobin C. Harding (2):
  iio: add kernel-doc for field @owner
  iio: add field identifier for @use_count kernel-doc

 include/linux/iio/trigger.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/2 RESEND] iio: add kernel-doc for field @owner

[Tobin C. Harding]

When building kernel documentation sphinx emits the following warning

	warning: No description found for parameter 'owner'

Add description for struct member 'owner'.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 include/linux/iio/trigger.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 7d5e44518379..390789d43369 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -43,6 +43,7 @@ struct iio_trigger_ops {
 /**
  * struct iio_trigger - industrial I/O trigger device
  * @ops:		[DRIVER] operations structure
+ * @owner:		[INTERN] owner of this driver module
  * @id:			[INTERN] unique id number
  * @name:		[DRIVER] unique name
  * @dev:		[DRIVER] associated device (if relevant)
-- 
2.7.4

[PATCH 2/2 RESEND] iio: add field identifier for @use_count kernel-doc

[Tobin C. Harding]

Kernel-doc for @use_count does not currently have a field
identifier. All the rest of the fields do. @use_count is used internally
and should not be accessed directly by the driver so it should be
marked as so.

Add [INTERN] identifier to @use_count field.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
---
 include/linux/iio/trigger.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
index 390789d43369..b19b7204ef84 100644
--- a/include/linux/iio/trigger.h
+++ b/include/linux/iio/trigger.h
@@ -49,7 +49,7 @@ struct iio_trigger_ops {
  * @dev:		[DRIVER] associated device (if relevant)
  * @list:		[INTERN] used in maintenance of global trigger list
  * @alloc_list:		[DRIVER] used for driver specific trigger list
- * @use_count:		use count for the trigger
+ * @use_count:		[INTERN] use count for the trigger.
  * @subirq_chip:	[INTERN] associate 'virtual' irq chip.
  * @subirq_base:	[INTERN] base number for irqs provided by trigger.
  * @subirqs:		[INTERN] information about the 'child' irqs.
-- 
2.7.4

Re: [PATCH 1/2 RESEND] iio: add kernel-doc for field @owner

[Jonathan Cameron]

On Sat,  6 Jan 2018 12:31:57 +1100
"Tobin C. Harding" <me@tobin.cc> wrote:

> When building kernel documentation sphinx emits the following warning
> 
> 	warning: No description found for parameter 'owner'
> 
> Add description for struct member 'owner'.
> 
> Signed-off-by: Tobin C. Harding <me@tobin.cc>

This isn't a resend.  It's a version 2.  Please resend with the
changes from v1 clearly stated.

If you were resending you should say why as well in the cover letter!

Jonathan

> ---
>  include/linux/iio/trigger.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/iio/trigger.h b/include/linux/iio/trigger.h
> index 7d5e44518379..390789d43369 100644
> --- a/include/linux/iio/trigger.h
> +++ b/include/linux/iio/trigger.h
> @@ -43,6 +43,7 @@ struct iio_trigger_ops {
>  /**
>   * struct iio_trigger - industrial I/O trigger device
>   * @ops:		[DRIVER] operations structure
> + * @owner:		[INTERN] owner of this driver module
>   * @id:			[INTERN] unique id number
>   * @name:		[DRIVER] unique name
>   * @dev:		[DRIVER] associated device (if relevant)

Re: [PATCH 1/2 RESEND] iio: add kernel-doc for field @owner

[Tobin C. Harding]

On Sat, Jan 06, 2018 at 01:00:53PM +0000, Jonathan Cameron wrote:
> On Sat,  6 Jan 2018 12:31:57 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
> 
> > When building kernel documentation sphinx emits the following warning
> > 
> > 	warning: No description found for parameter 'owner'
> > 
> > Add description for struct member 'owner'.
> > 
> > Signed-off-by: Tobin C. Harding <me@tobin.cc>
> 
> This isn't a resend.  It's a version 2.  Please resend with the
> changes from v1 clearly stated.

Oh, you are right it should have been a version 2. The 'resend' referred
to the single cover letter I sent (forgot --to-cover --cc-cover flags to
git send-email).

> If you were resending you should say why as well in the cover letter!

My mistake, sloppy work.

> Jonathan

Thanks for your patience. Will fix up and re-send (as v3 ;)

thanks,
Tobin