From: venkat.prashanth2498@gmail.com
To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org
Cc: knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Subject: [PATCH] adc:cpcap-adc: Fix IRQ flags for using threaded handler
Date: Thu, 11 Jan 2018 12:41:00 +0530 [thread overview]
Message-ID: <1515654660-9054-1-git-send-email-venkat.prashanth2498@gmail.com> (raw)
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Mark the request with ONESHOT using IRQF_ONESHOT.
Semantic patch information:
threaded IRQs without a primary handler need to be
requested with IRQF_ONESHOT, otherwise the request
will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
drivers/iio/adc/cpcap-adc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/cpcap-adc.c b/drivers/iio/adc/cpcap-adc.c
index 9ad6042..b73fa46 100644
--- a/drivers/iio/adc/cpcap-adc.c
+++ b/drivers/iio/adc/cpcap-adc.c
@@ -1015,9 +1015,9 @@ static int cpcap_adc_probe(struct platform_device *pdev)
return -ENODEV;
error = devm_request_threaded_irq(&pdev->dev, ddata->irq, NULL,
- cpcap_adc_irq_thread,
- IRQF_TRIGGER_NONE,
- "cpcap-adc", indio_dev);
+ cpcap_adc_irq_thread,
+ IRQF_TRIGGER_NONE | IRQF_ONESHOT,
+ "cpcap-adc", indio_dev);
if (error) {
dev_err(&pdev->dev, "could not get irq: %i\n",
error);
--
1.9.1
next reply other threads:[~2018-01-11 7:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 7:11 venkat.prashanth2498 [this message]
2018-01-14 12:27 ` [PATCH] adc:cpcap-adc: Fix IRQ flags for using threaded handler Jonathan Cameron
2018-01-19 15:10 ` Tony Lindgren
2018-01-20 16:05 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515654660-9054-1-git-send-email-venkat.prashanth2498@gmail.com \
--to=venkat.prashanth2498@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).