From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:44014 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbeBRLiF (ORCPT ); Sun, 18 Feb 2018 06:38:05 -0500 Received: by mail-pf0-f193.google.com with SMTP id z14so171334pfe.10 for ; Sun, 18 Feb 2018 03:38:04 -0800 (PST) Message-ID: <1518953877.19751.3.camel@gmail.com> Subject: Re: [PATCH 1/3] Staging: iio: adis16209: Use SPDX identifier From: Shreeya Patel To: Himanshu Jha Cc: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, daniel.baluta@nxp.com Date: Sun, 18 Feb 2018 17:07:57 +0530 In-Reply-To: <20180218113138.GA4039@himanshu-Vostro-3559> References: <6771b95bbfb8301724086dba4d92df6a6b11d6f7.1518883035.git.shreeya.patel23498@gmail.com> <20180218113138.GA4039@himanshu-Vostro-3559> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On Sun, 2018-02-18 at 17:01 +0530, Himanshu Jha wrote: > Hi Shreeya, > Hi Himanshu, > On Sat, Feb 17, 2018 at 09:34:56PM +0530, Shreeya Patel wrote: > > > > Use SPDX identifier format instead of GPLv2. Also rearrange the > > headers in alphabetical order. > > > > Signed-off-by: Shreeya Patel > > --- > >  drivers/staging/iio/accel/adis16209.c | 7 +++---- > >  1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/staging/iio/accel/adis16209.c > > b/drivers/staging/iio/accel/adis16209.c > > index 7fcef9a..e3d9f80 100644 > > --- a/drivers/staging/iio/accel/adis16209.c > > +++ b/drivers/staging/iio/accel/adis16209.c > > @@ -1,19 +1,18 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > >  /* > >   * ADIS16209 Dual-Axis Digital Inclinometer and Accelerometer > >   * > >   * Copyright 2010 Analog Devices Inc. > > - * > > - * Licensed under the GPL-2 or later. > I see that you too are doing similar cleanup which I did a while ago > https://lkml.org/lkml/2018/2/12/255 Yes, Jonathan suggested me to work on adis16209. Your patches were quite useful for me :) > where I got some update suggestions for the patch series. It would be > great if you could update this patch series consistent with the > reviewers. > > For eg: in this patch you changed  > > +// SPDX-License-Identifier: GPL-2.0+ > > and therefore > > MODULE_LICENSE("GPL v2"); > > should also be changed to  > > MODULE_LICENSE("GPL");  > > as explained by Philippe Ombredanne to me in my patch series. Great. I'll make the necessary changes. > > I am not sure if you're subscribed to the IIO mailing list but you > can find > all the update suggestions from the above link. :) Thanks for your suggestions  >