* [PATCH] staging: iio: ad5933: merge ring init function into probe function
@ 2018-02-16 12:09 Alexandru Ardelean
2018-02-24 12:18 ` Jonathan Cameron
0 siblings, 1 reply; 7+ messages in thread
From: Alexandru Ardelean @ 2018-02-16 12:09 UTC (permalink / raw)
To: linux-iio; +Cc: michael.hennerich, lars, Alexandru Ardelean
This is a small cleanup of the driver's init code.
It does not fix anything.
The `devm_iio_kfifo_allocate()` function is used instead of
`iio_kfifo_allocate()`. This removes the need for explicit deallocation of
the driver's iio_buffer, which will now be handled via
`iio_device_unregister()`.
The `setup_ops` assignment has been moved into the `ad5933_probe()` call,
since it's a one-liner.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
Note: this change is based on top of `fixes-togreg-post-rc1` branch which
contains commit (7d2b8e6aaf9: staging: iio: ad5933: switch buffer mode to
software)
drivers/staging/iio/impedance-analyzer/ad5933.c | 35 +++++++------------------
1 file changed, 10 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
index 3bcf49466361..1cab67b3a81e 100644
--- a/drivers/staging/iio/impedance-analyzer/ad5933.c
+++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
@@ -635,22 +635,6 @@ static const struct iio_buffer_setup_ops ad5933_ring_setup_ops = {
.postdisable = ad5933_ring_postdisable,
};
-static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
-{
- struct iio_buffer *buffer;
-
- buffer = iio_kfifo_allocate();
- if (!buffer)
- return -ENOMEM;
-
- iio_device_attach_buffer(indio_dev, buffer);
-
- /* Ring buffer functions - here trigger setup related */
- indio_dev->setup_ops = &ad5933_ring_setup_ops;
-
- return 0;
-}
-
static void ad5933_work(struct work_struct *work)
{
struct ad5933_state *st = container_of(work,
@@ -714,12 +698,19 @@ static int ad5933_probe(struct i2c_client *client,
int ret, voltage_uv = 0;
struct ad5933_platform_data *pdata = dev_get_platdata(&client->dev);
struct ad5933_state *st;
+ struct iio_buffer *buffer;
struct iio_dev *indio_dev;
indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
if (!indio_dev)
return -ENOMEM;
+ buffer = devm_iio_kfifo_allocate(&client->dev);
+ if (!buffer)
+ return -ENOMEM;
+
+ iio_device_attach_buffer(indio_dev, buffer);
+
st = iio_priv(indio_dev);
i2c_set_clientdata(client, indio_dev);
st->client = client;
@@ -763,23 +754,18 @@ static int ad5933_probe(struct i2c_client *client,
indio_dev->modes = (INDIO_BUFFER_SOFTWARE | INDIO_DIRECT_MODE);
indio_dev->channels = ad5933_channels;
indio_dev->num_channels = ARRAY_SIZE(ad5933_channels);
-
- ret = ad5933_register_ring_funcs_and_init(indio_dev);
- if (ret)
- goto error_disable_reg;
+ indio_dev->setup_ops = &ad5933_ring_setup_ops;
ret = ad5933_setup(st);
if (ret)
- goto error_unreg_ring;
+ goto error_disable_reg;
ret = iio_device_register(indio_dev);
if (ret)
- goto error_unreg_ring;
+ goto error_disable_reg;
return 0;
-error_unreg_ring:
- iio_kfifo_free(indio_dev->buffer);
error_disable_reg:
regulator_disable(st->reg);
@@ -792,7 +778,6 @@ static int ad5933_remove(struct i2c_client *client)
struct ad5933_state *st = iio_priv(indio_dev);
iio_device_unregister(indio_dev);
- iio_kfifo_free(indio_dev->buffer);
regulator_disable(st->reg);
return 0;
--
2.14.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-02-16 12:09 [PATCH] staging: iio: ad5933: merge ring init function into probe function Alexandru Ardelean
@ 2018-02-24 12:18 ` Jonathan Cameron
2018-02-26 7:44 ` Ardelean, Alexandru
2018-03-13 9:01 ` Ardelean, Alexandru
0 siblings, 2 replies; 7+ messages in thread
From: Jonathan Cameron @ 2018-02-24 12:18 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-iio, michael.hennerich, lars
On Fri, 16 Feb 2018 14:09:15 +0200
Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> This is a small cleanup of the driver's init code.
> It does not fix anything.
>
> The `devm_iio_kfifo_allocate()` function is used instead of
> `iio_kfifo_allocate()`. This removes the need for explicit deallocation of
> the driver's iio_buffer, which will now be handled via
> `iio_device_unregister()`.
>
> The `setup_ops` assignment has been moved into the `ad5933_probe()` call,
> since it's a one-liner.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
>
> Note: this change is based on top of `fixes-togreg-post-rc1` branch which
> contains commit (7d2b8e6aaf9: staging: iio: ad5933: switch buffer mode to
> software)
It will take a few weeks for that to get to my togreg branch so please
do remind me if it has and I seem to have forgotten this!
Jonathan
>
> drivers/staging/iio/impedance-analyzer/ad5933.c | 35 +++++++------------------
> 1 file changed, 10 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3bcf49466361..1cab67b3a81e 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -635,22 +635,6 @@ static const struct iio_buffer_setup_ops ad5933_ring_setup_ops = {
> .postdisable = ad5933_ring_postdisable,
> };
>
> -static int ad5933_register_ring_funcs_and_init(struct iio_dev *indio_dev)
> -{
> - struct iio_buffer *buffer;
> -
> - buffer = iio_kfifo_allocate();
> - if (!buffer)
> - return -ENOMEM;
> -
> - iio_device_attach_buffer(indio_dev, buffer);
> -
> - /* Ring buffer functions - here trigger setup related */
> - indio_dev->setup_ops = &ad5933_ring_setup_ops;
> -
> - return 0;
> -}
> -
> static void ad5933_work(struct work_struct *work)
> {
> struct ad5933_state *st = container_of(work,
> @@ -714,12 +698,19 @@ static int ad5933_probe(struct i2c_client *client,
> int ret, voltage_uv = 0;
> struct ad5933_platform_data *pdata = dev_get_platdata(&client->dev);
> struct ad5933_state *st;
> + struct iio_buffer *buffer;
> struct iio_dev *indio_dev;
>
> indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*st));
> if (!indio_dev)
> return -ENOMEM;
>
> + buffer = devm_iio_kfifo_allocate(&client->dev);
> + if (!buffer)
> + return -ENOMEM;
> +
> + iio_device_attach_buffer(indio_dev, buffer);
> +
> st = iio_priv(indio_dev);
> i2c_set_clientdata(client, indio_dev);
> st->client = client;
> @@ -763,23 +754,18 @@ static int ad5933_probe(struct i2c_client *client,
> indio_dev->modes = (INDIO_BUFFER_SOFTWARE | INDIO_DIRECT_MODE);
> indio_dev->channels = ad5933_channels;
> indio_dev->num_channels = ARRAY_SIZE(ad5933_channels);
> -
> - ret = ad5933_register_ring_funcs_and_init(indio_dev);
> - if (ret)
> - goto error_disable_reg;
> + indio_dev->setup_ops = &ad5933_ring_setup_ops;
>
> ret = ad5933_setup(st);
> if (ret)
> - goto error_unreg_ring;
> + goto error_disable_reg;
>
> ret = iio_device_register(indio_dev);
> if (ret)
> - goto error_unreg_ring;
> + goto error_disable_reg;
>
> return 0;
>
> -error_unreg_ring:
> - iio_kfifo_free(indio_dev->buffer);
> error_disable_reg:
> regulator_disable(st->reg);
>
> @@ -792,7 +778,6 @@ static int ad5933_remove(struct i2c_client *client)
> struct ad5933_state *st = iio_priv(indio_dev);
>
> iio_device_unregister(indio_dev);
> - iio_kfifo_free(indio_dev->buffer);
> regulator_disable(st->reg);
>
> return 0;
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-02-24 12:18 ` Jonathan Cameron
@ 2018-02-26 7:44 ` Ardelean, Alexandru
2018-02-26 10:47 ` Daniel Baluta
2018-03-13 9:01 ` Ardelean, Alexandru
1 sibling, 1 reply; 7+ messages in thread
From: Ardelean, Alexandru @ 2018-02-26 7:44 UTC (permalink / raw)
To: jic23@jic23.retrosnub.co.uk
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, Hennerich, Michael
T24gU2F0LCAyMDE4LTAyLTI0IGF0IDEyOjE4ICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiBGcmksIDE2IEZlYiAyMDE4IDE0OjA5OjE1ICswMjAwDQo+IEFsZXhhbmRydSBBcmRl
bGVhbiA8YWxleGFuZHJ1LmFyZGVsZWFuQGFuYWxvZy5jb20+IHdyb3RlOg0KPiANCj4gPiBUaGlz
IGlzIGEgc21hbGwgY2xlYW51cCBvZiB0aGUgZHJpdmVyJ3MgaW5pdCBjb2RlLg0KPiA+IEl0IGRv
ZXMgbm90IGZpeCBhbnl0aGluZy4NCj4gPiANCj4gPiBUaGUgYGRldm1faWlvX2tmaWZvX2FsbG9j
YXRlKClgIGZ1bmN0aW9uIGlzIHVzZWQgaW5zdGVhZCBvZg0KPiA+IGBpaW9fa2ZpZm9fYWxsb2Nh
dGUoKWAuICBUaGlzIHJlbW92ZXMgdGhlIG5lZWQgZm9yIGV4cGxpY2l0IGRlYWxsb2NhdGlvbiBv
Zg0KPiA+IHRoZSBkcml2ZXIncyBpaW9fYnVmZmVyLCB3aGljaCB3aWxsIG5vdyBiZSBoYW5kbGVk
IHZpYQ0KPiA+IGBpaW9fZGV2aWNlX3VucmVnaXN0ZXIoKWAuDQo+ID4gDQo+ID4gVGhlIGBzZXR1
cF9vcHNgIGFzc2lnbm1lbnQgaGFzIGJlZW4gbW92ZWQgaW50byB0aGUgYGFkNTkzM19wcm9iZSgp
YCBjYWxsLA0KPiA+IHNpbmNlIGl0J3MgYSBvbmUtbGluZXIuDQo+ID4gDQo+ID4gU2lnbmVkLW9m
Zi1ieTogQWxleGFuZHJ1IEFyZGVsZWFuIDxhbGV4YW5kcnUuYXJkZWxlYW5AYW5hbG9nLmNvbT4N
Cj4gPiAtLS0NCj4gPiANCj4gPiBOb3RlOiB0aGlzIGNoYW5nZSBpcyBiYXNlZCBvbiB0b3Agb2Yg
YGZpeGVzLXRvZ3JlZy1wb3N0LXJjMWAgYnJhbmNoIHdoaWNoDQo+ID4gY29udGFpbnMgY29tbWl0
ICg3ZDJiOGU2YWFmOTogc3RhZ2luZzogaWlvOiBhZDU5MzM6IHN3aXRjaCBidWZmZXIgbW9kZSB0
bw0KPiA+IHNvZnR3YXJlKQ0KPiANCj4gSXQgd2lsbCB0YWtlIGEgZmV3IHdlZWtzIGZvciB0aGF0
IHRvIGdldCB0byBteSB0b2dyZWcgYnJhbmNoIHNvIHBsZWFzZQ0KPiBkbyByZW1pbmQgbWUgaWYg
aXQgaGFzIGFuZCBJIHNlZW0gdG8gaGF2ZSBmb3Jnb3R0ZW4gdGhpcyENCj4gDQo+IEpvbmF0aGFu
DQoNCkknbSBhIGJpdCBuZXcgdG8gaG93IHRoaW5ncyBwcm9ncmVzcyBpbiB0aGUgaWlvIHN1YnRy
ZWUuDQpbQ3VyaW91c10gSXMgdGhlcmUgYSByZWNvbW1lbmRlZCBicmFuY2ggdGhhdCBpcyByZWd1
bGFybHkgdXBkYXRlZCB3aXRoIGFjY2VwdGVkDQpwYXRjaGVzID8NCk9yIHdoaWNoIGJyYW5jaGVz
IGRvIEkgbmVlZCB0byByZWJhc2Ugd2hlbiBzdWJtaXR0aW5nIG90aGVyIHBhdGNoZXMgPw0KDQpS
ZWFzb24gaXM6IHRvIHJlYmFzZSBvdGhlciBwYXRjaGVzIG9uY2UgYSBwYXRjaCBhZnRlciBoYXMg
YmVlbiBhY2NlcHRlZC4gVGhhdCdzDQphbHNvIGZvciBjYXNlcyB3aGVuIHN1Ym1pdHRpbmcgcGF0
Y2hlcyBsaWtlIHRoaXMgb25lIFtzbWFsbCB1cGRhdGVzL2NsZWFudXBzXS4NClJlYmFzaW5nIG9m
dGVuLCB3b3VsZCBhbGxvdyBmb3IgcGF0Y2hlcyBbbGlrZSB0aGlzXSB0byBiZSBzZW50IGEgYml0
IG1vcmUNCmZyZXF1ZW50bHkuDQpJJ20gYXNzdW1pbmcgdGhhdCB0aGUgY3VycmVudCB3YXktb2Yt
ZG9pbmctdGhpbmdzIGlzIGdlYXJlZCB0byBvcmdhbml6aW5nDQpwYXRjaGVzIHRvIGJlIHNlbnQg
dG8gR3JlZy4NCg0KSSdtIG5vdCBhc2tpbmcgZm9yIHN1Y2ggYSBicmFuY2ggdG8gYmUgY3JlYXRl
ZCBbb3IgYW55dGhpbmddLg0KSnVzdCB3YW50IHRvIGdldCBhIGZlZWwgZm9yIGhvdyB0aGluZ3Mg
d29yaywgc28gdGhhdCBJIGNhbiBhZGFwdCBob3cgSSBvcmdhbml6ZQ0KbXlzZWxmIFt3aXRoIHN1
Ym1pc3Npb24gb2YgcGF0Y2hlc10uDQoNCkFsZXgNCg0KPiANCj4gPiANCj4gPiAgZHJpdmVycy9z
dGFnaW5nL2lpby9pbXBlZGFuY2UtYW5hbHl6ZXIvYWQ1OTMzLmMgfCAzNSArKysrKysrLS0tLS0t
LS0tLS0tLS0tLS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCAyNSBk
ZWxldGlvbnMoLSkNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL2lpby9p
bXBlZGFuY2UtYW5hbHl6ZXIvYWQ1OTMzLmMgYi9kcml2ZXJzL3N0YWdpbmcvaWlvL2ltcGVkYW5j
ZS1hbmFseXplci9hZDU5MzMuYw0KPiA+IGluZGV4IDNiY2Y0OTQ2NjM2MS4uMWNhYjY3YjNhODFl
IDEwMDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9paW8vaW1wZWRhbmNlLWFuYWx5emVy
L2FkNTkzMy5jDQo+ID4gKysrIGIvZHJpdmVycy9zdGFnaW5nL2lpby9pbXBlZGFuY2UtYW5hbHl6
ZXIvYWQ1OTMzLmMNCj4gPiBAQCAtNjM1LDIyICs2MzUsNiBAQCBzdGF0aWMgY29uc3Qgc3RydWN0
IGlpb19idWZmZXJfc2V0dXBfb3BzIGFkNTkzM19yaW5nX3NldHVwX29wcyA9IHsNCj4gPiAgCS5w
b3N0ZGlzYWJsZSA9IGFkNTkzM19yaW5nX3Bvc3RkaXNhYmxlLA0KPiA+ICB9Ow0KPiA+ICANCj4g
PiAtc3RhdGljIGludCBhZDU5MzNfcmVnaXN0ZXJfcmluZ19mdW5jc19hbmRfaW5pdChzdHJ1Y3Qg
aWlvX2RldiAqaW5kaW9fZGV2KQ0KPiA+IC17DQo+ID4gLQlzdHJ1Y3QgaWlvX2J1ZmZlciAqYnVm
ZmVyOw0KPiA+IC0NCj4gPiAtCWJ1ZmZlciA9IGlpb19rZmlmb19hbGxvY2F0ZSgpOw0KPiA+IC0J
aWYgKCFidWZmZXIpDQo+ID4gLQkJcmV0dXJuIC1FTk9NRU07DQo+ID4gLQ0KPiA+IC0JaWlvX2Rl
dmljZV9hdHRhY2hfYnVmZmVyKGluZGlvX2RldiwgYnVmZmVyKTsNCj4gPiAtDQo+ID4gLQkvKiBS
aW5nIGJ1ZmZlciBmdW5jdGlvbnMgLSBoZXJlIHRyaWdnZXIgc2V0dXAgcmVsYXRlZCAqLw0KPiA+
IC0JaW5kaW9fZGV2LT5zZXR1cF9vcHMgPSAmYWQ1OTMzX3Jpbmdfc2V0dXBfb3BzOw0KPiA+IC0N
Cj4gPiAtCXJldHVybiAwOw0KPiA+IC19DQo+ID4gLQ0KPiA+ICBzdGF0aWMgdm9pZCBhZDU5MzNf
d29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspDQo+ID4gIHsNCj4gPiAgCXN0cnVjdCBhZDU5
MzNfc3RhdGUgKnN0ID0gY29udGFpbmVyX29mKHdvcmssDQo+ID4gQEAgLTcxNCwxMiArNjk4LDE5
IEBAIHN0YXRpYyBpbnQgYWQ1OTMzX3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsDQo+
ID4gIAlpbnQgcmV0LCB2b2x0YWdlX3V2ID0gMDsNCj4gPiAgCXN0cnVjdCBhZDU5MzNfcGxhdGZv
cm1fZGF0YSAqcGRhdGEgPSBkZXZfZ2V0X3BsYXRkYXRhKCZjbGllbnQtPmRldik7DQo+ID4gIAlz
dHJ1Y3QgYWQ1OTMzX3N0YXRlICpzdDsNCj4gPiArCXN0cnVjdCBpaW9fYnVmZmVyICpidWZmZXI7
DQo+ID4gIAlzdHJ1Y3QgaWlvX2RldiAqaW5kaW9fZGV2Ow0KPiA+ICANCj4gPiAgCWluZGlvX2Rl
diA9IGRldm1faWlvX2RldmljZV9hbGxvYygmY2xpZW50LT5kZXYsIHNpemVvZigqc3QpKTsNCj4g
PiAgCWlmICghaW5kaW9fZGV2KQ0KPiA+ICAJCXJldHVybiAtRU5PTUVNOw0KPiA+ICANCj4gPiAr
CWJ1ZmZlciA9IGRldm1faWlvX2tmaWZvX2FsbG9jYXRlKCZjbGllbnQtPmRldik7DQo+ID4gKwlp
ZiAoIWJ1ZmZlcikNCj4gPiArCQlyZXR1cm4gLUVOT01FTTsNCj4gPiArDQo+ID4gKwlpaW9fZGV2
aWNlX2F0dGFjaF9idWZmZXIoaW5kaW9fZGV2LCBidWZmZXIpOw0KPiA+ICsNCj4gPiAgCXN0ID0g
aWlvX3ByaXYoaW5kaW9fZGV2KTsNCj4gPiAgCWkyY19zZXRfY2xpZW50ZGF0YShjbGllbnQsIGlu
ZGlvX2Rldik7DQo+ID4gIAlzdC0+Y2xpZW50ID0gY2xpZW50Ow0KPiA+IEBAIC03NjMsMjMgKzc1
NCwxOCBAQCBzdGF0aWMgaW50IGFkNTkzM19wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50
LA0KPiA+ICAJaW5kaW9fZGV2LT5tb2RlcyA9IChJTkRJT19CVUZGRVJfU09GVFdBUkUgfCBJTkRJ
T19ESVJFQ1RfTU9ERSk7DQo+ID4gIAlpbmRpb19kZXYtPmNoYW5uZWxzID0gYWQ1OTMzX2NoYW5u
ZWxzOw0KPiA+ICAJaW5kaW9fZGV2LT5udW1fY2hhbm5lbHMgPSBBUlJBWV9TSVpFKGFkNTkzM19j
aGFubmVscyk7DQo+ID4gLQ0KPiA+IC0JcmV0ID0gYWQ1OTMzX3JlZ2lzdGVyX3JpbmdfZnVuY3Nf
YW5kX2luaXQoaW5kaW9fZGV2KTsNCj4gPiAtCWlmIChyZXQpDQo+ID4gLQkJZ290byBlcnJvcl9k
aXNhYmxlX3JlZzsNCj4gPiArCWluZGlvX2Rldi0+c2V0dXBfb3BzID0gJmFkNTkzM19yaW5nX3Nl
dHVwX29wczsNCj4gPiAgDQo+ID4gIAlyZXQgPSBhZDU5MzNfc2V0dXAoc3QpOw0KPiA+ICAJaWYg
KHJldCkNCj4gPiAtCQlnb3RvIGVycm9yX3VucmVnX3Jpbmc7DQo+ID4gKwkJZ290byBlcnJvcl9k
aXNhYmxlX3JlZzsNCj4gPiAgDQo+ID4gIAlyZXQgPSBpaW9fZGV2aWNlX3JlZ2lzdGVyKGluZGlv
X2Rldik7DQo+ID4gIAlpZiAocmV0KQ0KPiA+IC0JCWdvdG8gZXJyb3JfdW5yZWdfcmluZzsNCj4g
PiArCQlnb3RvIGVycm9yX2Rpc2FibGVfcmVnOw0KPiA+ICANCj4gPiAgCXJldHVybiAwOw0KPiA+
ICANCj4gPiAtZXJyb3JfdW5yZWdfcmluZzoNCj4gPiAtCWlpb19rZmlmb19mcmVlKGluZGlvX2Rl
di0+YnVmZmVyKTsNCj4gPiAgZXJyb3JfZGlzYWJsZV9yZWc6DQo+ID4gIAlyZWd1bGF0b3JfZGlz
YWJsZShzdC0+cmVnKTsNCj4gPiAgDQo+ID4gQEAgLTc5Miw3ICs3NzgsNiBAQCBzdGF0aWMgaW50
IGFkNTkzM19yZW1vdmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCkNCj4gPiAgCXN0cnVjdCBh
ZDU5MzNfc3RhdGUgKnN0ID0gaWlvX3ByaXYoaW5kaW9fZGV2KTsNCj4gPiAgDQo+ID4gIAlpaW9f
ZGV2aWNlX3VucmVnaXN0ZXIoaW5kaW9fZGV2KTsNCj4gPiAtCWlpb19rZmlmb19mcmVlKGluZGlv
X2Rldi0+YnVmZmVyKTsNCj4gPiAgCXJlZ3VsYXRvcl9kaXNhYmxlKHN0LT5yZWcpOw0KPiA+ICAN
Cj4gPiAgCXJldHVybiAwOw0KPiANCj4g
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-02-26 7:44 ` Ardelean, Alexandru
@ 2018-02-26 10:47 ` Daniel Baluta
2018-03-03 15:00 ` Jonathan Cameron
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Baluta @ 2018-02-26 10:47 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: jic23@jic23.retrosnub.co.uk, lars@metafoo.de,
linux-iio@vger.kernel.org, Hennerich, Michael
On Mon, Feb 26, 2018 at 9:44 AM, Ardelean, Alexandru
<alexandru.Ardelean@analog.com> wrote:
> On Sat, 2018-02-24 at 12:18 +0000, Jonathan Cameron wrote:
>> On Fri, 16 Feb 2018 14:09:15 +0200
>> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>>
>> > This is a small cleanup of the driver's init code.
>> > It does not fix anything.
>> >
>> > The `devm_iio_kfifo_allocate()` function is used instead of
>> > `iio_kfifo_allocate()`. This removes the need for explicit deallocation of
>> > the driver's iio_buffer, which will now be handled via
>> > `iio_device_unregister()`.
>> >
>> > The `setup_ops` assignment has been moved into the `ad5933_probe()` call,
>> > since it's a one-liner.
>> >
>> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>> > ---
>> >
>> > Note: this change is based on top of `fixes-togreg-post-rc1` branch which
>> > contains commit (7d2b8e6aaf9: staging: iio: ad5933: switch buffer mode to
>> > software)
>>
>> It will take a few weeks for that to get to my togreg branch so please
>> do remind me if it has and I seem to have forgotten this!
>>
>> Jonathan
>
> I'm a bit new to how things progress in the iio subtree.
> [Curious] Is there a recommended branch that is regularly updated with accepted
> patches ?
> Or which branches do I need to rebase when submitting other patches ?
Salut Alexandru,
You can use the togreg branch of iio tree.
thanks,
Daniel.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-02-26 10:47 ` Daniel Baluta
@ 2018-03-03 15:00 ` Jonathan Cameron
2018-03-05 7:24 ` Ardelean, Alexandru
0 siblings, 1 reply; 7+ messages in thread
From: Jonathan Cameron @ 2018-03-03 15:00 UTC (permalink / raw)
To: Daniel Baluta
Cc: Ardelean, Alexandru, lars@metafoo.de, linux-iio@vger.kernel.org,
Hennerich, Michael
On Mon, 26 Feb 2018 12:47:28 +0200
Daniel Baluta <daniel.baluta@gmail.com> wrote:
> On Mon, Feb 26, 2018 at 9:44 AM, Ardelean, Alexandru
> <alexandru.Ardelean@analog.com> wrote:
> > On Sat, 2018-02-24 at 12:18 +0000, Jonathan Cameron wrote:
> >> On Fri, 16 Feb 2018 14:09:15 +0200
> >> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
> >>
> >> > This is a small cleanup of the driver's init code.
> >> > It does not fix anything.
> >> >
> >> > The `devm_iio_kfifo_allocate()` function is used instead of
> >> > `iio_kfifo_allocate()`. This removes the need for explicit deallocation of
> >> > the driver's iio_buffer, which will now be handled via
> >> > `iio_device_unregister()`.
> >> >
> >> > The `setup_ops` assignment has been moved into the `ad5933_probe()` call,
> >> > since it's a one-liner.
> >> >
> >> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> >> > ---
> >> >
> >> > Note: this change is based on top of `fixes-togreg-post-rc1` branch which
> >> > contains commit (7d2b8e6aaf9: staging: iio: ad5933: switch buffer mode to
> >> > software)
> >>
> >> It will take a few weeks for that to get to my togreg branch so please
> >> do remind me if it has and I seem to have forgotten this!
> >>
> >> Jonathan
> >
> > I'm a bit new to how things progress in the iio subtree.
> > [Curious] Is there a recommended branch that is regularly updated with accepted
> > patches ?
> > Or which branches do I need to rebase when submitting other patches ?
>
>
> Salut Alexandru,
>
> You can use the togreg branch of iio tree.
That tends to only get updated fairly infrequently except when I'm doing
a pull request but that is 'in theory' the right branch to use.
In practice, the only reason I'd change things in the testing branch
is a build failure or a comment from someone suggesting a reason to pull
a patch. Mind you I've been pretty bad at remembering to push that out
as well recently :( I only find out when I realise I didn't get a build
report from 0-day when I get to work on Monday.
Jonathan
>
> thanks,
> Daniel.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-03-03 15:00 ` Jonathan Cameron
@ 2018-03-05 7:24 ` Ardelean, Alexandru
0 siblings, 0 replies; 7+ messages in thread
From: Ardelean, Alexandru @ 2018-03-05 7:24 UTC (permalink / raw)
To: daniel.baluta@gmail.com, jic23@jic23.retrosnub.co.uk
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, Hennerich, Michael
T24gU2F0LCAyMDE4LTAzLTAzIGF0IDE1OjAwICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiBNb24sIDI2IEZlYiAyMDE4IDEyOjQ3OjI4ICswMjAwDQo+IERhbmllbCBCYWx1dGEg
PGRhbmllbC5iYWx1dGFAZ21haWwuY29tPiB3cm90ZToNCj4gDQo+ID4gT24gTW9uLCBGZWIgMjYs
IDIwMTggYXQgOTo0NCBBTSwgQXJkZWxlYW4sIEFsZXhhbmRydQ0KPiA+IDxhbGV4YW5kcnUuQXJk
ZWxlYW5AYW5hbG9nLmNvbT4gd3JvdGU6DQo+ID4gPiBPbiBTYXQsIDIwMTgtMDItMjQgYXQgMTI6
MTggKzAwMDAsIEpvbmF0aGFuIENhbWVyb24gd3JvdGU6ICANCj4gPiA+ID4gT24gRnJpLCAxNiBG
ZWIgMjAxOCAxNDowOToxNSArMDIwMA0KPiA+ID4gPiBBbGV4YW5kcnUgQXJkZWxlYW4gPGFsZXhh
bmRydS5hcmRlbGVhbkBhbmFsb2cuY29tPiB3cm90ZToNCj4gPiA+ID4gIA0KPiA+ID4gPiA+IFRo
aXMgaXMgYSBzbWFsbCBjbGVhbnVwIG9mIHRoZSBkcml2ZXIncyBpbml0IGNvZGUuDQo+ID4gPiA+
ID4gSXQgZG9lcyBub3QgZml4IGFueXRoaW5nLg0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IFRoZSBg
ZGV2bV9paW9fa2ZpZm9fYWxsb2NhdGUoKWAgZnVuY3Rpb24gaXMgdXNlZCBpbnN0ZWFkIG9mDQo+
ID4gPiA+ID4gYGlpb19rZmlmb19hbGxvY2F0ZSgpYC4gIFRoaXMgcmVtb3ZlcyB0aGUgbmVlZCBm
b3IgZXhwbGljaXQgZGVhbGxvY2F0aW9uIG9mDQo+ID4gPiA+ID4gdGhlIGRyaXZlcidzIGlpb19i
dWZmZXIsIHdoaWNoIHdpbGwgbm93IGJlIGhhbmRsZWQgdmlhDQo+ID4gPiA+ID4gYGlpb19kZXZp
Y2VfdW5yZWdpc3RlcigpYC4NCj4gPiA+ID4gPiANCj4gPiA+ID4gPiBUaGUgYHNldHVwX29wc2Ag
YXNzaWdubWVudCBoYXMgYmVlbiBtb3ZlZCBpbnRvIHRoZSBgYWQ1OTMzX3Byb2JlKClgIGNhbGws
DQo+ID4gPiA+ID4gc2luY2UgaXQncyBhIG9uZS1saW5lci4NCj4gPiA+ID4gPiANCj4gPiA+ID4g
PiBTaWduZWQtb2ZmLWJ5OiBBbGV4YW5kcnUgQXJkZWxlYW4gPGFsZXhhbmRydS5hcmRlbGVhbkBh
bmFsb2cuY29tPg0KPiA+ID4gPiA+IC0tLQ0KPiA+ID4gPiA+IA0KPiA+ID4gPiA+IE5vdGU6IHRo
aXMgY2hhbmdlIGlzIGJhc2VkIG9uIHRvcCBvZiBgZml4ZXMtdG9ncmVnLXBvc3QtcmMxYCBicmFu
Y2ggd2hpY2gNCj4gPiA+ID4gPiBjb250YWlucyBjb21taXQgKDdkMmI4ZTZhYWY5OiBzdGFnaW5n
OiBpaW86IGFkNTkzMzogc3dpdGNoIGJ1ZmZlciBtb2RlIHRvDQo+ID4gPiA+ID4gc29mdHdhcmUp
ICANCj4gPiA+ID4gDQo+ID4gPiA+IEl0IHdpbGwgdGFrZSBhIGZldyB3ZWVrcyBmb3IgdGhhdCB0
byBnZXQgdG8gbXkgdG9ncmVnIGJyYW5jaCBzbyBwbGVhc2UNCj4gPiA+ID4gZG8gcmVtaW5kIG1l
IGlmIGl0IGhhcyBhbmQgSSBzZWVtIHRvIGhhdmUgZm9yZ290dGVuIHRoaXMhDQo+ID4gPiA+IA0K
PiA+ID4gPiBKb25hdGhhbiAgDQo+ID4gPiANCj4gPiA+IEknbSBhIGJpdCBuZXcgdG8gaG93IHRo
aW5ncyBwcm9ncmVzcyBpbiB0aGUgaWlvIHN1YnRyZWUuDQo+ID4gPiBbQ3VyaW91c10gSXMgdGhl
cmUgYSByZWNvbW1lbmRlZCBicmFuY2ggdGhhdCBpcyByZWd1bGFybHkgdXBkYXRlZCB3aXRoIGFj
Y2VwdGVkDQo+ID4gPiBwYXRjaGVzID8NCj4gPiA+IE9yIHdoaWNoIGJyYW5jaGVzIGRvIEkgbmVl
ZCB0byByZWJhc2Ugd2hlbiBzdWJtaXR0aW5nIG90aGVyIHBhdGNoZXMgPyAgDQo+ID4gDQo+ID4g
DQo+ID4gU2FsdXQgQWxleGFuZHJ1LA0KPiA+IA0KPiA+IFlvdSBjYW4gdXNlIHRoZSB0b2dyZWcg
YnJhbmNoIG9mIGlpbyB0cmVlLg0KPiANCj4gVGhhdCB0ZW5kcyB0byBvbmx5IGdldCB1cGRhdGVk
IGZhaXJseSBpbmZyZXF1ZW50bHkgZXhjZXB0IHdoZW4gSSdtIGRvaW5nDQo+IGEgcHVsbCByZXF1
ZXN0IGJ1dCB0aGF0IGlzICdpbiB0aGVvcnknIHRoZSByaWdodCBicmFuY2ggdG8gdXNlLg0KPiAN
Cj4gSW4gcHJhY3RpY2UsIHRoZSBvbmx5IHJlYXNvbiBJJ2QgY2hhbmdlIHRoaW5ncyBpbiB0aGUg
dGVzdGluZyBicmFuY2gNCj4gaXMgYSBidWlsZCBmYWlsdXJlIG9yIGEgY29tbWVudCBmcm9tIHNv
bWVvbmUgc3VnZ2VzdGluZyBhIHJlYXNvbiB0byBwdWxsDQo+IGEgcGF0Y2guICBNaW5kIHlvdSBJ
J3ZlIGJlZW4gcHJldHR5IGJhZCBhdCByZW1lbWJlcmluZyB0byBwdXNoIHRoYXQgb3V0DQo+IGFz
IHdlbGwgcmVjZW50bHkgOiggIEkgb25seSBmaW5kIG91dCB3aGVuIEkgcmVhbGlzZSBJIGRpZG4n
dCBnZXQgYSBidWlsZA0KPiByZXBvcnQgZnJvbSAwLWRheSB3aGVuIEkgZ2V0IHRvIHdvcmsgb24g
TW9uZGF5Lg0KPiANCg0KSSBkb24ndCBrbm93IGFib3V0IHlvdSBndXlzLCBidXQgSSd2ZSBhbHdh
eXMgYmVlbiB0ZXJyaWJsZSBhdCBmb2xsb3dpbmcgZW1haWwNCnRocmVhZHMgYWZ0ZXIgdGhleSBn
byBhYm92ZSBhIGNlcnRhaW4gY291bnQuDQpXaGljaCBpcyB3aHkgSSBhbSBhcHByZWNpYXRpdmUg
d2hlbiB1c2luZyB3ZWItdG9vbHMgbGlrZSBHaXRodWIsIEdpdGxhYiwgZXRjIGFuZA0KdXNpbmcg
ZW1haWwgbW9zdGx5IGFzIGEgbm90aWZpY2F0aW9uIG1ldGhvZC4NCg0KSSBhZG1pdCB0aGVyZSdz
IHVzdWFsbHkgc29tZSBjb25jZXJuL3Jlc2lzdGFuY2UgdG8gY29uc2lkZXJpbmcgdGhlc2UgdG9v
bHMuDQoNCltJIHVzdWFsbHkgcmVmZXIgdG8gT3BlbldydCBmb3IgYSBsb3Qgb2YgZXhhbXBsZXMs
IHNpbmNlIEkgZm9sbG93IHRoZSBwcm9qZWN0XS4NCkN1cnJlbnRseSwgT3BlbldydCBoYXMgMiB3
YXlzIG9mIGFjY2VwdGluZyBwYXRjaGVzOiAxIHZpYSBHaXRodWIsIDEgdmlhIGVtYWlsICsNCnBh
dGNod29yay4NClRoZSBHaXRodWIgcmVwbyBpcyBqdXN0IGEgbWlycm9yIG9mIHRoZSBvZmZpY2lh
bCByZXBvLg0KW0FGQUlLXSBQYXRjaGVzIGdldCBhcHBsaWVkIHRvIHRoZSBvZmZpY2lhbCByZXBv
IGFuZCB0aGVuIG1pcnJvcmVkIG9uIEdpdGh1Yi4NCg0KQWxleA0KDQo+IEpvbmF0aGFuDQo+IA0K
PiA+IA0KPiA+IHRoYW5rcywNCj4gPiBEYW5pZWwuDQo+IA0KPiA=
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function
2018-02-24 12:18 ` Jonathan Cameron
2018-02-26 7:44 ` Ardelean, Alexandru
@ 2018-03-13 9:01 ` Ardelean, Alexandru
1 sibling, 0 replies; 7+ messages in thread
From: Ardelean, Alexandru @ 2018-03-13 9:01 UTC (permalink / raw)
To: jic23@jic23.retrosnub.co.uk
Cc: lars@metafoo.de, linux-iio@vger.kernel.org, Hennerich, Michael
T24gU2F0LCAyMDE4LTAyLTI0IGF0IDEyOjE4ICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl
Og0KPiBPbiBGcmksIDE2IEZlYiAyMDE4IDE0OjA5OjE1ICswMjAwDQo+IEFsZXhhbmRydSBBcmRl
bGVhbiA8YWxleGFuZHJ1LmFyZGVsZWFuQGFuYWxvZy5jb20+IHdyb3RlOg0KPiANCj4gPiBUaGlz
IGlzIGEgc21hbGwgY2xlYW51cCBvZiB0aGUgZHJpdmVyJ3MgaW5pdCBjb2RlLg0KPiA+IEl0IGRv
ZXMgbm90IGZpeCBhbnl0aGluZy4NCj4gPiANCj4gPiBUaGUgYGRldm1faWlvX2tmaWZvX2FsbG9j
YXRlKClgIGZ1bmN0aW9uIGlzIHVzZWQgaW5zdGVhZCBvZg0KPiA+IGBpaW9fa2ZpZm9fYWxsb2Nh
dGUoKWAuICBUaGlzIHJlbW92ZXMgdGhlIG5lZWQgZm9yIGV4cGxpY2l0IGRlYWxsb2NhdGlvbiBv
Zg0KPiA+IHRoZSBkcml2ZXIncyBpaW9fYnVmZmVyLCB3aGljaCB3aWxsIG5vdyBiZSBoYW5kbGVk
IHZpYQ0KPiA+IGBpaW9fZGV2aWNlX3VucmVnaXN0ZXIoKWAuDQo+ID4gDQo+ID4gVGhlIGBzZXR1
cF9vcHNgIGFzc2lnbm1lbnQgaGFzIGJlZW4gbW92ZWQgaW50byB0aGUgYGFkNTkzM19wcm9iZSgp
YCBjYWxsLA0KPiA+IHNpbmNlIGl0J3MgYSBvbmUtbGluZXIuDQo+ID4gDQo+ID4gU2lnbmVkLW9m
Zi1ieTogQWxleGFuZHJ1IEFyZGVsZWFuIDxhbGV4YW5kcnUuYXJkZWxlYW5AYW5hbG9nLmNvbT4N
Cj4gPiAtLS0NCj4gPiANCj4gPiBOb3RlOiB0aGlzIGNoYW5nZSBpcyBiYXNlZCBvbiB0b3Agb2Yg
YGZpeGVzLXRvZ3JlZy1wb3N0LXJjMWAgYnJhbmNoIHdoaWNoDQo+ID4gY29udGFpbnMgY29tbWl0
ICg3ZDJiOGU2YWFmOTogc3RhZ2luZzogaWlvOiBhZDU5MzM6IHN3aXRjaCBidWZmZXIgbW9kZSB0
bw0KPiA+IHNvZnR3YXJlKQ0KPiANCj4gSXQgd2lsbCB0YWtlIGEgZmV3IHdlZWtzIGZvciB0aGF0
IHRvIGdldCB0byBteSB0b2dyZWcgYnJhbmNoIHNvIHBsZWFzZQ0KPiBkbyByZW1pbmQgbWUgaWYg
aXQgaGFzIGFuZCBJIHNlZW0gdG8gaGF2ZSBmb3Jnb3R0ZW4gdGhpcyENCj4gDQoNCldhcyB0aGlz
IHN1cHBvc2VkIHRvIGdvIGludG8gb25lIG9mIHRoZSByZWNlbnQgcHVsbCByZXF1ZXN0cyA/DQpP
ciBpcyB0aGlzIGZvciBhIGxhdGVyIHB1bGwgPw0KDQpBbGV4DQoNCj4gSm9uYXRoYW4NCj4gDQo+
ID4gDQo+ID4gIGRyaXZlcnMvc3RhZ2luZy9paW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5j
IHwgMzUgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTAg
aW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvc3RhZ2luZy9paW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5jIGIvZHJpdmVycy9z
dGFnaW5nL2lpby9pbXBlZGFuY2UtYW5hbHl6ZXIvYWQ1OTMzLmMNCj4gPiBpbmRleCAzYmNmNDk0
NjYzNjEuLjFjYWI2N2IzYTgxZSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvaWlv
L2ltcGVkYW5jZS1hbmFseXplci9hZDU5MzMuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9p
aW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5jDQo+ID4gQEAgLTYzNSwyMiArNjM1LDYgQEAg
c3RhdGljIGNvbnN0IHN0cnVjdCBpaW9fYnVmZmVyX3NldHVwX29wcyBhZDU5MzNfcmluZ19zZXR1
cF9vcHMgPSB7DQo+ID4gIAkucG9zdGRpc2FibGUgPSBhZDU5MzNfcmluZ19wb3N0ZGlzYWJsZSwN
Cj4gPiAgfTsNCj4gPiAgDQo+ID4gLXN0YXRpYyBpbnQgYWQ1OTMzX3JlZ2lzdGVyX3JpbmdfZnVu
Y3NfYW5kX2luaXQoc3RydWN0IGlpb19kZXYgKmluZGlvX2RldikNCj4gPiAtew0KPiA+IC0Jc3Ry
dWN0IGlpb19idWZmZXIgKmJ1ZmZlcjsNCj4gPiAtDQo+ID4gLQlidWZmZXIgPSBpaW9fa2ZpZm9f
YWxsb2NhdGUoKTsNCj4gPiAtCWlmICghYnVmZmVyKQ0KPiA+IC0JCXJldHVybiAtRU5PTUVNOw0K
PiA+IC0NCj4gPiAtCWlpb19kZXZpY2VfYXR0YWNoX2J1ZmZlcihpbmRpb19kZXYsIGJ1ZmZlcik7
DQo+ID4gLQ0KPiA+IC0JLyogUmluZyBidWZmZXIgZnVuY3Rpb25zIC0gaGVyZSB0cmlnZ2VyIHNl
dHVwIHJlbGF0ZWQgKi8NCj4gPiAtCWluZGlvX2Rldi0+c2V0dXBfb3BzID0gJmFkNTkzM19yaW5n
X3NldHVwX29wczsNCj4gPiAtDQo+ID4gLQlyZXR1cm4gMDsNCj4gPiAtfQ0KPiA+IC0NCj4gPiAg
c3RhdGljIHZvaWQgYWQ1OTMzX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiA+ICB7
DQo+ID4gIAlzdHJ1Y3QgYWQ1OTMzX3N0YXRlICpzdCA9IGNvbnRhaW5lcl9vZih3b3JrLA0KPiA+
IEBAIC03MTQsMTIgKzY5OCwxOSBAQCBzdGF0aWMgaW50IGFkNTkzM19wcm9iZShzdHJ1Y3QgaTJj
X2NsaWVudCAqY2xpZW50LA0KPiA+ICAJaW50IHJldCwgdm9sdGFnZV91diA9IDA7DQo+ID4gIAlz
dHJ1Y3QgYWQ1OTMzX3BsYXRmb3JtX2RhdGEgKnBkYXRhID0gZGV2X2dldF9wbGF0ZGF0YSgmY2xp
ZW50LT5kZXYpOw0KPiA+ICAJc3RydWN0IGFkNTkzM19zdGF0ZSAqc3Q7DQo+ID4gKwlzdHJ1Y3Qg
aWlvX2J1ZmZlciAqYnVmZmVyOw0KPiA+ICAJc3RydWN0IGlpb19kZXYgKmluZGlvX2RldjsNCj4g
PiAgDQo+ID4gIAlpbmRpb19kZXYgPSBkZXZtX2lpb19kZXZpY2VfYWxsb2MoJmNsaWVudC0+ZGV2
LCBzaXplb2YoKnN0KSk7DQo+ID4gIAlpZiAoIWluZGlvX2RldikNCj4gPiAgCQlyZXR1cm4gLUVO
T01FTTsNCj4gPiAgDQo+ID4gKwlidWZmZXIgPSBkZXZtX2lpb19rZmlmb19hbGxvY2F0ZSgmY2xp
ZW50LT5kZXYpOw0KPiA+ICsJaWYgKCFidWZmZXIpDQo+ID4gKwkJcmV0dXJuIC1FTk9NRU07DQo+
ID4gKw0KPiA+ICsJaWlvX2RldmljZV9hdHRhY2hfYnVmZmVyKGluZGlvX2RldiwgYnVmZmVyKTsN
Cj4gPiArDQo+ID4gIAlzdCA9IGlpb19wcml2KGluZGlvX2Rldik7DQo+ID4gIAlpMmNfc2V0X2Ns
aWVudGRhdGEoY2xpZW50LCBpbmRpb19kZXYpOw0KPiA+ICAJc3QtPmNsaWVudCA9IGNsaWVudDsN
Cj4gPiBAQCAtNzYzLDIzICs3NTQsMTggQEAgc3RhdGljIGludCBhZDU5MzNfcHJvYmUoc3RydWN0
IGkyY19jbGllbnQgKmNsaWVudCwNCj4gPiAgCWluZGlvX2Rldi0+bW9kZXMgPSAoSU5ESU9fQlVG
RkVSX1NPRlRXQVJFIHwgSU5ESU9fRElSRUNUX01PREUpOw0KPiA+ICAJaW5kaW9fZGV2LT5jaGFu
bmVscyA9IGFkNTkzM19jaGFubmVsczsNCj4gPiAgCWluZGlvX2Rldi0+bnVtX2NoYW5uZWxzID0g
QVJSQVlfU0laRShhZDU5MzNfY2hhbm5lbHMpOw0KPiA+IC0NCj4gPiAtCXJldCA9IGFkNTkzM19y
ZWdpc3Rlcl9yaW5nX2Z1bmNzX2FuZF9pbml0KGluZGlvX2Rldik7DQo+ID4gLQlpZiAocmV0KQ0K
PiA+IC0JCWdvdG8gZXJyb3JfZGlzYWJsZV9yZWc7DQo+ID4gKwlpbmRpb19kZXYtPnNldHVwX29w
cyA9ICZhZDU5MzNfcmluZ19zZXR1cF9vcHM7DQo+ID4gIA0KPiA+ICAJcmV0ID0gYWQ1OTMzX3Nl
dHVwKHN0KTsNCj4gPiAgCWlmIChyZXQpDQo+ID4gLQkJZ290byBlcnJvcl91bnJlZ19yaW5nOw0K
PiA+ICsJCWdvdG8gZXJyb3JfZGlzYWJsZV9yZWc7DQo+ID4gIA0KPiA+ICAJcmV0ID0gaWlvX2Rl
dmljZV9yZWdpc3RlcihpbmRpb19kZXYpOw0KPiA+ICAJaWYgKHJldCkNCj4gPiAtCQlnb3RvIGVy
cm9yX3VucmVnX3Jpbmc7DQo+ID4gKwkJZ290byBlcnJvcl9kaXNhYmxlX3JlZzsNCj4gPiAgDQo+
ID4gIAlyZXR1cm4gMDsNCj4gPiAgDQo+ID4gLWVycm9yX3VucmVnX3Jpbmc6DQo+ID4gLQlpaW9f
a2ZpZm9fZnJlZShpbmRpb19kZXYtPmJ1ZmZlcik7DQo+ID4gIGVycm9yX2Rpc2FibGVfcmVnOg0K
PiA+ICAJcmVndWxhdG9yX2Rpc2FibGUoc3QtPnJlZyk7DQo+ID4gIA0KPiA+IEBAIC03OTIsNyAr
Nzc4LDYgQEAgc3RhdGljIGludCBhZDU5MzNfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll
bnQpDQo+ID4gIAlzdHJ1Y3QgYWQ1OTMzX3N0YXRlICpzdCA9IGlpb19wcml2KGluZGlvX2Rldik7
DQo+ID4gIA0KPiA+ICAJaWlvX2RldmljZV91bnJlZ2lzdGVyKGluZGlvX2Rldik7DQo+ID4gLQlp
aW9fa2ZpZm9fZnJlZShpbmRpb19kZXYtPmJ1ZmZlcik7DQo+ID4gIAlyZWd1bGF0b3JfZGlzYWJs
ZShzdC0+cmVnKTsNCj4gPiAgDQo+ID4gIAlyZXR1cm4gMDsNCj4gDQo+IA==
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-13 9:01 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-16 12:09 [PATCH] staging: iio: ad5933: merge ring init function into probe function Alexandru Ardelean
2018-02-24 12:18 ` Jonathan Cameron
2018-02-26 7:44 ` Ardelean, Alexandru
2018-02-26 10:47 ` Daniel Baluta
2018-03-03 15:00 ` Jonathan Cameron
2018-03-05 7:24 ` Ardelean, Alexandru
2018-03-13 9:01 ` Ardelean, Alexandru
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).