linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Himanshu Jha <himanshujha199640@gmail.com>
To: jic23@kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, pmeerw@pmeerw.net,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	daniel.baluta@gmail.com, 21cnbao@gmail.com,
	Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH v2 1/9] Staging: iio: accel: adis16201: Rename few macro definitions
Date: Sat, 17 Mar 2018 01:36:18 +0530	[thread overview]
Message-ID: <1521230786-18155-2-git-send-email-himanshujha199640@gmail.com> (raw)
In-Reply-To: <1521230786-18155-1-git-send-email-himanshujha199640@gmail.com>

Rename the macro definitions with suitable names specifying their
purpose.

* ADIS16201_STARTUP_DELAY_MS: Remove the comment specifying the delay in
  microseconds and rename it with addtition of _MS suffix.

* ADIS16201_MSC_CTRL_ACTIVE_DATA_RDY_HIGH: Rename the macro to make it
  similar to other misc control registers which denotes the data ready
  polarity.

* ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT: Rename to denote it is a
  failure bit.

* ADIS16201_GLOB_CMD_FACTORY_RESET: Remove ambiguous _CAL suffix and add
  _RESET suffix instead to denote factory reset command.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
v2:
   -explained every change in the process of renaming macros. 

 drivers/staging/iio/accel/adis16201.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
index 0fae8aa..767ebf0 100644
--- a/drivers/staging/iio/accel/adis16201.c
+++ b/drivers/staging/iio/accel/adis16201.c
@@ -20,7 +20,7 @@
 #include <linux/iio/buffer.h>
 #include <linux/iio/imu/adis.h>
 
-#define ADIS16201_STARTUP_DELAY	220 /* ms */
+#define ADIS16201_STARTUP_DELAY_MS	220
 
 /* Flash memory write count */
 #define ADIS16201_FLASH_CNT      0x00
@@ -118,7 +118,7 @@
 #define ADIS16201_MSC_CTRL_DATA_RDY_EN	        BIT(2)
 
 /* Data-ready polarity: 1 = active high, 0 = active low */
-#define ADIS16201_MSC_CTRL_ACTIVE_HIGH	        BIT(1)
+#define ADIS16201_MSC_CTRL_ACTIVE_DATA_RDY_HIGH	        BIT(1)
 
 /* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
 #define ADIS16201_MSC_CTRL_DATA_RDY_DIO1	BIT(0)
@@ -135,7 +135,7 @@
 #define ADIS16201_DIAG_STAT_SPI_FAIL_BIT   3
 
 /* Flash update failure */
-#define ADIS16201_DIAG_STAT_FLASH_UPT_BIT  2
+#define ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT  2
 
 /* Power supply above 3.625 V */
 #define ADIS16201_DIAG_STAT_POWER_HIGH_BIT 1
@@ -146,7 +146,7 @@
 /* GLOB_CMD */
 
 #define ADIS16201_GLOB_CMD_SW_RESET	BIT(7)
-#define ADIS16201_GLOB_CMD_FACTORY_CAL	BIT(1)
+#define ADIS16201_GLOB_CMD_FACTORY_RESET	BIT(1)
 
 #define ADIS16201_ERROR_ACTIVE          BIT(14)
 
@@ -290,7 +290,7 @@ static const struct iio_info adis16201_info = {
 
 static const char * const adis16201_status_error_msgs[] = {
 	[ADIS16201_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure",
-	[ADIS16201_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed",
+	[ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT] = "Flash update failed",
 	[ADIS16201_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V",
 	[ADIS16201_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V",
 };
@@ -303,11 +303,11 @@ static const struct adis_data adis16201_data = {
 
 	.self_test_mask = ADIS16201_MSC_CTRL_SELF_TEST_EN,
 	.self_test_no_autoclear = true,
-	.startup_delay = ADIS16201_STARTUP_DELAY,
+	.startup_delay = ADIS16201_STARTUP_DELAY_MS,
 
 	.status_error_msgs = adis16201_status_error_msgs,
 	.status_error_mask = BIT(ADIS16201_DIAG_STAT_SPI_FAIL_BIT) |
-		BIT(ADIS16201_DIAG_STAT_FLASH_UPT_BIT) |
+		BIT(ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT) |
 		BIT(ADIS16201_DIAG_STAT_POWER_HIGH_BIT) |
 		BIT(ADIS16201_DIAG_STAT_POWER_LOW_BIT),
 };
-- 
2.7.4


  reply	other threads:[~2018-03-16 20:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 20:06 [PATCH v2 0/9] Staging: iio: accel: adis16201 driver cleanup Himanshu Jha
2018-03-16 20:06 ` Himanshu Jha [this message]
2018-03-18  8:19   ` [PATCH v2 1/9] Staging: iio: accel: adis16201: Rename few macro definitions Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 2/9] Staging: iio: accel: adis16201: Remove unnecessary comments Himanshu Jha
2018-03-18  8:22   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 3/9] Staging: iio: accel: adis16201: Add _REG suffix to reisters Himanshu Jha
2018-03-18  8:24   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 4/9] Staging: iio: accel: adis16201: Group register definitions Himanshu Jha
2018-03-18  8:29   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 5/9] Staging: iio: accel: adis16201: Add comments about units in read_raw() Himanshu Jha
2018-03-18  8:32   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function Himanshu Jha
2018-03-18  8:33   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 7/9] Staging: iio: accel: adis16201: Prefer reverse christmas tree ordering Himanshu Jha
2018-03-18  8:34   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 8/9] Staging: iio: accel: adis16201: Adjust argument to match open parentheses Himanshu Jha
2018-03-18  8:35   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 9/9] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-18  9:31   ` Jonathan Cameron
2018-03-22 19:12   ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Himanshu Jha
2018-03-22 19:12     ` [PATCH 2/4] Staging: iio: accel: adis16201: Use GENMASK Himanshu Jha
2018-03-24 14:16       ` Jonathan Cameron
2018-03-22 19:12     ` [PATCH 3/4] Staging: iio: accel: adis16201: Fix 80 character line limit Himanshu Jha
2018-03-24 14:16       ` Jonathan Cameron
2018-03-22 19:12     ` [PATCH 4/4] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-24 14:26       ` Jonathan Cameron
2018-03-23 13:32     ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Jonathan Cameron
2018-03-24 14:15     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521230786-18155-2-git-send-email-himanshujha199640@gmail.com \
    --to=himanshujha199640@gmail.com \
    --cc=21cnbao@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).