From: Himanshu Jha <himanshujha199640@gmail.com>
To: jic23@kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, pmeerw@pmeerw.net,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
daniel.baluta@gmail.com, 21cnbao@gmail.com,
Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH v2 2/9] Staging: iio: accel: adis16201: Remove unnecessary comments
Date: Sat, 17 Mar 2018 01:36:19 +0530 [thread overview]
Message-ID: <1521230786-18155-3-git-send-email-himanshujha199640@gmail.com> (raw)
In-Reply-To: <1521230786-18155-1-git-send-email-himanshujha199640@gmail.com>
Remove few unnecessary comments since the macro definitions clearly
justify their purpose.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
v2:
-reodered patch series.
drivers/staging/iio/accel/adis16201.c | 36 -----------------------------------
1 file changed, 36 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
index 767ebf0..6c06c0d 100644
--- a/drivers/staging/iio/accel/adis16201.c
+++ b/drivers/staging/iio/accel/adis16201.c
@@ -22,96 +22,66 @@
#define ADIS16201_STARTUP_DELAY_MS 220
-/* Flash memory write count */
#define ADIS16201_FLASH_CNT 0x00
-/* Output, power supply */
#define ADIS16201_SUPPLY_OUT 0x02
-/* Output, x-axis accelerometer */
#define ADIS16201_XACCL_OUT 0x04
-/* Output, y-axis accelerometer */
#define ADIS16201_YACCL_OUT 0x06
-/* Output, auxiliary ADC input */
#define ADIS16201_AUX_ADC 0x08
-/* Output, temperature */
#define ADIS16201_TEMP_OUT 0x0A
-/* Output, x-axis inclination */
#define ADIS16201_XINCL_OUT 0x0C
-/* Output, y-axis inclination */
#define ADIS16201_YINCL_OUT 0x0E
-/* Calibration, x-axis acceleration offset */
#define ADIS16201_XACCL_OFFS 0x10
-/* Calibration, y-axis acceleration offset */
#define ADIS16201_YACCL_OFFS 0x12
-/* x-axis acceleration scale factor */
#define ADIS16201_XACCL_SCALE 0x14
-/* y-axis acceleration scale factor */
#define ADIS16201_YACCL_SCALE 0x16
-/* Calibration, x-axis inclination offset */
#define ADIS16201_XINCL_OFFS 0x18
-/* Calibration, y-axis inclination offset */
#define ADIS16201_YINCL_OFFS 0x1A
-/* x-axis inclination scale factor */
#define ADIS16201_XINCL_SCALE 0x1C
-/* y-axis inclination scale factor */
#define ADIS16201_YINCL_SCALE 0x1E
-/* Alarm 1 amplitude threshold */
#define ADIS16201_ALM_MAG1 0x20
-/* Alarm 2 amplitude threshold */
#define ADIS16201_ALM_MAG2 0x22
-/* Alarm 1, sample period */
#define ADIS16201_ALM_SMPL1 0x24
-/* Alarm 2, sample period */
#define ADIS16201_ALM_SMPL2 0x26
-/* Alarm control */
#define ADIS16201_ALM_CTRL 0x28
-/* Auxiliary DAC data */
#define ADIS16201_AUX_DAC 0x30
-/* General-purpose digital input/output control */
#define ADIS16201_GPIO_CTRL 0x32
-/* Miscellaneous control */
#define ADIS16201_MSC_CTRL 0x34
-/* Internal sample period (rate) control */
#define ADIS16201_SMPL_PRD 0x36
/* Operation, filter configuration */
#define ADIS16201_AVG_CNT 0x38
-/* Operation, sleep mode control */
#define ADIS16201_SLP_CNT 0x3A
-/* Diagnostics, system status register */
#define ADIS16201_DIAG_STAT 0x3C
-/* Operation, system command register */
#define ADIS16201_GLOB_CMD 0x3E
-/* MSC_CTRL */
-/* Self-test enable */
#define ADIS16201_MSC_CTRL_SELF_TEST_EN BIT(8)
/* Data-ready enable: 1 = enabled, 0 = disabled */
@@ -123,18 +93,13 @@
/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
#define ADIS16201_MSC_CTRL_DATA_RDY_DIO1 BIT(0)
-/* DIAG_STAT */
-/* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
#define ADIS16201_DIAG_STAT_ALARM2 BIT(9)
-/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
#define ADIS16201_DIAG_STAT_ALARM1 BIT(8)
-/* SPI communications failure */
#define ADIS16201_DIAG_STAT_SPI_FAIL_BIT 3
-/* Flash update failure */
#define ADIS16201_DIAG_STAT_FLASH_UPT_FAIL_BIT 2
/* Power supply above 3.625 V */
@@ -143,7 +108,6 @@
/* Power supply below 3.15 V */
#define ADIS16201_DIAG_STAT_POWER_LOW_BIT 0
-/* GLOB_CMD */
#define ADIS16201_GLOB_CMD_SW_RESET BIT(7)
#define ADIS16201_GLOB_CMD_FACTORY_RESET BIT(1)
--
2.7.4
next prev parent reply other threads:[~2018-03-16 20:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 20:06 [PATCH v2 0/9] Staging: iio: accel: adis16201 driver cleanup Himanshu Jha
2018-03-16 20:06 ` [PATCH v2 1/9] Staging: iio: accel: adis16201: Rename few macro definitions Himanshu Jha
2018-03-18 8:19 ` Jonathan Cameron
2018-03-16 20:06 ` Himanshu Jha [this message]
2018-03-18 8:22 ` [PATCH v2 2/9] Staging: iio: accel: adis16201: Remove unnecessary comments Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 3/9] Staging: iio: accel: adis16201: Add _REG suffix to reisters Himanshu Jha
2018-03-18 8:24 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 4/9] Staging: iio: accel: adis16201: Group register definitions Himanshu Jha
2018-03-18 8:29 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 5/9] Staging: iio: accel: adis16201: Add comments about units in read_raw() Himanshu Jha
2018-03-18 8:32 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function Himanshu Jha
2018-03-18 8:33 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 7/9] Staging: iio: accel: adis16201: Prefer reverse christmas tree ordering Himanshu Jha
2018-03-18 8:34 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 8/9] Staging: iio: accel: adis16201: Adjust argument to match open parentheses Himanshu Jha
2018-03-18 8:35 ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 9/9] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-18 9:31 ` Jonathan Cameron
2018-03-22 19:12 ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Himanshu Jha
2018-03-22 19:12 ` [PATCH 2/4] Staging: iio: accel: adis16201: Use GENMASK Himanshu Jha
2018-03-24 14:16 ` Jonathan Cameron
2018-03-22 19:12 ` [PATCH 3/4] Staging: iio: accel: adis16201: Fix 80 character line limit Himanshu Jha
2018-03-24 14:16 ` Jonathan Cameron
2018-03-22 19:12 ` [PATCH 4/4] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-24 14:26 ` Jonathan Cameron
2018-03-23 13:32 ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Jonathan Cameron
2018-03-24 14:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521230786-18155-3-git-send-email-himanshujha199640@gmail.com \
--to=himanshujha199640@gmail.com \
--cc=21cnbao@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=daniel.baluta@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).