From: Jorge Ramirez-Ortiz <jramirez@baylibre.com>
To: jramirez@baylibre.com, jic23@kernel.org, lorenzo.bianconi@redhat.com
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] iio: imu: st_lsm6dsx: irq not handled unless data pushed to buffers
Date: Wed, 11 Jul 2018 10:32:08 +0200 [thread overview]
Message-ID: <1531297928-3824-1-git-send-email-jramirez@baylibre.com> (raw)
Currently IRQ_NONE is returned only when there is no data on the fifo.
When there is no data on the fifo the driver can not push to the
buffers and therefore user space readers polling for data available
will not be awoken and continue to wait.
This commit just extends the same semantics to fifo read errors.
Signed-off-by: Jorge Ramirez-Ortiz <jramirez@baylibre.com>
---
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
index 4994f92..4959923 100644
--- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
+++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c
@@ -472,7 +472,7 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private)
count = st_lsm6dsx_read_fifo(hw);
mutex_unlock(&hw->fifo_lock);
- return !count ? IRQ_NONE : IRQ_HANDLED;
+ return (!count || count < 0) ? IRQ_NONE : IRQ_HANDLED;
}
static int st_lsm6dsx_buffer_preenable(struct iio_dev *iio_dev)
--
2.7.4
next reply other threads:[~2018-07-11 8:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 8:32 Jorge Ramirez-Ortiz [this message]
2018-07-11 12:29 ` [PATCH] iio: imu: st_lsm6dsx: irq not handled unless data pushed to buffers Lorenzo Bianconi
2018-07-11 13:24 ` Jorge Ramirez-Ortiz
2018-07-11 14:17 ` Lorenzo Bianconi
2018-07-11 15:26 ` Lorenzo Bianconi
2018-07-11 16:00 ` Jorge Ramirez-Ortiz
2018-07-11 16:34 ` Lorenzo Bianconi
2018-07-11 16:59 ` Jorge Ramirez-Ortiz
2018-07-11 17:07 ` Lorenzo Bianconi
2018-07-12 7:59 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531297928-3824-1-git-send-email-jramirez@baylibre.com \
--to=jramirez@baylibre.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).