From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa5.microchip.iphmx.com ([216.71.150.166]:38679 "EHLO esa5.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725935AbeIXN6V (ORCPT ); Mon, 24 Sep 2018 09:58:21 -0400 From: Eugen Hristev To: , , , , CC: , Eugen Hristev , Maxime Ripard Subject: [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode Date: Mon, 24 Sep 2018 10:51:44 +0300 Message-ID: <1537775504-7981-2-git-send-email-eugen.hristev@microchip.com> In-Reply-To: <1537775504-7981-1-git-send-email-eugen.hristev@microchip.com> References: <1537775504-7981-1-git-send-email-eugen.hristev@microchip.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org When channels are registered, the hardware channel number is not the actual iio channel number. This is because the driver is probed with a certain number of accessible channels. Some pins are routed and some not, depending on the description of the board in the DT. Because of that, channels 0,1,2,3 can correspond to hardware channels 2,3,4,5 for example. In the buffered triggered case, we need to do the translation accordingly. Fixed the channel number to stop reading the wrong channel. Fixes 0e589d5fb "ARM: AT91: IIO: Add AT91 ADC driver." Cc: Maxime Ripard Signed-off-by: Eugen Hristev --- Changes in v2: - Added 'const' spec to the declaration to avoid build warning drivers/iio/adc/at91_adc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c index e3be88e..75d2f73 100644 --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -248,12 +248,14 @@ static irqreturn_t at91_adc_trigger_handler(int irq, void *p) struct iio_poll_func *pf = p; struct iio_dev *idev = pf->indio_dev; struct at91_adc_state *st = iio_priv(idev); + struct iio_chan_spec const *chan; int i, j = 0; for (i = 0; i < idev->masklength; i++) { if (!test_bit(i, idev->active_scan_mask)) continue; - st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, i)); + chan = idev->channels + i; + st->buffer[j] = at91_adc_readl(st, AT91_ADC_CHAN(st, chan->channel)); j++; } -- 2.7.4