From: Paul Cercueil <paul@crapouillou.net>
To: Sebastian Reichel <sre@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Artur Rojek <contact@artur-rojek.eu>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] power: supply: add Ingenic JZ47xx battery driver.
Date: Mon, 08 Apr 2019 12:23:03 +0200 [thread overview]
Message-ID: <1554718983.1893.0@crapouillou.net> (raw)
In-Reply-To: <20190408093824.yzpd7mve6df7lpka@earth.universe>
Le lun. 8 avril 2019 à 11:38, Sebastian Reichel <sre@kernel.org> a
écrit :
> Hi Paul,
>
> On Sun, Apr 07, 2019 at 09:07:57PM +0200, Paul Cercueil wrote:
>> Hi Sebastian,
>>
>> Le dim. 7 avril 2019 à 18:52, Sebastian Reichel <sre@kernel.org> a
>> écrit :
>> > Hi,
>> >
>> > On Sun, Mar 24, 2019 at 03:31:37PM +0000, Jonathan Cameron wrote:
>> > > On Sat, 23 Mar 2019 18:28:09 +0100
>> > > Artur Rojek <contact@artur-rojek.eu> wrote:
>> > >
>> > > > Add a driver for battery present on Ingenic JZ47xx SoCs.
>> > > >
>> > > > Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
>> > > The IIO parts look fine to me.
>> > > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>> > >
>> > > Sebastian, assuming you are happy with this version,
>> >
>> > The driver itself looks ok. I'm a bit unhappy, that we already
>> have
>> > jz4740-battery. This driver is much cleaner, but does not yet seem
>> > to be ready to replace it. Artur Rojek what are your plans
>> regarding
>> > to the existing driver? Is there currently work going on migrating
>> > JZ47xx to DT?
>>
>> Why do you think it's not ready? Feature-wise, it has everything we
>> need to replace jz4740-battery, which will be trashed as soon as the
>> LB60 board code is updated to use the new driver.
>
> jz4740-battery has a few features not provided by your driver.
> For example the gpio providing the charging status.
Artur sumitted a separate patchset for this functionality:
https://lkml.org/lkml/2019/2/26/501
> Assuming you plan to trash the old driver soon:
>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
>
>> We are working on porting the JZ47xx code to devicetree, yes. The
>> ultimate goal is to completely get rid of
>> arch/mips/jz4740/board-qi_lb60.c and arch/mips/jz4740/platform.c.
>
> Ok, sounds good.
>
> -- Sebastian
next prev parent reply other threads:[~2019-04-08 10:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-23 17:28 [PATCH v2 1/4] iio: inkern: API for reading available iio channel attribute values Artur Rojek
2019-03-23 17:28 ` [PATCH v2 2/4] iio: inkern: Convert iio_read_avail_channel_raw into a wrapper Artur Rojek
2019-03-24 15:27 ` Jonathan Cameron
2019-04-14 10:35 ` Jonathan Cameron
2019-03-23 17:28 ` [PATCH v2 3/4] dt-bindings: power: supply: Add docs for Ingenic JZ47xx SoCs battery Artur Rojek
2019-03-24 15:30 ` Jonathan Cameron
2019-04-18 19:47 ` Sebastian Reichel
2019-03-23 17:28 ` [PATCH v2 4/4] power: supply: add Ingenic JZ47xx battery driver Artur Rojek
2019-03-24 15:31 ` Jonathan Cameron
2019-04-07 16:52 ` Sebastian Reichel
2019-04-07 19:07 ` Paul Cercueil
2019-04-08 9:38 ` Sebastian Reichel
2019-04-08 10:23 ` Paul Cercueil [this message]
2019-04-14 10:37 ` Jonathan Cameron
2019-04-15 22:09 ` Sebastian Reichel
2019-03-24 15:27 ` [PATCH v2 1/4] iio: inkern: API for reading available iio channel attribute values Jonathan Cameron
2019-04-14 10:34 ` Jonathan Cameron
2019-04-18 19:47 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554718983.1893.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).