From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E33C10F03 for ; Wed, 24 Apr 2019 00:51:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAB62218D2 for ; Wed, 24 Apr 2019 00:51:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728831AbfDXAvi (ORCPT ); Tue, 23 Apr 2019 20:51:38 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:60373 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1728536AbfDXAvi (ORCPT ); Tue, 23 Apr 2019 20:51:38 -0400 X-UUID: 2214224984e14755960ec97b15db1950-20190424 X-UUID: 2214224984e14755960ec97b15db1950-20190424 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1988789052; Wed, 24 Apr 2019 08:51:33 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Apr 2019 08:51:32 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Wed, 24 Apr 2019 08:51:31 +0800 Message-ID: <1556067091.21970.16.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: adc: mt8183: add binding document From: Zhiyong Tao To: Matthias Brugger CC: , , , , , , , , , , , , , , , , Date: Wed, 24 Apr 2019 08:51:31 +0800 In-Reply-To: <4c7f244f-4111-9e28-5134-8f108b1dbafa@gmail.com> References: <20190422115417.16751-1-zhiyong.tao@mediatek.com> <20190422115417.16751-2-zhiyong.tao@mediatek.com> <4c7f244f-4111-9e28-5134-8f108b1dbafa@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, 2019-04-23 at 16:35 +0200, Matthias Brugger wrote: > > On 22/04/2019 13:54, Zhiyong Tao wrote: > > The commit adds mt8183 compatible node in binding document. > > > > Signed-off-by: Zhiyong Tao > > --- > > Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > index 0df9befdaecc..05bc79d8483c 100644 > > --- a/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > +++ b/Documentation/devicetree/bindings/iio/adc/mt6577_auxadc.txt > > @@ -15,6 +15,7 @@ Required properties: > > - "mediatek,mt2712-auxadc": For MT2712 family of SoCs > > - "mediatek,mt7622-auxadc": For MT7622 family of SoCs > > - "mediatek,mt8173-auxadc": For MT8173 family of SoCs > > + - "mediatek,mt8183-auxadc": For MT8183 family of SoCs > > - reg: Address range of the AUXADC unit. > > - clocks: Should contain a clock specifier for each entry in clock-names > > - clock-names: Should contain "main". > > > > You are missing the logic in the driver to bind against this compatible. > If there is nothing different from other SoCs then you could add a compatible > with a fallback, like: > > "mediatek,mt8183-auxadc", "mediatek,mt7622-auxadc": For MT8183 family of SoCs ==> Thanks for your suggestion. In v2, we will add the comment here: - "mediatek,mt8183-auxadc", "mediatek,mt8173-auxadc": For MT8183 family of SoCs. > > Regards, > Matthias