From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9AFFC04AAF for ; Mon, 20 May 2019 06:03:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86CAE20815 for ; Mon, 20 May 2019 06:03:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729692AbfETGDc (ORCPT ); Mon, 20 May 2019 02:03:32 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:17279 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726196AbfETGDb (ORCPT ); Mon, 20 May 2019 02:03:31 -0400 X-UUID: 0b1af7105e2f48fd873b32133c84ed3c-20190520 X-UUID: 0b1af7105e2f48fd873b32133c84ed3c-20190520 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 450186333; Mon, 20 May 2019 14:03:26 +0800 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs08n1.mediatek.inc (172.21.101.55) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 20 May 2019 14:03:25 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 20 May 2019 14:03:25 +0800 Message-ID: <1558332205.11080.6.camel@mtkswgap22> Subject: Re: [PATCH 3/4] iio: adc: mediatek: SET_LATE_SYSTEM_SLEEP_PM_OPS support From: Chun-Hung Wu To: Jonathan Cameron CC: Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Rob Herring , Mark Rutland , Matthias Brugger , , , , , , , , , Date: Mon, 20 May 2019 14:03:25 +0800 In-Reply-To: <20190518113527.5210b0bf@archlinux> References: <1557994247-16739-1-git-send-email-chun-hung.wu@mediatek.com> <1557994247-16739-4-git-send-email-chun-hung.wu@mediatek.com> <20190518113527.5210b0bf@archlinux> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Hi Jonathan: Thanks for the prompt reply, On Sat, 2019-05-18 at 11:35 +0100, Jonathan Cameron wrote: > On Thu, 16 May 2019 16:10:46 +0800 > Chun-Hung Wu wrote: > > > Move suspend/resume to late_suspend and > > early_resume to gurantee users can use auxadc > guarantee > will fix it in next version. > > driver at suspend/resume stage. > No problem with the patch content, but we need a reason why they may > want to do so? Our thermal drivers uses auxadc at suspend/resume stage. In order to avoid auxadc suspended prior to thermal driver, we move auxadc to late_suspend and early_resume. Thanks, Chun-Hung > > Thanks, > > Jonathan > > > > Signed-off-by: Chun-Hung Wu > > --- > > drivers/iio/adc/mt6577_auxadc.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c > > index e1bdcc0..58d7cb2 100644 > > --- a/drivers/iio/adc/mt6577_auxadc.c > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > @@ -326,9 +326,10 @@ static int mt6577_auxadc_remove(struct platform_device *pdev) > > return 0; > > } > > > > -static SIMPLE_DEV_PM_OPS(mt6577_auxadc_pm_ops, > > - mt6577_auxadc_suspend, > > - mt6577_auxadc_resume); > > +static const struct dev_pm_ops mt6577_auxadc_pm_ops = { > > + SET_LATE_SYSTEM_SLEEP_PM_OPS(mt6577_auxadc_suspend, > > + mt6577_auxadc_resume) > > +}; > > > > static const struct of_device_id mt6577_auxadc_of_match[] = { > > { .compatible = "mediatek,mt2701-auxadc", .data = &mt8173_compat}, >