Re: [PATCH 02/10] dt-bindings: iio: adc: at91-sama5d2: add rtc-trigger optional property

Jonathan Cameron
2019-12-23T11:58:57Z

On Wed, 18 Dec 2019 16:23:58 +0000
<Eugen.Hristev@microchip.com> wrote:

> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Add property to connect RTC-type trigger to the ADC block.
> The ADC is connected internally with a line to the RTC block.
> The RTC can provide a trigger signal to the ADC to start conversions.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
As discussed, might want to just be the rtc handle rather than a new
trigger one.

> ---
> Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> index 4a3c1d4..1980f0e 100644
> --- a/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> +++ b/Documentation/devicetree/bindings/iio/adc/at91-sama5d2_adc.txt
> @@ -23,6 +23,9 @@ Optional properties:
> See ../../dma/dma.txt for details.
> - #io-channel-cells: in case consumer drivers are attached, this must be 1.
> See <Documentation/devicetree/bindings/iio/iio-bindings.txt> for details.
> + - atmel,rtc-trigger: The ADC IP block can be triggered by the RTC block
> +inside the SoC. This property is a phandle to a node that provides a
> +trigger device, if the ADC block supports it.

Do we want to be more specific on devices that do support it?
Maybe it's enough of a complex mess that we don't.

>
> Properties for consumer drivers:
> - Consumer drivers can be connected to this producer device, as specified
> @@ -44,6 +47,7 @@ adc: adc@fc030000 {
> vddana-supply = <&vdd_3v3_lp_reg>;
> vref-supply = <&vdd_3v3_lp_reg>;
> atmel,trigger-edge-type = <IRQ_TYPE_EDGE_BOTH>;
> + atmel,rtc-trigger = <&rtc_adc_trigger>;
> dmas = <&dma0 (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1) | AT91_XDMAC_DT_PERID(25))>;
> dma-names = "rx";
> #io-channel-cells = <1>;