linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Rob Herring <robh+dt@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org
Subject: Re: [PATCH 05/15] dt-bindings: iio: dac: ad5446: Add missing binding document
Date: Thu, 01 Jul 2021 08:02:43 -0600	[thread overview]
Message-ID: <1625148163.528787.2278697.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210627163244.1090296-6-jic23@kernel.org>

On Sun, 27 Jun 2021 17:32:34 +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Binding is a little stricter than the Linux driver.
> 
> It requires vcc-supply to be present for devices that don't have
> an internal reference, whereas the driver just prints a message and
> carries on.  Given this means that it is impossible to establish
> a scaling of the output channel, let us make it required in the binding
> schema.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  .../bindings/iio/dac/adi,ad5446.yaml          | 105 ++++++++++++++++++
>  1 file changed, 105 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/ti,dac7512.example.dt.yaml: dac@0: 'vcc-supply' is a required property
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml
\ndoc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1497723

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.


  reply	other threads:[~2021-07-01 14:03 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-27 16:32 [PATCH 00/15] dt-bindings: iio: dac: Add most missing binding documents Jonathan Cameron
2021-06-27 16:32 ` [PATCH 01/15] dt-bindings: iio: dac: adi,ad5421: Add missing binding document Jonathan Cameron
2021-07-14 15:47   ` Rob Herring
2021-06-27 16:32 ` [PATCH 02/15] dt-bindings: iio: dac: adi,ad5064: Document bindings for many different DACs Jonathan Cameron
2021-07-14 15:49   ` Rob Herring
2021-06-27 16:32 ` [PATCH 03/15] dt-bindings: iio: dac: adi,ad5360: Add missing binding document Jonathan Cameron
2021-07-14 15:50   ` Rob Herring
2021-06-27 16:32 ` [PATCH 04/15] dt-bindings: iio: dac: ad5380: " Jonathan Cameron
2021-07-14 15:54   ` Rob Herring
2021-07-17 18:01     ` Jonathan Cameron
2021-06-27 16:32 ` [PATCH 05/15] dt-bindings: iio: dac: ad5446: " Jonathan Cameron
2021-07-01 14:02   ` Rob Herring [this message]
2021-07-01 19:30     ` Rob Herring
2021-06-27 16:32 ` [PATCH 06/15] dt-bindings: iio: dac: ad5449: " Jonathan Cameron
2021-07-14 15:55   ` Rob Herring
2021-06-27 16:32 ` [PATCH 07/15] dt-bindings: iio: dac: ad5504: " Jonathan Cameron
2021-07-14 15:55   ` Rob Herring
2021-06-27 16:32 ` [PATCH 08/15] iio: dac: ad5624r: Fix incorrect handling of an optional regulator Jonathan Cameron
2021-06-27 17:29   ` kernel test robot
2021-07-17 18:06     ` Jonathan Cameron
2021-06-27 16:32 ` [PATCH 09/15] dt-bindings: iio: dac: ad5624r: Add missing binding document Jonathan Cameron
2021-07-14 15:56   ` Rob Herring
2021-06-27 16:32 ` [PATCH 10/15] dt-bindings: iio: dac: ad5686 and ad5696: " Jonathan Cameron
2021-07-14 15:57   ` Rob Herring
2021-06-27 16:32 ` [PATCH 11/15] dt-bindings: iio: dac: ad5761: Add missing binding doc Jonathan Cameron
2021-07-14 15:58   ` Rob Herring
2021-07-27 10:52     ` Ricardo Ribalda Delgado
2021-06-27 16:32 ` [PATCH 12/15] dt-bindings: iio: dac: adi,ad5764: Add missing binding document Jonathan Cameron
2021-07-14 15:58   ` Rob Herring
2021-06-27 16:32 ` [PATCH 13/15] dt-bindings: iio: dac: adi,ad5791: Add missing bindings document Jonathan Cameron
2021-07-14 15:59   ` Rob Herring
2021-06-27 16:32 ` [PATCH 14/15] dt-bindings: iio: dac: adi,ad8801: Add missing binding document Jonathan Cameron
2021-07-14 15:59   ` Rob Herring
2021-06-27 16:32 ` [PATCH 15/15] dt-bindings: iio: dac: microchip,mcp4922: " Jonathan Cameron
2021-07-14 15:59   ` Rob Herring
2021-06-28  7:09 ` [PATCH 00/15] dt-bindings: iio: dac: Add most missing binding documents Sa, Nuno
2021-06-28 13:44   ` Jonathan Cameron
2021-06-29  8:28     ` Sa, Nuno
2021-07-17 18:11       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1625148163.528787.2278697.nullmailer@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).