From: Rob Herring <robh@kernel.org>
To: Cristian Pop <cristian.pop@analog.com>
Cc: devicetree@vger.kernel.org, jic23@kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v2 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc
Date: Tue, 01 Feb 2022 21:40:40 -0600 [thread overview]
Message-ID: <1643773240.843870.1397925.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220201162351.53520-1-cristian.pop@analog.com>
On Tue, 01 Feb 2022 18:23:50 +0200, Cristian Pop wrote:
> Add device tree bindings for the ADMV4420 K band downconverter.
>
> Signed-off-by: Cristian Pop <cristian.pop@analog.com>
> ---
> changes in v2:
> - Fix indentation
> - Remove '|', there is no formatting to persevere
> - Add plank line before 'properties:'
> - replace '_' with '-' in property names
> .../bindings/iio/frequency/adi,admv4420.yaml | 54 +++++++++++++++++++
> 1 file changed, 54 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
./Documentation/devicetree/bindings/iio/frequency/adi,admv4420.yaml:13:5: [warning] wrong indentation: expected 2 but found 4 (indentation)
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/frequency/adi,admv4420.example.dt.yaml: admv4420@0: adi,lo-freq-hz: 'anyOf' conditional failed, one must be fixed:
16743700000 is greater than the maximum of 4294967295
From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/property-units.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1587310
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2022-02-02 3:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 16:23 [PATCH v2 1/2] dt:bindings:iio:frequency: Add ADMV4420 doc Cristian Pop
2022-02-01 16:23 ` [PATCH v2 2/2] iio:frequency:admv4420.c: Add support for ADMV4420 Cristian Pop
2022-02-05 18:23 ` Jonathan Cameron
2022-02-02 3:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1643773240.843870.1397925.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=cristian.pop@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox