From: Rob Herring <robh@kernel.org>
To: haibo.chen@nxp.com
Cc: lars@metafoo.de, krzysztof.kozlowski+dt@linaro.org,
kernel@pengutronix.de, festevam@gmail.com,
linux-iio@vger.kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org,
jic23@kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for NXP IMX93 ADC
Date: Wed, 14 Dec 2022 08:56:53 -0600 [thread overview]
Message-ID: <167102966432.1040986.12796829521940941811.robh@kernel.org> (raw)
In-Reply-To: <1671024939-29322-2-git-send-email-haibo.chen@nxp.com>
On Wed, 14 Dec 2022 21:35:38 +0800, haibo.chen@nxp.com wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> The IMX93 SoC has a new ADC IP, so add binding documentation
> for NXP IMX93 ADC.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> .../bindings/iio/adc/nxp,imx93-adc.yaml | 79 +++++++++++++++++++
> 1 file changed, 79 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.example.dtb: adc@44530000: '#io-channel-cells' is a required property
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.example.dtb: adc@44530000: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/1671024939-29322-2-git-send-email-haibo.chen@nxp.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2022-12-14 14:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 13:35 [PATCH v2 1/3] iio: adc: add imx93 adc support haibo.chen
2022-12-14 13:35 ` [PATCH v2 2/3] dt-bindings: iio: adc: Add binding documentation for NXP IMX93 ADC haibo.chen
2022-12-14 14:56 ` Rob Herring [this message]
2022-12-14 15:00 ` Rob Herring
2022-12-15 10:11 ` Krzysztof Kozlowski
2022-12-19 8:52 ` Bough Chen
2022-12-19 8:59 ` Krzysztof Kozlowski
2022-12-14 13:35 ` [PATCH v2 3/3] arm64: dts: imx93: add ADC support haibo.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167102966432.1040986.12796829521940941811.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox