Re: [PATCH 1/2] iio: hrtimer-trigger: Mark hrtimer to expire in hard interrupt context

Jonathan Cameron
2020-09-21T09:58:44Z

On Mon, 21 Sep 2020 09:17:26 +0200
Christian Eggers <ceggers@arri.de> wrote:

> Tested together with
>
> - iio: Fix: Do not poll the driver again if try_reenable() callback returns non 0.
> and
> - iio:trigger: rename try_reenable() to reenable() plus return void
>
> on latest mainline (without PREEMPT_RT). The original WARN_ONCE() in
> kernel/irq/handle.c:159 was not raised anymore. But even without the current
> patches, this warning is not shown (as this problem only applies to -RT).
>
> Currently I haven't ported a RT kernel > 5.4 for my board, so I cannot check
> with current RT. On 5.4. there the patches seem not to work fully as
> kernel/timer/hrtimer.c is not up to date enough.
>
> Sorry for being not very helpful...
Thanks for at least trying!

So looking at this the other way, are there any significant risks associated
with this change? If not I'm tempted to queue them up and we have the rcX
time to fix anything we've missed (just like every other patch!)

Jonathan

>
> Best regards
> Christian
>
> On Sunday, 20 September 2020, 20:15:45 CEST, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > As we no longer support a try again if we cannot reenable the trigger
> > rename the function to reflect this. Also we don't do anything with
> > the value returned so stop it returning anything. For the few drivers
> > that didn't already print an error message in this patch, add such
> > a print.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> > Cc: Christian Oder <me@myself5.de>
> > Cc: Eugen Hristev <eugen.hristev@microchip.com>
> > Cc: Nishant Malpani <nish.malpani25@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@oss.nxp.com>
> > ---
>
>
>